All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] makedumpfile: add a missing return statement
@ 2012-08-28 15:16 Petr Tesarik
  2012-08-30  6:32 ` Atsushi Kumagai
  0 siblings, 1 reply; 2+ messages in thread
From: Petr Tesarik @ 2012-08-28 15:16 UTC (permalink / raw)
  To: kexec

The remap_init() function lacks a return statement when all goes well.

Signed-off-by: Petr Tesarik <ptesarik@suse.cz>

---
 arch/x86.c |    1 +
 1 file changed, 1 insertion(+)

--- a/arch/x86.c
+++ b/arch/x86.c
@@ -64,6 +64,7 @@ remap_init(void)
 	}
 
 	max_numnodes = n;
+	return TRUE;
 }
 
 int



_______________________________________________
kexec mailing list
kexec@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/kexec

^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [PATCH] makedumpfile: add a missing return statement
  2012-08-28 15:16 [PATCH] makedumpfile: add a missing return statement Petr Tesarik
@ 2012-08-30  6:32 ` Atsushi Kumagai
  0 siblings, 0 replies; 2+ messages in thread
From: Atsushi Kumagai @ 2012-08-30  6:32 UTC (permalink / raw)
  To: ptesarik; +Cc: kexec

Hello Petr,

On Tue, 28 Aug 2012 17:16:02 +0200
Petr Tesarik <ptesarik@suse.cz> wrote:

> The remap_init() function lacks a return statement when all goes well.
> 
> Signed-off-by: Petr Tesarik <ptesarik@suse.cz>

Thank you for your work.
I will merge this patch into v1.5.1.


Thanks
Atsushi Kumagai

> ---
>  arch/x86.c |    1 +
>  1 file changed, 1 insertion(+)
> 
> --- a/arch/x86.c
> +++ b/arch/x86.c
> @@ -64,6 +64,7 @@ remap_init(void)
>  	}
>  
>  	max_numnodes = n;
> +	return TRUE;
>  }
>  
>  int
> 
> 
> 
> _______________________________________________
> kexec mailing list
> kexec@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/kexec

_______________________________________________
kexec mailing list
kexec@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/kexec

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2012-08-30  7:38 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-08-28 15:16 [PATCH] makedumpfile: add a missing return statement Petr Tesarik
2012-08-30  6:32 ` Atsushi Kumagai

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.