From: Mark Brown <broonie@opensource.wolfsonmicro.com>
To: Janusz Krzysztofik <jkrzyszt@tis.icnet.pl>
Cc: alsa-devel@alsa-project.org, linux-omap@vger.kernel.org,
Liam Girdwood <lrg@ti.com>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] ASoC: ams-delta: fix card initalization failure
Date: Tue, 28 Aug 2012 11:13:39 -0700 [thread overview]
Message-ID: <20120828181338.GB8796@opensource.wolfsonmicro.com> (raw)
In-Reply-To: <3048168.EXxi4fR4e7@acer>
On Tue, Aug 28, 2012 at 05:13:05PM +0200, Janusz Krzysztofik wrote:
> On Mon, 27 Aug 2012 14:38:35 Mark Brown wrote:
> > On Mon, Aug 27, 2012 at 11:28:30PM +0200, Janusz Krzysztofik wrote:
> > > - platform_set_drvdata(ams_delta_audio_platform_device,
> > > - &ams_delta_audio_card);
> > The real fix here is that you should be using platform data here, not
> > driver data. Is there some reason not to do that?
> Do you think the change you propose is suitable for the rc cycle? I'm
> trying to fix a regression in the first place. Converting the ams-delta
> asoc to a platform driver is on my todo list and I'm going to take care
> of this as soon as I have enough spare time.
The above looks like you already have a platform driver? All I'm
suggesting is changing the above to use platform rather than driver
data.
WARNING: multiple messages have this Message-ID (diff)
From: Mark Brown <broonie@opensource.wolfsonmicro.com>
To: Janusz Krzysztofik <jkrzyszt@tis.icnet.pl>
Cc: alsa-devel@alsa-project.org, linux-omap@vger.kernel.org,
Liam Girdwood <lrg@ti.com>,
linux-kernel@vger.kernel.org
Subject: Re: [alsa-devel] [PATCH] ASoC: ams-delta: fix card initalization failure
Date: Tue, 28 Aug 2012 11:13:39 -0700 [thread overview]
Message-ID: <20120828181338.GB8796@opensource.wolfsonmicro.com> (raw)
In-Reply-To: <3048168.EXxi4fR4e7@acer>
On Tue, Aug 28, 2012 at 05:13:05PM +0200, Janusz Krzysztofik wrote:
> On Mon, 27 Aug 2012 14:38:35 Mark Brown wrote:
> > On Mon, Aug 27, 2012 at 11:28:30PM +0200, Janusz Krzysztofik wrote:
> > > - platform_set_drvdata(ams_delta_audio_platform_device,
> > > - &ams_delta_audio_card);
> > The real fix here is that you should be using platform data here, not
> > driver data. Is there some reason not to do that?
> Do you think the change you propose is suitable for the rc cycle? I'm
> trying to fix a regression in the first place. Converting the ams-delta
> asoc to a platform driver is on my todo list and I'm going to take care
> of this as soon as I have enough spare time.
The above looks like you already have a platform driver? All I'm
suggesting is changing the above to use platform rather than driver
data.
next prev parent reply other threads:[~2012-08-28 18:13 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-08-27 21:28 [PATCH] ASoC: ams-delta: fix card initalization failure Janusz Krzysztofik
2012-08-27 21:28 ` Janusz Krzysztofik
2012-08-27 21:38 ` Mark Brown
2012-08-27 21:38 ` Mark Brown
2012-08-28 15:13 ` Janusz Krzysztofik
2012-08-28 15:13 ` [alsa-devel] " Janusz Krzysztofik
2012-08-28 18:13 ` Mark Brown [this message]
2012-08-28 18:13 ` Mark Brown
2012-08-29 5:04 ` Janusz Krzysztofik
2012-08-31 21:31 ` Mark Brown
2012-08-31 21:31 ` [alsa-devel] " Mark Brown
2012-09-01 9:09 ` Janusz Krzysztofik
2012-09-01 9:09 ` [alsa-devel] " Janusz Krzysztofik
2012-09-06 7:36 ` Mark Brown
2012-09-16 19:17 ` [PATCH] ASoC: ams-delta: Convert to use snd_soc_register_card() Janusz Krzysztofik
2012-09-16 19:17 ` Janusz Krzysztofik
2012-09-16 20:44 ` Tony Lindgren
2012-09-16 20:44 ` Tony Lindgren
2012-10-02 21:07 ` Janusz Krzysztofik
2012-10-02 21:07 ` Janusz Krzysztofik
2012-10-03 10:38 ` Mark Brown
2012-10-03 10:38 ` Mark Brown
2012-10-03 10:46 ` [RESEND][PATCH] " Janusz Krzysztofik
2012-10-03 10:46 ` Janusz Krzysztofik
2012-10-03 13:51 ` Janusz Krzysztofik
2012-10-03 13:51 ` Janusz Krzysztofik
2012-10-04 17:50 ` Mark Brown
2012-10-04 17:50 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120828181338.GB8796@opensource.wolfsonmicro.com \
--to=broonie@opensource.wolfsonmicro.com \
--cc=alsa-devel@alsa-project.org \
--cc=jkrzyszt@tis.icnet.pl \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=lrg@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.