From: Pablo Neira Ayuso <pablo@netfilter.org>
To: Julia Lawall <Julia.Lawall@lip6.fr>
Cc: kernel-janitors@vger.kernel.org,
Patrick McHardy <kaber@trash.net>,
"David S. Miller" <davem@davemloft.net>,
netfilter-devel@vger.kernel.org, netfilter@vger.kernel.org,
coreteam@netfilter.org, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 6/7] net/netfilter/nfnetlink_log.c: fix error return code
Date: Thu, 30 Aug 2012 01:35:33 +0000 [thread overview]
Message-ID: <20120830013533.GE8878@1984> (raw)
In-Reply-To: <1346258957-7649-8-git-send-email-Julia.Lawall@lip6.fr>
On Wed, Aug 29, 2012 at 06:49:17PM +0200, Julia Lawall wrote:
> From: Julia Lawall <Julia.Lawall@lip6.fr>
>
> Initialize return variable before exiting on an error path.
>
> A simplified version of the semantic match that finds this problem is as
> follows: (http://coccinelle.lip6.fr/)
>
> // <smpl>
> (
> if@p1 (\(ret < 0\|ret != 0\))
> { ... return ret; }
> |
> ret@p1 = 0
> )
> ... when != ret = e1
> when != &ret
> *if(...)
> {
> ... when != ret = e2
> when forall
> return ret;
> }
>
> // </smpl>
And also applied, thanks Julia. I'll pass these to current -rc.
WARNING: multiple messages have this Message-ID (diff)
From: Pablo Neira Ayuso <pablo@netfilter.org>
To: Julia Lawall <Julia.Lawall@lip6.fr>
Cc: kernel-janitors@vger.kernel.org,
Patrick McHardy <kaber@trash.net>,
"David S. Miller" <davem@davemloft.net>,
netfilter-devel@vger.kernel.org, netfilter@vger.kernel.org,
coreteam@netfilter.org, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 6/7] net/netfilter/nfnetlink_log.c: fix error return code
Date: Thu, 30 Aug 2012 03:35:33 +0200 [thread overview]
Message-ID: <20120830013533.GE8878@1984> (raw)
In-Reply-To: <1346258957-7649-8-git-send-email-Julia.Lawall@lip6.fr>
On Wed, Aug 29, 2012 at 06:49:17PM +0200, Julia Lawall wrote:
> From: Julia Lawall <Julia.Lawall@lip6.fr>
>
> Initialize return variable before exiting on an error path.
>
> A simplified version of the semantic match that finds this problem is as
> follows: (http://coccinelle.lip6.fr/)
>
> // <smpl>
> (
> if@p1 (\(ret < 0\|ret != 0\))
> { ... return ret; }
> |
> ret@p1 = 0
> )
> ... when != ret = e1
> when != &ret
> *if(...)
> {
> ... when != ret = e2
> when forall
> return ret;
> }
>
> // </smpl>
And also applied, thanks Julia. I'll pass these to current -rc.
next prev parent reply other threads:[~2012-08-30 1:35 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-08-29 16:49 [PATCH 0/7] fix error return code Julia Lawall
2012-08-29 16:49 ` Julia Lawall
2012-08-29 16:49 ` [PATCH 1/7] ipvs: " Julia Lawall
2012-08-29 16:49 ` Julia Lawall
2012-08-30 1:12 ` Simon Horman
2012-08-30 1:12 ` Simon Horman
2012-08-30 1:34 ` Pablo Neira Ayuso
2012-08-30 1:34 ` Pablo Neira Ayuso
2012-08-29 16:49 ` [PATCH 2/7] net: ipv6: " Julia Lawall
2012-08-29 16:49 ` Julia Lawall
2012-08-31 20:28 ` David Miller
2012-08-31 20:28 ` David Miller
2012-08-29 16:49 ` [PATCH 3/7] logfs: " Julia Lawall
2012-08-29 16:49 ` Julia Lawall
2012-08-29 16:49 ` [PATCH 4/7] net/bluetooth/rfcomm/core.c: " Julia Lawall
2012-08-29 16:49 ` Julia Lawall
2012-08-29 16:49 ` Julia Lawall
2012-08-29 18:23 ` Marcel Holtmann
2012-08-29 18:23 ` Marcel Holtmann
2012-08-29 18:23 ` Marcel Holtmann
2012-08-29 16:49 ` [PATCH 5/7] net/xfrm/xfrm_state.c: " Julia Lawall
2012-08-29 16:49 ` Julia Lawall
2012-08-31 20:28 ` David Miller
2012-08-31 20:28 ` David Miller
2012-08-29 16:49 ` [PATCH 7/7] net/netfilter/nf_conntrack_netlink.c: " Julia Lawall
2012-08-29 16:49 ` Julia Lawall
2012-08-30 1:35 ` Pablo Neira Ayuso
2012-08-30 1:35 ` Pablo Neira Ayuso
2012-08-29 16:49 ` [PATCH 6/7] net/netfilter/nfnetlink_log.c: " Julia Lawall
2012-08-29 16:49 ` Julia Lawall
2012-08-30 1:35 ` Pablo Neira Ayuso [this message]
2012-08-30 1:35 ` Pablo Neira Ayuso
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120830013533.GE8878@1984 \
--to=pablo@netfilter.org \
--cc=Julia.Lawall@lip6.fr \
--cc=coreteam@netfilter.org \
--cc=davem@davemloft.net \
--cc=kaber@trash.net \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=netfilter-devel@vger.kernel.org \
--cc=netfilter@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.