From: Cyrill Gorcunov <gorcunov@openvz.org>
To: Sasha Levin <levinsasha928@gmail.com>
Cc: penberg@kernel.org, asias.hejun@gmail.com, mingo@elte.hu,
kvm@vger.kernel.org
Subject: Re: [PATCH 1/7] kvm tools: add HOME env var to hostfs
Date: Thu, 30 Aug 2012 11:50:35 +0400 [thread overview]
Message-ID: <20120830075035.GD21422@moon> (raw)
In-Reply-To: <1346312203-29456-1-git-send-email-levinsasha928@gmail.com>
On Thu, Aug 30, 2012 at 09:36:37AM +0200, Sasha Levin wrote:
> + char *new_env[] = { "TERM=linux", "DISPLAY=192.168.33.1:0",
> + "HOME=/virt/home", NULL };
> +
> + mkdir("/virt/home", 0755);
Please add check for mkdir error code. Frankly, this is a bad habbit
to assume that mkdir never fails (this could be done on top of this
series I think but should not be leaved without attention).
Cyrill
next prev parent reply other threads:[~2012-08-30 7:50 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-08-30 7:36 [PATCH 1/7] kvm tools: add HOME env var to hostfs Sasha Levin
2012-08-30 7:36 ` [PATCH 2/7] kvm tools: clean garbage from ioeventfd code Sasha Levin
2012-08-30 7:36 ` [PATCH 3/7] kvm tools: Use the new KVM_SIGNAL_MSI ioctl to inject interrupts directly Sasha Levin
2012-08-30 7:36 ` [PATCH 4/7] kvm tools: fix warnings in virtio-blk Sasha Levin
2012-08-30 7:36 ` [PATCH 5/7] kvm tools: enable LTO Sasha Levin
2012-08-30 8:01 ` Pekka Enberg
2012-08-30 8:16 ` Ingo Molnar
2012-08-30 8:22 ` Cyrill Gorcunov
2012-08-30 8:33 ` Sasha Levin
2012-08-30 8:35 ` Cyrill Gorcunov
2012-08-30 9:12 ` Pekka Enberg
2012-08-30 7:36 ` [PATCH 6/7] kvm tools: 9p don't nuke fids on attach Sasha Levin
2012-08-30 7:36 ` [PATCH 7/7] kvm tools: simplify virtio config handling Sasha Levin
2012-08-30 7:50 ` Cyrill Gorcunov [this message]
2012-08-30 9:44 ` [PATCH 1/7] kvm tools: add HOME env var to hostfs Sasha Levin
2012-08-30 9:48 ` Pekka Enberg
2012-08-30 9:51 ` Sasha Levin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120830075035.GD21422@moon \
--to=gorcunov@openvz.org \
--cc=asias.hejun@gmail.com \
--cc=kvm@vger.kernel.org \
--cc=levinsasha928@gmail.com \
--cc=mingo@elte.hu \
--cc=penberg@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.