Re: [PATCH 1/7] kvm tools: add HOME env var to hostfs

[Sasha Levin <levinsasha928@gmail.com>]

On 08/30/2012 11:48 AM, Pekka Enberg wrote:
> On Thu, Aug 30, 2012 at 12:44 PM, Sasha Levin <levinsasha928@gmail.com> wrote:
>> On 08/30/2012 09:50 AM, Cyrill Gorcunov wrote:
>>> On Thu, Aug 30, 2012 at 09:36:37AM +0200, Sasha Levin wrote:
>>>> +    char *new_env[] = { "TERM=linux", "DISPLAY=192.168.33.1:0",
>>>> +                            "HOME=/virt/home", NULL };
>>>> +
>>>> +    mkdir("/virt/home", 0755);
>>>
>>> Please add check for mkdir error code. Frankly, this is a bad habbit
>>> to assume that mkdir never fails (this could be done on top of this
>>> series I think but should not be leaved without attention).
>>
>> This is actually supposed to fail most of the times, since it runs as part of
>> the init :)
> 
> You could check for errno == EEXISTS, no?
> 
> On Thu, Aug 30, 2012 at 12:44 PM, Sasha Levin <levinsasha928@gmail.com> wrote:
>> There's not much we can do if it fails though, and even at that point - this
>> failure isn't serious enough to even justify any further action on our end.
> 
> I'm pretty sure users would appreciate a friendly warning explaining
> that we are not running in "normal state".

This is how we ran up until now :)

I'm going to move that from init.c into the setup itself then.