From: Ralf Baechle <ralf@linux-mips.org>
To: Jim Quinlan <jim2101024@gmail.com>
Cc: David Daney <ddaney.cavm@gmail.com>, linux-mips@linux-mips.org
Subject: Re: [PATCH V2 1/2] asm-offsets.c: adding #define to break circular dependency
Date: Thu, 30 Aug 2012 16:15:25 +0200 [thread overview]
Message-ID: <20120830141525.GD23288@linux-mips.org> (raw)
In-Reply-To: <CANCKTBsXhKNtNJxYhyn4Ygt=c3=4ZT-quB3L1XJVFC4y-mWM7Q@mail.gmail.com>
On Thu, Aug 30, 2012 at 10:06:30AM -0400, Jim Quinlan wrote:
> I'm not sure the tangle is so easily undone. The first dependency I see is
>
> asm-offsets.c
> asm/processors.h
> linux/cpumask.h
> linux/kernel.h
> linux/bitops.h
> asm/bitops.h
> linux/irqflags.h
> asm/irqflags.h
>
> When compared to other architectures, the MIPS asm/bitops.h seems to
> include more files at the top, including linux/irqflags.h.
> Any suggestions?
This is because MIPS bitops for some ancient processors which don't have
atomic operations and Cavium cnMIPS cores where disabling interrupts is
faster than the atomic operations are implemented by disabling interrupts.
This makes these atomic operations relativly bloated in terms of code size
generated and may it'd be a good idea to outline the bits. With a bit
of luck we even get better cache locality - and fewer header file
inclusions.
Ralf
next prev parent reply other threads:[~2012-08-30 14:15 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-08-29 22:34 [PATCH V2 1/2] asm-offsets.c: adding #define to break circular dependency Jim Quinlan
2012-08-29 22:34 ` [PATCH V2 2/2] MIPS: irqflags.h: make funcs preempt-safe for non-mipsr2 Jim Quinlan
2012-08-30 16:41 ` David Daney
2012-08-29 23:01 ` [PATCH V2 1/2] asm-offsets.c: adding #define to break circular dependency David Daney
2012-08-30 14:06 ` Jim Quinlan
2012-08-30 14:15 ` Ralf Baechle [this message]
2012-08-30 20:35 ` Jim Quinlan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120830141525.GD23288@linux-mips.org \
--to=ralf@linux-mips.org \
--cc=ddaney.cavm@gmail.com \
--cc=jim2101024@gmail.com \
--cc=linux-mips@linux-mips.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.