Re: [PATCH V2 1/2] asm-offsets.c: adding #define to break circular dependency

[David Daney <ddaney.cavm@gmail.com>]

On 08/29/2012 03:34 PM, Jim Quinlan wrote:
> irqflags.h depends on asm-offsets.h, but asm-offsets.h depends
> on irqflags.h when generating asm-offsets.h.

What is there in irqflags.h that is required by asm-offsets.c?

Why can't the include tangle be undone so that that part can be factored 
out to a separate file?



> Adding a definition
> to the top of asm-offsets.c allows us to break this circle.  There
> is a similar define in bounds.c
>
> Signed-off-by: Jim Quinlan <jim2101024@gmail.com>
> ---
>   arch/mips/kernel/asm-offsets.c |    1 +
>   1 files changed, 1 insertions(+), 0 deletions(-)
>
> diff --git a/arch/mips/kernel/asm-offsets.c b/arch/mips/kernel/asm-offsets.c
> index 6b30fb2..035f167 100644
> --- a/arch/mips/kernel/asm-offsets.c
> +++ b/arch/mips/kernel/asm-offsets.c
> @@ -8,6 +8,7 @@
>    * Kevin Kissell, kevink@mips.com and Carsten Langgaard, carstenl@mips.com
>    * Copyright (C) 2000 MIPS Technologies, Inc.
>    */
> +#define __GENERATING_OFFSETS_S
>   #include <linux/compat.h>
>   #include <linux/types.h>
>   #include <linux/sched.h>
>