All of lore.kernel.org
 help / color / mirror / Atom feed
From: Andrew Morton <akpm@linux-foundation.org>
To: Guenter Roeck <linux@roeck-us.net>
Cc: linux-kernel@vger.kernel.org, Pekka Enberg <penberg@kernel.org>,
	Ingo Molnar <mingo@kernel.org>, "H. Peter Anvin" <hpa@zytor.com>,
	Jean Delvare <khali@linux-fr.org>,
	lm-sensors@lm-sensors.org
Subject: Re: [lm-sensors] [PATCH v3] linux/kernel.h: Fix DIV_ROUND_CLOSEST to support negative operands
Date: Fri, 31 Aug 2012 00:35:31 +0000	[thread overview]
Message-ID: <20120830173531.291e7b6d.akpm@linux-foundation.org> (raw)
In-Reply-To: <1346371847-21384-1-git-send-email-linux@roeck-us.net>

On Thu, 30 Aug 2012 17:10:47 -0700 Guenter Roeck <linux@roeck-us.net> wrote:

> DIV_ROUND_CLOSEST returns a bad result for dividends with different sign:
> 	DIV_ROUND_CLOSEST(-2, 2) = 0
> 
> Most of the time this does not matter. However, in the hardware monitoring
> subsystem, DIV_ROUND_CLOSEST is sometimes used on integers which can be
> negative (such as temperatures).
> 
> ...
>
> --- a/include/linux/kernel.h
> +++ b/include/linux/kernel.h
> @@ -84,8 +84,11 @@
>  )
>  #define DIV_ROUND_CLOSEST(x, divisor)(			\
>  {							\
> -	typeof(divisor) __divisor = divisor;		\
> -	(((x) + ((__divisor) / 2)) / (__divisor));	\
> +	typeof(x) __x = x;				\
> +	typeof(divisor) __d = divisor;			\
> +	((__x) < 0) = ((__d) < 0) ?			\
> +		(((__x) + ((__d) / 2)) / (__d)) :	\
> +		(((__x) - ((__d) / 2)) / (__d));	\
>  }							\
>  )

Your v2 had that sneaky little "(typeof(x))-1 >= 0" trick in it, so
half the code gets elided at compile time if `x' (why isn't this called
"dividend") has an unsigned type.

Would retaining that be of any benefit?  We do want to avoid doing the
compare-and-branch in as many cases as possible.

Also, this would be a great opportunity to document the macro's beahviour
(I do go on).  That would be a useful thing to do, given that we're now
handling the four +/+, +/-, -/+, -/- cases and the behaviour for each
case isn't terribly obvious.

_______________________________________________
lm-sensors mailing list
lm-sensors@lm-sensors.org
http://lists.lm-sensors.org/mailman/listinfo/lm-sensors

WARNING: multiple messages have this Message-ID (diff)
From: Andrew Morton <akpm@linux-foundation.org>
To: Guenter Roeck <linux@roeck-us.net>
Cc: linux-kernel@vger.kernel.org, Pekka Enberg <penberg@kernel.org>,
	Ingo Molnar <mingo@kernel.org>, "H. Peter Anvin" <hpa@zytor.com>,
	Jean Delvare <khali@linux-fr.org>,
	lm-sensors@lm-sensors.org
Subject: Re: [PATCH v3] linux/kernel.h: Fix DIV_ROUND_CLOSEST to support negative operands
Date: Thu, 30 Aug 2012 17:35:31 -0700	[thread overview]
Message-ID: <20120830173531.291e7b6d.akpm@linux-foundation.org> (raw)
In-Reply-To: <1346371847-21384-1-git-send-email-linux@roeck-us.net>

On Thu, 30 Aug 2012 17:10:47 -0700 Guenter Roeck <linux@roeck-us.net> wrote:

> DIV_ROUND_CLOSEST returns a bad result for dividends with different sign:
> 	DIV_ROUND_CLOSEST(-2, 2) = 0
> 
> Most of the time this does not matter. However, in the hardware monitoring
> subsystem, DIV_ROUND_CLOSEST is sometimes used on integers which can be
> negative (such as temperatures).
> 
> ...
>
> --- a/include/linux/kernel.h
> +++ b/include/linux/kernel.h
> @@ -84,8 +84,11 @@
>  )
>  #define DIV_ROUND_CLOSEST(x, divisor)(			\
>  {							\
> -	typeof(divisor) __divisor = divisor;		\
> -	(((x) + ((__divisor) / 2)) / (__divisor));	\
> +	typeof(x) __x = x;				\
> +	typeof(divisor) __d = divisor;			\
> +	((__x) < 0) == ((__d) < 0) ?			\
> +		(((__x) + ((__d) / 2)) / (__d)) :	\
> +		(((__x) - ((__d) / 2)) / (__d));	\
>  }							\
>  )

Your v2 had that sneaky little "(typeof(x))-1 >= 0" trick in it, so
half the code gets elided at compile time if `x' (why isn't this called
"dividend") has an unsigned type.

Would retaining that be of any benefit?  We do want to avoid doing the
compare-and-branch in as many cases as possible.

Also, this would be a great opportunity to document the macro's beahviour
(I do go on).  That would be a useful thing to do, given that we're now
handling the four +/+, +/-, -/+, -/- cases and the behaviour for each
case isn't terribly obvious.

  reply	other threads:[~2012-08-31  0:35 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-08-31  0:10 [lm-sensors] [PATCH v3] linux/kernel.h: Fix DIV_ROUND_CLOSEST to support negative operands Guenter Roeck
2012-08-31  0:10 ` Guenter Roeck
2012-08-31  0:35 ` Andrew Morton [this message]
2012-08-31  0:35   ` Andrew Morton
2012-08-31  1:12   ` [lm-sensors] " Guenter Roeck
2012-08-31  1:12     ` Guenter Roeck

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20120830173531.291e7b6d.akpm@linux-foundation.org \
    --to=akpm@linux-foundation.org \
    --cc=hpa@zytor.com \
    --cc=khali@linux-fr.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux@roeck-us.net \
    --cc=lm-sensors@lm-sensors.org \
    --cc=mingo@kernel.org \
    --cc=penberg@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.