From: Mark Brown <broonie@opensource.wolfsonmicro.com>
To: Dylan Reid <dgreid@chromium.org>
Cc: alsa-devel@alsa-project.org, kgene.kim@samsung.com,
ben-linux@fluff.org, padma.v@samsung.com, clemens@ladisch.de,
alim.akhtar@samsung.com, linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH] ASoC: samsung dma - Don't indicate support for pause/resume.
Date: Fri, 31 Aug 2012 10:41:36 -0700 [thread overview]
Message-ID: <20120831174135.GF25575@opensource.wolfsonmicro.com> (raw)
In-Reply-To: <1346387854-22222-1-git-send-email-dgreid@chromium.org>
On Thu, Aug 30, 2012 at 09:37:34PM -0700, Dylan Reid wrote:
> index f3ebc38..56a507a 100644
> --- a/sound/soc/samsung/dma.c
> +++ b/sound/soc/samsung/dma.c
> @@ -34,9 +34,7 @@ static const struct snd_pcm_hardware dma_hardware = {
> .info = SNDRV_PCM_INFO_INTERLEAVED |
> SNDRV_PCM_INFO_BLOCK_TRANSFER |
> SNDRV_PCM_INFO_MMAP |
> - SNDRV_PCM_INFO_MMAP_VALID |
> - SNDRV_PCM_INFO_PAUSE |
> - SNDRV_PCM_INFO_RESUME,
> + SNDRV_PCM_INFO_MMAP_VALID,
I'd expect to also see an update to the trigger function to not accept
the suspend and resume triggers?
WARNING: multiple messages have this Message-ID (diff)
From: broonie@opensource.wolfsonmicro.com (Mark Brown)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] ASoC: samsung dma - Don't indicate support for pause/resume.
Date: Fri, 31 Aug 2012 10:41:36 -0700 [thread overview]
Message-ID: <20120831174135.GF25575@opensource.wolfsonmicro.com> (raw)
In-Reply-To: <1346387854-22222-1-git-send-email-dgreid@chromium.org>
On Thu, Aug 30, 2012 at 09:37:34PM -0700, Dylan Reid wrote:
> index f3ebc38..56a507a 100644
> --- a/sound/soc/samsung/dma.c
> +++ b/sound/soc/samsung/dma.c
> @@ -34,9 +34,7 @@ static const struct snd_pcm_hardware dma_hardware = {
> .info = SNDRV_PCM_INFO_INTERLEAVED |
> SNDRV_PCM_INFO_BLOCK_TRANSFER |
> SNDRV_PCM_INFO_MMAP |
> - SNDRV_PCM_INFO_MMAP_VALID |
> - SNDRV_PCM_INFO_PAUSE |
> - SNDRV_PCM_INFO_RESUME,
> + SNDRV_PCM_INFO_MMAP_VALID,
I'd expect to also see an update to the trigger function to not accept
the suspend and resume triggers?
next prev parent reply other threads:[~2012-08-31 17:41 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-08-31 4:37 [PATCH] ASoC: samsung dma - Don't indicate support for pause/resume Dylan Reid
2012-08-31 4:37 ` Dylan Reid
2012-08-31 17:41 ` Mark Brown [this message]
2012-08-31 17:41 ` Mark Brown
2012-09-01 8:31 ` Dylan Reid
2012-09-01 8:31 ` Dylan Reid
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120831174135.GF25575@opensource.wolfsonmicro.com \
--to=broonie@opensource.wolfsonmicro.com \
--cc=alim.akhtar@samsung.com \
--cc=alsa-devel@alsa-project.org \
--cc=ben-linux@fluff.org \
--cc=clemens@ladisch.de \
--cc=dgreid@chromium.org \
--cc=kgene.kim@samsung.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=padma.v@samsung.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.