All of lore.kernel.org
 help / color / mirror / Atom feed
From: Mark Brown <broonie@opensource.wolfsonmicro.com>
To: Prasad Joshi <prasadjoshi.linux@gmail.com>
Cc: alsa-devel@alsa-project.org, rajeev-dlh.kumar@st.com,
	tiwai@suse.de, linux-kernel@vger.kernel.org, lrg@ti.com
Subject: Re: [PATCH] ASoC: correct the check for NULL dma_buffer pointer
Date: Fri, 31 Aug 2012 14:24:36 -0700	[thread overview]
Message-ID: <20120831212435.GB5495@opensource.wolfsonmicro.com> (raw)
In-Reply-To: <1346383521-2990-1-git-send-email-prasadjoshi.linux@gmail.com>

On Fri, Aug 31, 2012 at 08:55:21AM +0530, Prasad Joshi wrote:
> The if condition
> 	if (!buf && !buf->area)
> 
> checks if the buf pointer is NULL and then dereferences it again to
> check if the buffer area is NULL, resulting in possible NULL
> dereference.

Applied, thanks.

WARNING: multiple messages have this Message-ID (diff)
From: Mark Brown <broonie@opensource.wolfsonmicro.com>
To: Prasad Joshi <prasadjoshi.linux@gmail.com>
Cc: lrg@ti.com, perex@perex.cz, tiwai@suse.de,
	rajeev-dlh.kumar@st.com, alsa-devel@alsa-project.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH] ASoC: correct the check for NULL dma_buffer pointer
Date: Fri, 31 Aug 2012 14:24:36 -0700	[thread overview]
Message-ID: <20120831212435.GB5495@opensource.wolfsonmicro.com> (raw)
In-Reply-To: <1346383521-2990-1-git-send-email-prasadjoshi.linux@gmail.com>

On Fri, Aug 31, 2012 at 08:55:21AM +0530, Prasad Joshi wrote:
> The if condition
> 	if (!buf && !buf->area)
> 
> checks if the buf pointer is NULL and then dereferences it again to
> check if the buffer area is NULL, resulting in possible NULL
> dereference.

Applied, thanks.

  reply	other threads:[~2012-08-31 21:24 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-08-31  3:25 [PATCH] ASoC: correct the check for NULL dma_buffer pointer Prasad Joshi
2012-08-31 21:24 ` Mark Brown [this message]
2012-08-31 21:24   ` Mark Brown

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20120831212435.GB5495@opensource.wolfsonmicro.com \
    --to=broonie@opensource.wolfsonmicro.com \
    --cc=alsa-devel@alsa-project.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=lrg@ti.com \
    --cc=prasadjoshi.linux@gmail.com \
    --cc=rajeev-dlh.kumar@st.com \
    --cc=tiwai@suse.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.