From: b29396@freescale.com (Dong Aisheng)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v5 3/4] regulator: anatop-regulator: convert to use syscon to access anatop register
Date: Tue, 4 Sep 2012 19:27:04 +0800 [thread overview]
Message-ID: <20120904112703.GA13046@shlinux2.ap.freescale.net> (raw)
In-Reply-To: <20120904113429.GK2362@S2101-09.ap.freescale.net>
On Tue, Sep 04, 2012 at 07:34:32PM +0800, Shawn Guo wrote:
> On Tue, Sep 04, 2012 at 11:20:10AM +0800, Dong Aisheng wrote:
> > +
> > + anatop_np = of_get_parent(np);
> > + if (!anatop_np)
> > + return -ENODEV;
> > + sreg->anatop = syscon_node_to_regmap(anatop_np);
> > + if (IS_ERR(sreg->anatop))
> > + return PTR_ERR(sreg->anatop);
> > +
> With of_node_put moved out from syscon_node_to_regmap, shouldn't
> we put anatop_np here then?
>
When i sent it out, i found i missed it...
Should be more care...
Regards
Dong Aisheng
WARNING: multiple messages have this Message-ID (diff)
From: Dong Aisheng <b29396@freescale.com>
To: Shawn Guo <shawn.guo@linaro.org>
Cc: "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
"linus.walleij@stericsson.com" <linus.walleij@stericsson.com>,
"s.hauer@pengutronix.de" <s.hauer@pengutronix.de>,
"kernel@pengutronix.de" <kernel@pengutronix.de>,
"grant.likely@secretlab.ca" <grant.likely@secretlab.ca>,
"rob.herring@calxeda.com" <rob.herring@calxeda.com>,
"sameo@linux.intel.com" <sameo@linux.intel.com>,
"lrg@ti.com" <lrg@ti.com>,
"broonie@opensource.wolfsonmicro.com"
<broonie@opensource.wolfsonmicro.com>,
Zhao Richard-B20223 <B20223@freescale.com>,
"devicetree-discuss@lists.ozlabs.org"
<devicetree-discuss@lists.ozlabs.org>,
"swarren@wwwdotorg.org" <swarren@wwwdotorg.org>
Subject: Re: [PATCH v5 3/4] regulator: anatop-regulator: convert to use syscon to access anatop register
Date: Tue, 4 Sep 2012 19:27:04 +0800 [thread overview]
Message-ID: <20120904112703.GA13046@shlinux2.ap.freescale.net> (raw)
In-Reply-To: <20120904113429.GK2362@S2101-09.ap.freescale.net>
On Tue, Sep 04, 2012 at 07:34:32PM +0800, Shawn Guo wrote:
> On Tue, Sep 04, 2012 at 11:20:10AM +0800, Dong Aisheng wrote:
> > +
> > + anatop_np = of_get_parent(np);
> > + if (!anatop_np)
> > + return -ENODEV;
> > + sreg->anatop = syscon_node_to_regmap(anatop_np);
> > + if (IS_ERR(sreg->anatop))
> > + return PTR_ERR(sreg->anatop);
> > +
> With of_node_put moved out from syscon_node_to_regmap, shouldn't
> we put anatop_np here then?
>
When i sent it out, i found i missed it...
Should be more care...
Regards
Dong Aisheng
next prev parent reply other threads:[~2012-09-04 11:27 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-09-04 3:20 [PATCH v5 0/4] add syscon driver based on regmap for general registers access Dong Aisheng
2012-09-04 3:20 ` Dong Aisheng
2012-09-04 3:20 ` Dong Aisheng
2012-09-04 3:20 ` [PATCH v5 1/4] mfd: add syscon driver based on regmap Dong Aisheng
2012-09-04 3:20 ` Dong Aisheng
2012-09-04 3:20 ` Dong Aisheng
2012-09-04 11:35 ` Andi Shyti
2012-09-04 11:35 ` Andi Shyti
2012-09-04 11:46 ` Dong Aisheng
2012-09-04 11:46 ` Dong Aisheng
2012-09-04 15:44 ` Andi Shyti
2012-09-04 15:44 ` Andi Shyti
2012-09-04 12:16 ` Sergei Shtylyov
2012-09-04 12:16 ` Sergei Shtylyov
2012-09-04 3:20 ` [PATCH v5 2/4] ARM: imx6q: add iomuxc gpr support into syscon Dong Aisheng
2012-09-04 3:20 ` Dong Aisheng
2012-09-04 3:20 ` Dong Aisheng
2012-09-04 3:20 ` [PATCH v5 3/4] regulator: anatop-regulator: convert to use syscon to access anatop register Dong Aisheng
2012-09-04 3:20 ` Dong Aisheng
2012-09-04 3:20 ` Dong Aisheng
2012-09-04 11:34 ` Shawn Guo
2012-09-04 11:34 ` Shawn Guo
2012-09-04 11:27 ` Dong Aisheng [this message]
2012-09-04 11:27 ` Dong Aisheng
2012-09-04 3:20 ` [PATCH v5 4/4] mfd: anatop-mfd: remove anatop driver Dong Aisheng
2012-09-04 3:20 ` Dong Aisheng
2012-09-04 3:20 ` Dong Aisheng
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120904112703.GA13046@shlinux2.ap.freescale.net \
--to=b29396@freescale.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.