All of lore.kernel.org
 help / color / mirror / Atom feed
From: Kent Yoder <key@linux.vnet.ibm.com>
To: Dan Carpenter <dan.carpenter@oracle.com>
Cc: James Morris <jmorris@namei.org>,
	linux-kernel@vger.kernel.org,
	linux-security-module@vger.kernel.org,
	tpmdd-devel@lists.sourceforge.net,
	kernel-janitors@vger.kernel.org,
	Fengguang Wu <fengguang.wu@intel.com>
Subject: Re: [PATCH] tpm: fix tpm_acpi sparse warning on different address spaces
Date: Tue, 04 Sep 2012 16:13:30 +0000	[thread overview]
Message-ID: <20120904161330.GA20588@linux.vnet.ibm.com> (raw)
In-Reply-To: <20120902163030.GB1840@mwanda>

On Sun, Sep 02, 2012 at 09:30:30AM -0700, Dan Carpenter wrote:
> Sparse finds that bug as well.  ;)
> 
> drivers/acpi/acpica/tbfadt.c:247:15: warning: incorrect type in assignment (different address spaces)
> drivers/acpi/acpica/tbfadt.c:247:15:    expected struct acpi_table_header *table
> drivers/acpi/acpica/tbfadt.c:247:15:    got void [noderef] <asn:2>*
> drivers/acpi/acpica/tbfadt.c:266:30: warning: incorrect type in argument 1 (different address spaces)
> drivers/acpi/acpica/tbfadt.c:266:30:    expected void [noderef] <asn:2>*logical_address
> drivers/acpi/acpica/tbfadt.c:266:30:    got struct acpi_table_header *table
> 
> It should be memcpy_fromio() probably.

  Thanks Dan, that's clearly better. James, I'll resubmit this one
today.

Thanks,
Kent


WARNING: multiple messages have this Message-ID (diff)
From: Kent Yoder <key@linux.vnet.ibm.com>
To: Dan Carpenter <dan.carpenter@oracle.com>
Cc: James Morris <jmorris@namei.org>,
	linux-kernel@vger.kernel.org,
	linux-security-module@vger.kernel.org,
	tpmdd-devel@lists.sourceforge.net,
	kernel-janitors@vger.kernel.org,
	Fengguang Wu <fengguang.wu@intel.com>
Subject: Re: [PATCH] tpm: fix tpm_acpi sparse warning on different address spaces
Date: Tue, 4 Sep 2012 11:13:30 -0500	[thread overview]
Message-ID: <20120904161330.GA20588@linux.vnet.ibm.com> (raw)
In-Reply-To: <20120902163030.GB1840@mwanda>

On Sun, Sep 02, 2012 at 09:30:30AM -0700, Dan Carpenter wrote:
> Sparse finds that bug as well.  ;)
> 
> drivers/acpi/acpica/tbfadt.c:247:15: warning: incorrect type in assignment (different address spaces)
> drivers/acpi/acpica/tbfadt.c:247:15:    expected struct acpi_table_header *table
> drivers/acpi/acpica/tbfadt.c:247:15:    got void [noderef] <asn:2>*
> drivers/acpi/acpica/tbfadt.c:266:30: warning: incorrect type in argument 1 (different address spaces)
> drivers/acpi/acpica/tbfadt.c:266:30:    expected void [noderef] <asn:2>*logical_address
> drivers/acpi/acpica/tbfadt.c:266:30:    got struct acpi_table_header *table
> 
> It should be memcpy_fromio() probably.

  Thanks Dan, that's clearly better. James, I'll resubmit this one
today.

Thanks,
Kent


  reply	other threads:[~2012-09-04 16:13 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-08-30 14:38 [PATCH] tpm: fix tpm_acpi sparse warning on different address spaces Kent Yoder
2012-08-30 14:38 ` Kent Yoder
2012-08-30 17:45 ` Dan Carpenter
2012-08-30 17:45   ` Dan Carpenter
2012-08-30 19:21   ` Kent Yoder
2012-08-30 19:21     ` Kent Yoder
2012-09-02 16:30     ` Dan Carpenter
2012-09-02 16:30       ` Dan Carpenter
2012-09-04 16:13       ` Kent Yoder [this message]
2012-09-04 16:13         ` Kent Yoder
2012-09-04 16:18       ` Kent Yoder
2012-09-04 16:18         ` Kent Yoder
2012-09-12  3:12         ` James Morris
2012-09-12  3:12           ` James Morris

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20120904161330.GA20588@linux.vnet.ibm.com \
    --to=key@linux.vnet.ibm.com \
    --cc=dan.carpenter@oracle.com \
    --cc=fengguang.wu@intel.com \
    --cc=jmorris@namei.org \
    --cc=kernel-janitors@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-security-module@vger.kernel.org \
    --cc=tpmdd-devel@lists.sourceforge.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.