All of lore.kernel.org
 help / color / mirror / Atom feed
From: Dan Carpenter <dan.carpenter@oracle.com>
To: Dimitris Papastamos <dp@opensource.wolfsonmicro.com>
Cc: alsa-devel@alsa-project.org,
	Mark Brown <broonie@opensource.wolfsonmicro.com>,
	Takashi Iwai <tiwai@suse.de>,
	patches@opensource.wolfsonmicro.com,
	kernel-janitors@vger.kernel.org, Liam Girdwood <lrg@ti.com>
Subject: [patch] ASoC: wm0010: unlock on error path
Date: Wed, 5 Sep 2012 15:29:46 +0300	[thread overview]
Message-ID: <20120905122946.GA6128@elgon.mountain> (raw)

We're holding the wm0010->lock mutex when we goto err_core.

Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
---
This driver is only in linux-next.

diff --git a/sound/soc/codecs/wm0010.c b/sound/soc/codecs/wm0010.c
index 5f99148..1c052d6 100644
--- a/sound/soc/codecs/wm0010.c
+++ b/sound/soc/codecs/wm0010.c
@@ -663,7 +663,9 @@ abort:
 	wm0010_halt(codec);
 	mutex_unlock(&wm0010->lock);
 	return ret;
+
 err_core:
+	mutex_unlock(&wm0010->lock);
 	regulator_bulk_disable(ARRAY_SIZE(wm0010->core_supplies),
 			       wm0010->core_supplies);
 err:

WARNING: multiple messages have this Message-ID (diff)
From: Dan Carpenter <dan.carpenter@oracle.com>
To: Dimitris Papastamos <dp@opensource.wolfsonmicro.com>
Cc: alsa-devel@alsa-project.org,
	Mark Brown <broonie@opensource.wolfsonmicro.com>,
	Takashi Iwai <tiwai@suse.de>,
	patches@opensource.wolfsonmicro.com,
	kernel-janitors@vger.kernel.org, Liam Girdwood <lrg@ti.com>
Subject: [patch] ASoC: wm0010: unlock on error path
Date: Wed, 05 Sep 2012 12:29:46 +0000	[thread overview]
Message-ID: <20120905122946.GA6128@elgon.mountain> (raw)

We're holding the wm0010->lock mutex when we goto err_core.

Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
---
This driver is only in linux-next.

diff --git a/sound/soc/codecs/wm0010.c b/sound/soc/codecs/wm0010.c
index 5f99148..1c052d6 100644
--- a/sound/soc/codecs/wm0010.c
+++ b/sound/soc/codecs/wm0010.c
@@ -663,7 +663,9 @@ abort:
 	wm0010_halt(codec);
 	mutex_unlock(&wm0010->lock);
 	return ret;
+
 err_core:
+	mutex_unlock(&wm0010->lock);
 	regulator_bulk_disable(ARRAY_SIZE(wm0010->core_supplies),
 			       wm0010->core_supplies);
 err:

             reply	other threads:[~2012-09-05 12:30 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-09-05 12:29 Dan Carpenter [this message]
2012-09-05 12:29 ` [patch] ASoC: wm0010: unlock on error path Dan Carpenter
2012-09-05 12:37 ` Mark Brown
2012-09-05 12:37   ` Mark Brown

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20120905122946.GA6128@elgon.mountain \
    --to=dan.carpenter@oracle.com \
    --cc=alsa-devel@alsa-project.org \
    --cc=broonie@opensource.wolfsonmicro.com \
    --cc=dp@opensource.wolfsonmicro.com \
    --cc=kernel-janitors@vger.kernel.org \
    --cc=lrg@ti.com \
    --cc=patches@opensource.wolfsonmicro.com \
    --cc=tiwai@suse.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.