From: Tony Lindgren <tony@atomide.com>
To: Peter Ujfalusi <peter.ujfalusi@ti.com>
Cc: linux-arm-kernel@lists.infradead.org,
Grant Likely <grant.likely@secretlab.ca>,
Linus Walleij <linus.walleij@linaro.org>,
linux-omap@vger.kernel.org, Samuel Ortiz <sameo@linux.intel.com>
Subject: Re: [PATCH 5/9] ARM: OMAP2+: Remove hardcoded twl4030 gpio_base, irq_base and irq_end
Date: Wed, 5 Sep 2012 09:54:45 -0700 [thread overview]
Message-ID: <20120905165445.GD1303@atomide.com> (raw)
In-Reply-To: <50474FC0.6010805@ti.com>
* Peter Ujfalusi <peter.ujfalusi@ti.com> [120905 06:12]:
> Hi Tony,
>
> On 09/01/2012 02:52 AM, Tony Lindgren wrote:
> >
> > ..but irq_base here is still in use as that's where the value from
> > irq_alloc_descs() is being stored to. So I'll drop the changes to
> > struct twl6040 from this patch as otherwise twl6040 code won't compile.
> >
> > Turns out I did not have twl6040 selected in any of the testconfigs
> > that I ran.
>
> I store the irq_base in a private data for the MFD driver so child drivers can
> request the correct IRQ.
>
> You can safely remove the irq_base from twl6040_platform_data struct
Can you please do a patch for that against testing-cleanup branch? That
way we'll know that the twl changes get tested for audio ;)
Maybe also check if Felipe's earlier patch also has something else that
can be removed? That's the "[PATCH] arm: omap: drop unused IRQ defines":
http://lists.infradead.org/pipermail/linux-arm-kernel/2012-June/103274.html#
Regards,
Tony
WARNING: multiple messages have this Message-ID (diff)
From: tony@atomide.com (Tony Lindgren)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 5/9] ARM: OMAP2+: Remove hardcoded twl4030 gpio_base, irq_base and irq_end
Date: Wed, 5 Sep 2012 09:54:45 -0700 [thread overview]
Message-ID: <20120905165445.GD1303@atomide.com> (raw)
In-Reply-To: <50474FC0.6010805@ti.com>
* Peter Ujfalusi <peter.ujfalusi@ti.com> [120905 06:12]:
> Hi Tony,
>
> On 09/01/2012 02:52 AM, Tony Lindgren wrote:
> >
> > ..but irq_base here is still in use as that's where the value from
> > irq_alloc_descs() is being stored to. So I'll drop the changes to
> > struct twl6040 from this patch as otherwise twl6040 code won't compile.
> >
> > Turns out I did not have twl6040 selected in any of the testconfigs
> > that I ran.
>
> I store the irq_base in a private data for the MFD driver so child drivers can
> request the correct IRQ.
>
> You can safely remove the irq_base from twl6040_platform_data struct
Can you please do a patch for that against testing-cleanup branch? That
way we'll know that the twl changes get tested for audio ;)
Maybe also check if Felipe's earlier patch also has something else that
can be removed? That's the "[PATCH] arm: omap: drop unused IRQ defines":
http://lists.infradead.org/pipermail/linux-arm-kernel/2012-June/103274.html#
Regards,
Tony
next prev parent reply other threads:[~2012-09-05 16:54 UTC|newest]
Thread overview: 54+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-08-31 0:52 [PATCH 0/9] Clean up hardcoded IRQs for mach-omap2, enable SPARSE_IRQ, plaform_data/gpio-omap.h Tony Lindgren
2012-08-31 0:52 ` Tony Lindgren
2012-08-31 0:52 ` [PATCH 1/9] ARM: OMAP1: Move define of OMAP_LCD_DMA to dma.h Tony Lindgren
2012-08-31 0:52 ` Tony Lindgren
2012-08-31 0:52 ` [PATCH 2/9] ARM: OMAP1: Define OMAP1_INT_I2C locally Tony Lindgren
2012-08-31 0:52 ` Tony Lindgren
2012-08-31 0:52 ` [PATCH 3/9] ARM: OMAP2+: Make INTCPS_NR_IRQS local for mach-omap2/irq.c Tony Lindgren
2012-08-31 0:52 ` Tony Lindgren
2012-08-31 0:52 ` [PATCH 4/9] ARM: OMAP2+: Remove unused nand_irq for GPMC Tony Lindgren
2012-08-31 0:52 ` Tony Lindgren
2012-09-03 10:10 ` Mohammed, Afzal
2012-09-03 10:10 ` Mohammed, Afzal
2012-08-31 0:52 ` [PATCH 5/9] ARM: OMAP2+: Remove hardcoded twl4030 gpio_base, irq_base and irq_end Tony Lindgren
2012-08-31 0:52 ` Tony Lindgren
2012-08-31 23:16 ` Linus Walleij
2012-08-31 23:16 ` Linus Walleij
2012-08-31 23:52 ` Tony Lindgren
2012-08-31 23:52 ` Tony Lindgren
2012-09-05 13:12 ` Peter Ujfalusi
2012-09-05 13:12 ` Peter Ujfalusi
2012-09-05 16:54 ` Tony Lindgren [this message]
2012-09-05 16:54 ` Tony Lindgren
2012-08-31 0:52 ` [PATCH 6/9] ARM: OMAP: Move gpio.h to include/linux/platform_data Tony Lindgren
2012-08-31 0:52 ` Tony Lindgren
2012-08-31 23:17 ` Linus Walleij
2012-08-31 23:17 ` Linus Walleij
2012-08-31 23:17 ` Linus Walleij
2012-09-03 10:14 ` Mohammed, Afzal
2012-09-03 10:14 ` Mohammed, Afzal
2012-09-06 20:36 ` Tony Lindgren
2012-09-06 20:36 ` Tony Lindgren
2012-09-06 20:36 ` Tony Lindgren
2012-08-31 0:52 ` [PATCH 7/9] ARM: OMAP2+: Prepare for irqs.h removal Tony Lindgren
2012-08-31 0:52 ` Tony Lindgren
2012-09-04 8:46 ` Mohammed, Afzal
2012-09-04 8:46 ` Mohammed, Afzal
2012-09-05 1:09 ` Tony Lindgren
2012-09-05 1:09 ` Tony Lindgren
2012-09-05 9:03 ` Mohammed, Afzal
2012-09-05 9:03 ` Mohammed, Afzal
2012-09-05 12:48 ` Mohammed, Afzal
2012-09-05 12:48 ` Mohammed, Afzal
2012-09-05 1:14 ` Tony Lindgren
2012-09-05 1:14 ` Tony Lindgren
2012-08-31 0:52 ` [PATCH 8/9] ARM: OMAP2+: Remove hardcoded IRQs and enable SPARSE_IRQ Tony Lindgren
2012-08-31 0:52 ` Tony Lindgren
2012-09-05 1:17 ` Tony Lindgren
2012-09-05 1:17 ` Tony Lindgren
2012-08-31 0:52 ` [PATCH 9/9] ARM: OMAP1: Move plat/irqs.h to mach/irqs.h Tony Lindgren
2012-08-31 0:52 ` Tony Lindgren
2012-08-31 5:58 ` [PATCH 0/9] Clean up hardcoded IRQs for mach-omap2, enable SPARSE_IRQ, plaform_data/gpio-omap.h Rob Herring
2012-08-31 5:58 ` Rob Herring
2012-08-31 15:36 ` Tony Lindgren
2012-08-31 15:36 ` Tony Lindgren
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120905165445.GD1303@atomide.com \
--to=tony@atomide.com \
--cc=grant.likely@secretlab.ca \
--cc=linus.walleij@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-omap@vger.kernel.org \
--cc=peter.ujfalusi@ti.com \
--cc=sameo@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.