All of lore.kernel.org
 help / color / mirror / Atom feed
From: Tony Lindgren <tony@atomide.com>
To: AnilKumar Ch <anilkumar@ti.com>
Cc: wg@grandegger.com, mkl@pengutronix.de, linux-can@vger.kernel.org,
	linux-omap@vger.kernel.org, linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH RESEND 1/4] can: c_can: Adopt pinctrl support
Date: Wed, 5 Sep 2012 16:19:46 -0700	[thread overview]
Message-ID: <20120905231945.GJ1303@atomide.com> (raw)
In-Reply-To: <1346843564-25343-2-git-send-email-anilkumar@ti.com>

* AnilKumar Ch <anilkumar@ti.com> [120905 04:14]:
> Adopt pinctrl support to c_can driver based on c_can device
> pointer, pinctrl driver configure SoC pins to d_can mode
> according to definitions provided in .dts file.
> 
> In device specific device tree file 'pinctrl-names = "default";'
> and 'pinctrl-0 = <&d_can1_pins>;' needs to add to configure pins
> from c_can driver. d_can1_pins node contains the pinmux/config
> details of d_can L/H pins.
> 
> Signed-off-by: AnilKumar Ch <anilkumar@ti.com>

Acked-by: Tony Lindgren <tony@atomide.com>

> ---
>  drivers/net/can/c_can/c_can_platform.c |    7 +++++++
>  1 file changed, 7 insertions(+)
> 
> diff --git a/drivers/net/can/c_can/c_can_platform.c b/drivers/net/can/c_can/c_can_platform.c
> index 90801c4..c351975 100644
> --- a/drivers/net/can/c_can/c_can_platform.c
> +++ b/drivers/net/can/c_can/c_can_platform.c
> @@ -33,6 +33,7 @@
>  #include <linux/of.h>
>  #include <linux/of_device.h>
>  #include <linux/pm_runtime.h>
> +#include <linux/pinctrl/consumer.h>
>  
>  #include <linux/can/dev.h>
>  
> @@ -98,6 +99,7 @@ static int __devinit c_can_plat_probe(struct platform_device *pdev)
>  	struct c_can_priv *priv;
>  	const struct of_device_id *match;
>  	const struct platform_device_id *id;
> +	struct pinctrl *pinctrl;
>  	struct resource *mem;
>  	int irq;
>  	struct clk *clk;
> @@ -114,6 +116,11 @@ static int __devinit c_can_plat_probe(struct platform_device *pdev)
>  		id = platform_get_device_id(pdev);
>  	}
>  
> +	pinctrl = devm_pinctrl_get_select_default(&pdev->dev);
> +	if (IS_ERR(pinctrl))
> +		dev_warn(&pdev->dev,
> +			"failed to configure pins from driver\n");
> +
>  	/* get the appropriate clk */
>  	clk = clk_get(&pdev->dev, NULL);
>  	if (IS_ERR(clk)) {
> -- 
> 1.7.9.5
> 

WARNING: multiple messages have this Message-ID (diff)
From: tony@atomide.com (Tony Lindgren)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH RESEND 1/4] can: c_can: Adopt pinctrl support
Date: Wed, 5 Sep 2012 16:19:46 -0700	[thread overview]
Message-ID: <20120905231945.GJ1303@atomide.com> (raw)
In-Reply-To: <1346843564-25343-2-git-send-email-anilkumar@ti.com>

* AnilKumar Ch <anilkumar@ti.com> [120905 04:14]:
> Adopt pinctrl support to c_can driver based on c_can device
> pointer, pinctrl driver configure SoC pins to d_can mode
> according to definitions provided in .dts file.
> 
> In device specific device tree file 'pinctrl-names = "default";'
> and 'pinctrl-0 = <&d_can1_pins>;' needs to add to configure pins
> from c_can driver. d_can1_pins node contains the pinmux/config
> details of d_can L/H pins.
> 
> Signed-off-by: AnilKumar Ch <anilkumar@ti.com>

Acked-by: Tony Lindgren <tony@atomide.com>

> ---
>  drivers/net/can/c_can/c_can_platform.c |    7 +++++++
>  1 file changed, 7 insertions(+)
> 
> diff --git a/drivers/net/can/c_can/c_can_platform.c b/drivers/net/can/c_can/c_can_platform.c
> index 90801c4..c351975 100644
> --- a/drivers/net/can/c_can/c_can_platform.c
> +++ b/drivers/net/can/c_can/c_can_platform.c
> @@ -33,6 +33,7 @@
>  #include <linux/of.h>
>  #include <linux/of_device.h>
>  #include <linux/pm_runtime.h>
> +#include <linux/pinctrl/consumer.h>
>  
>  #include <linux/can/dev.h>
>  
> @@ -98,6 +99,7 @@ static int __devinit c_can_plat_probe(struct platform_device *pdev)
>  	struct c_can_priv *priv;
>  	const struct of_device_id *match;
>  	const struct platform_device_id *id;
> +	struct pinctrl *pinctrl;
>  	struct resource *mem;
>  	int irq;
>  	struct clk *clk;
> @@ -114,6 +116,11 @@ static int __devinit c_can_plat_probe(struct platform_device *pdev)
>  		id = platform_get_device_id(pdev);
>  	}
>  
> +	pinctrl = devm_pinctrl_get_select_default(&pdev->dev);
> +	if (IS_ERR(pinctrl))
> +		dev_warn(&pdev->dev,
> +			"failed to configure pins from driver\n");
> +
>  	/* get the appropriate clk */
>  	clk = clk_get(&pdev->dev, NULL);
>  	if (IS_ERR(clk)) {
> -- 
> 1.7.9.5
> 

  reply	other threads:[~2012-09-05 23:21 UTC|newest]

Thread overview: 34+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-09-05 11:12 [PATCH v2 0/4] can: c_can: Add suspend/resume and pinctrl support AnilKumar Ch
2012-09-05 11:12 ` AnilKumar Ch
2012-09-05 11:12 ` [PATCH RESEND 1/4] can: c_can: Adopt " AnilKumar Ch
2012-09-05 11:12   ` AnilKumar Ch
2012-09-05 23:19   ` Tony Lindgren [this message]
2012-09-05 23:19     ` Tony Lindgren
2012-09-05 11:12 ` [PATCH RESEND 2/4] can: c_can: Add d_can raminit support AnilKumar Ch
2012-09-05 11:12   ` AnilKumar Ch
2012-09-05 23:23   ` Tony Lindgren
2012-09-05 23:23     ` Tony Lindgren
2012-09-05 11:12 ` [PATCH RESEND 3/4] ARM: AM33XX: board-generic: Add of_dev_auxdata to pass d_can raminit AnilKumar Ch
2012-09-05 11:12   ` AnilKumar Ch
2012-09-05 23:18   ` Tony Lindgren
2012-09-05 23:18     ` Tony Lindgren
2012-09-06  3:56     ` Vaibhav Hiremath
2012-09-06  3:56       ` Vaibhav Hiremath
2012-09-06  5:03       ` Bedia, Vaibhav
2012-09-06  5:03         ` Bedia, Vaibhav
2012-09-06  5:07         ` Hiremath, Vaibhav
2012-09-06  5:07           ` Hiremath, Vaibhav
2012-09-05 11:12 ` [PATCH v2 4/4] can: c_can: Add d_can suspend resume support AnilKumar Ch
2012-09-05 11:12   ` AnilKumar Ch
2012-09-07  8:26   ` AnilKumar, Chimata
2012-09-07  8:26     ` AnilKumar, Chimata
2012-09-05 11:54 ` [PATCH v2 0/4] can: c_can: Add suspend/resume and pinctrl support Marc Kleine-Budde
2012-09-05 11:54   ` Marc Kleine-Budde
2012-09-05 13:55   ` Marc Kleine-Budde
2012-09-05 13:55     ` Marc Kleine-Budde
2012-09-05 23:26     ` Tony Lindgren
2012-09-05 23:26       ` Tony Lindgren
2012-09-06  6:09       ` AnilKumar, Chimata
2012-09-06  6:09         ` AnilKumar, Chimata
2012-09-06  8:27         ` Marc Kleine-Budde
2012-09-06  8:27           ` Marc Kleine-Budde

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20120905231945.GJ1303@atomide.com \
    --to=tony@atomide.com \
    --cc=anilkumar@ti.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-can@vger.kernel.org \
    --cc=linux-omap@vger.kernel.org \
    --cc=mkl@pengutronix.de \
    --cc=wg@grandegger.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.