All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] mxs/spi: Fix misuse of init_completion
@ 2012-08-22 20:57 ` Marek Vasut
  0 siblings, 0 replies; 8+ messages in thread
From: Marek Vasut @ 2012-08-22 20:57 UTC (permalink / raw)
  To: spi-devel-general-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f
  Cc: Marek Vasut, Fabio Estevam, Shawn Guo, Mark Brown, Chris Ball,
	linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r

Signed-off-by: Marek Vasut <marex-ynQEQJNshbs@public.gmane.org>
Cc: Chris Ball <cjb-2X9k7bc8m7Mdnm+yROfE0A@public.gmane.org>
Cc: Shawn Guo <shawn.guo-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
Cc: Mark Brown <broonie-yzvPICuk2AATkU/dhu1WVueM+bqZidxxQQ4Iyu8u01E@public.gmane.org>
Cc: Fabio Estevam <fabio.estevam-KZfg59tc24xl57MIdRCFDg@public.gmane.org>
---
 drivers/spi/spi-mxs.c |    4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/drivers/spi/spi-mxs.c b/drivers/spi/spi-mxs.c
index 331f600..c965cc6 100644
--- a/drivers/spi/spi-mxs.c
+++ b/drivers/spi/spi-mxs.c
@@ -230,7 +230,7 @@ static int mxs_spi_txrx_dma(struct mxs_spi *spi, int cs,
 		return -EINVAL;
 	}
 
-	init_completion(&spi->c);
+	INIT_COMPLETION(spi->c);
 
 	if (*first)
 		pio |= BM_SSP_CTRL0_LOCK_CS;
@@ -560,6 +560,8 @@ static int __devinit mxs_spi_probe(struct platform_device *pdev)
 	ssp->devid = devid;
 	ssp->dma_channel = dma_channel;
 
+	init_completion(&spi->c);
+
 	ret = devm_request_irq(&pdev->dev, irq_err, mxs_ssp_irq_handler, 0,
 			       DRIVER_NAME, ssp);
 	if (ret)
-- 
1.7.10.4


------------------------------------------------------------------------------
Live Security Virtual Conference
Exclusive live event will cover all the ways today's security and 
threat landscape has changed and how IT managers can respond. Discussions 
will include endpoint security, mobile security and the latest in malware 
threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/

^ permalink raw reply related	[flat|nested] 8+ messages in thread
* [PATCH] mxs/spi: Fix misuse of init_completion
@ 2012-08-22 20:57 ` Marek Vasut
  0 siblings, 0 replies; 8+ messages in thread
From: Marek Vasut @ 2012-08-22 20:57 UTC (permalink / raw)
  To: linux-arm-kernel

Signed-off-by: Marek Vasut <marex@denx.de>
Cc: Chris Ball <cjb@laptop.org>
Cc: Shawn Guo <shawn.guo@linaro.org>
Cc: Mark Brown <broonie@opensource.wolfsonmicro.com>
Cc: Fabio Estevam <fabio.estevam@freescale.com>
---
 drivers/spi/spi-mxs.c |    4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/drivers/spi/spi-mxs.c b/drivers/spi/spi-mxs.c
index 331f600..c965cc6 100644
--- a/drivers/spi/spi-mxs.c
+++ b/drivers/spi/spi-mxs.c
@@ -230,7 +230,7 @@ static int mxs_spi_txrx_dma(struct mxs_spi *spi, int cs,
 		return -EINVAL;
 	}
 
-	init_completion(&spi->c);
+	INIT_COMPLETION(spi->c);
 
 	if (*first)
 		pio |= BM_SSP_CTRL0_LOCK_CS;
@@ -560,6 +560,8 @@ static int __devinit mxs_spi_probe(struct platform_device *pdev)
 	ssp->devid = devid;
 	ssp->dma_channel = dma_channel;
 
+	init_completion(&spi->c);
+
 	ret = devm_request_irq(&pdev->dev, irq_err, mxs_ssp_irq_handler, 0,
 			       DRIVER_NAME, ssp);
 	if (ret)
-- 
1.7.10.4

^ permalink raw reply related	[flat|nested] 8+ messages in thread
* Re: [PATCH] mxs/spi: Fix misuse of init_completion
  2012-08-22 20:57 ` Marek Vasut
@ 2012-08-22 21:07     ` Chris Ball
  -1 siblings, 0 replies; 8+ messages in thread
From: Chris Ball @ 2012-08-22 21:07 UTC (permalink / raw)
  To: Marek Vasut
  Cc: Fabio Estevam, spi-devel-general-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f,
	Shawn Guo, linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r,
	Mark Brown

Hi,

On Wed, Aug 22 2012, Marek Vasut wrote:
> Signed-off-by: Marek Vasut <marex-ynQEQJNshbs@public.gmane.org>
> Cc: Chris Ball <cjb-2X9k7bc8m7Mdnm+yROfE0A@public.gmane.org>
> Cc: Shawn Guo <shawn.guo-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
> Cc: Mark Brown <broonie-yzvPICuk2AATkU/dhu1WVueM+bqZidxxQQ4Iyu8u01E@public.gmane.org>
> Cc: Fabio Estevam <fabio.estevam-KZfg59tc24xl57MIdRCFDg@public.gmane.org>
> ---
>  drivers/spi/spi-mxs.c |    4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/spi/spi-mxs.c b/drivers/spi/spi-mxs.c
> index 331f600..c965cc6 100644
> --- a/drivers/spi/spi-mxs.c
> +++ b/drivers/spi/spi-mxs.c
> @@ -230,7 +230,7 @@ static int mxs_spi_txrx_dma(struct mxs_spi *spi, int cs,
>  		return -EINVAL;
>  	}
>  
> -	init_completion(&spi->c);
> +	INIT_COMPLETION(spi->c);
>  
>  	if (*first)
>  		pio |= BM_SSP_CTRL0_LOCK_CS;
> @@ -560,6 +560,8 @@ static int __devinit mxs_spi_probe(struct platform_device *pdev)
>  	ssp->devid = devid;
>  	ssp->dma_channel = dma_channel;
>  
> +	init_completion(&spi->c);
> +
>  	ret = devm_request_irq(&pdev->dev, irq_err, mxs_ssp_irq_handler, 0,
>  			       DRIVER_NAME, ssp);
>  	if (ret)

Please be more specific with commit messages -- is there an observed
symptom that this fixes?  Does the patch need to go to stable@, too?

Thanks,

- Chris.
-- 
Chris Ball   <cjb-2X9k7bc8m7Mdnm+yROfE0A@public.gmane.org>   <http://printf.net/>
One Laptop Per Child

------------------------------------------------------------------------------
Live Security Virtual Conference
Exclusive live event will cover all the ways today's security and 
threat landscape has changed and how IT managers can respond. Discussions 
will include endpoint security, mobile security and the latest in malware 
threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/

^ permalink raw reply	[flat|nested] 8+ messages in thread
* [PATCH] mxs/spi: Fix misuse of init_completion
@ 2012-08-22 21:07     ` Chris Ball
  0 siblings, 0 replies; 8+ messages in thread
From: Chris Ball @ 2012-08-22 21:07 UTC (permalink / raw)
  To: linux-arm-kernel

Hi,

On Wed, Aug 22 2012, Marek Vasut wrote:
> Signed-off-by: Marek Vasut <marex@denx.de>
> Cc: Chris Ball <cjb@laptop.org>
> Cc: Shawn Guo <shawn.guo@linaro.org>
> Cc: Mark Brown <broonie@opensource.wolfsonmicro.com>
> Cc: Fabio Estevam <fabio.estevam@freescale.com>
> ---
>  drivers/spi/spi-mxs.c |    4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/spi/spi-mxs.c b/drivers/spi/spi-mxs.c
> index 331f600..c965cc6 100644
> --- a/drivers/spi/spi-mxs.c
> +++ b/drivers/spi/spi-mxs.c
> @@ -230,7 +230,7 @@ static int mxs_spi_txrx_dma(struct mxs_spi *spi, int cs,
>  		return -EINVAL;
>  	}
>  
> -	init_completion(&spi->c);
> +	INIT_COMPLETION(spi->c);
>  
>  	if (*first)
>  		pio |= BM_SSP_CTRL0_LOCK_CS;
> @@ -560,6 +560,8 @@ static int __devinit mxs_spi_probe(struct platform_device *pdev)
>  	ssp->devid = devid;
>  	ssp->dma_channel = dma_channel;
>  
> +	init_completion(&spi->c);
> +
>  	ret = devm_request_irq(&pdev->dev, irq_err, mxs_ssp_irq_handler, 0,
>  			       DRIVER_NAME, ssp);
>  	if (ret)

Please be more specific with commit messages -- is there an observed
symptom that this fixes?  Does the patch need to go to stable@, too?

Thanks,

- Chris.
-- 
Chris Ball   <cjb@laptop.org>   <http://printf.net/>
One Laptop Per Child

^ permalink raw reply	[flat|nested] 8+ messages in thread
* Re: [PATCH] mxs/spi: Fix misuse of init_completion
  2012-08-22 21:07     ` Chris Ball
@ 2012-08-22 21:30         ` Marek Vasut
  -1 siblings, 0 replies; 8+ messages in thread
From: Marek Vasut @ 2012-08-22 21:30 UTC (permalink / raw)
  To: Chris Ball
  Cc: Fabio Estevam, spi-devel-general-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f,
	Shawn Guo, linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r,
	Mark Brown

Dear Chris Ball,

> Hi,
> 
> On Wed, Aug 22 2012, Marek Vasut wrote:
> > Signed-off-by: Marek Vasut <marex-ynQEQJNshbs@public.gmane.org>
> > Cc: Chris Ball <cjb-2X9k7bc8m7Mdnm+yROfE0A@public.gmane.org>
> > Cc: Shawn Guo <shawn.guo-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
> > Cc: Mark Brown <broonie-yzvPICuk2AATkU/dhu1WVueM+bqZidxxQQ4Iyu8u01E@public.gmane.org>
> > Cc: Fabio Estevam <fabio.estevam-KZfg59tc24xl57MIdRCFDg@public.gmane.org>
> > ---
> > 
> >  drivers/spi/spi-mxs.c |    4 +++-
> >  1 file changed, 3 insertions(+), 1 deletion(-)
> > 
> > diff --git a/drivers/spi/spi-mxs.c b/drivers/spi/spi-mxs.c
> > index 331f600..c965cc6 100644
> > --- a/drivers/spi/spi-mxs.c
> > +++ b/drivers/spi/spi-mxs.c
> > @@ -230,7 +230,7 @@ static int mxs_spi_txrx_dma(struct mxs_spi *spi, int
> > cs,
> > 
> >  		return -EINVAL;
> >  	
> >  	}
> > 
> > -	init_completion(&spi->c);
> > +	INIT_COMPLETION(spi->c);
> > 
> >  	if (*first)
> >  	
> >  		pio |= BM_SSP_CTRL0_LOCK_CS;
> > 
> > @@ -560,6 +560,8 @@ static int __devinit mxs_spi_probe(struct
> > platform_device *pdev)
> > 
> >  	ssp->devid = devid;
> >  	ssp->dma_channel = dma_channel;
> > 
> > +	init_completion(&spi->c);
> > +
> > 
> >  	ret = devm_request_irq(&pdev->dev, irq_err, mxs_ssp_irq_handler, 0,
> >  	
> >  			       DRIVER_NAME, ssp);
> >  	
> >  	if (ret)
> 
> Please be more specific with commit messages

I kind of expected this change was pretty obvious.

> is there an observed symptom that this fixes?

None. I noticed this misuse, so I fixed it.

> Does the patch need to go to stable@, too?

No, this driver is in -next currently.

> Thanks,
> 
> - Chris.

Best regards,
Marek Vasut

------------------------------------------------------------------------------
Live Security Virtual Conference
Exclusive live event will cover all the ways today's security and 
threat landscape has changed and how IT managers can respond. Discussions 
will include endpoint security, mobile security and the latest in malware 
threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/

^ permalink raw reply	[flat|nested] 8+ messages in thread
* [PATCH] mxs/spi: Fix misuse of init_completion
@ 2012-08-22 21:30         ` Marek Vasut
  0 siblings, 0 replies; 8+ messages in thread
From: Marek Vasut @ 2012-08-22 21:30 UTC (permalink / raw)
  To: linux-arm-kernel

Dear Chris Ball,

> Hi,
> 
> On Wed, Aug 22 2012, Marek Vasut wrote:
> > Signed-off-by: Marek Vasut <marex@denx.de>
> > Cc: Chris Ball <cjb@laptop.org>
> > Cc: Shawn Guo <shawn.guo@linaro.org>
> > Cc: Mark Brown <broonie@opensource.wolfsonmicro.com>
> > Cc: Fabio Estevam <fabio.estevam@freescale.com>
> > ---
> > 
> >  drivers/spi/spi-mxs.c |    4 +++-
> >  1 file changed, 3 insertions(+), 1 deletion(-)
> > 
> > diff --git a/drivers/spi/spi-mxs.c b/drivers/spi/spi-mxs.c
> > index 331f600..c965cc6 100644
> > --- a/drivers/spi/spi-mxs.c
> > +++ b/drivers/spi/spi-mxs.c
> > @@ -230,7 +230,7 @@ static int mxs_spi_txrx_dma(struct mxs_spi *spi, int
> > cs,
> > 
> >  		return -EINVAL;
> >  	
> >  	}
> > 
> > -	init_completion(&spi->c);
> > +	INIT_COMPLETION(spi->c);
> > 
> >  	if (*first)
> >  	
> >  		pio |= BM_SSP_CTRL0_LOCK_CS;
> > 
> > @@ -560,6 +560,8 @@ static int __devinit mxs_spi_probe(struct
> > platform_device *pdev)
> > 
> >  	ssp->devid = devid;
> >  	ssp->dma_channel = dma_channel;
> > 
> > +	init_completion(&spi->c);
> > +
> > 
> >  	ret = devm_request_irq(&pdev->dev, irq_err, mxs_ssp_irq_handler, 0,
> >  	
> >  			       DRIVER_NAME, ssp);
> >  	
> >  	if (ret)
> 
> Please be more specific with commit messages

I kind of expected this change was pretty obvious.

> is there an observed symptom that this fixes?

None. I noticed this misuse, so I fixed it.

> Does the patch need to go to stable@, too?

No, this driver is in -next currently.

> Thanks,
> 
> - Chris.

Best regards,
Marek Vasut

^ permalink raw reply	[flat|nested] 8+ messages in thread
* Re: [PATCH] mxs/spi: Fix misuse of init_completion
  2012-08-22 20:57 ` Marek Vasut
@ 2012-09-05 23:46     ` Mark Brown
  -1 siblings, 0 replies; 8+ messages in thread
From: Mark Brown @ 2012-09-05 23:46 UTC (permalink / raw)
  To: Marek Vasut
  Cc: Fabio Estevam, spi-devel-general-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f,
	Chris Ball, linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r,
	Shawn Guo

On Wed, Aug 22, 2012 at 10:57:45PM +0200, Marek Vasut wrote:
> Signed-off-by: Marek Vasut <marex-ynQEQJNshbs@public.gmane.org>

Applied, thanks.

------------------------------------------------------------------------------
Live Security Virtual Conference
Exclusive live event will cover all the ways today's security and 
threat landscape has changed and how IT managers can respond. Discussions 
will include endpoint security, mobile security and the latest in malware 
threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/

^ permalink raw reply	[flat|nested] 8+ messages in thread
* [PATCH] mxs/spi: Fix misuse of init_completion
@ 2012-09-05 23:46     ` Mark Brown
  0 siblings, 0 replies; 8+ messages in thread
From: Mark Brown @ 2012-09-05 23:46 UTC (permalink / raw)
  To: linux-arm-kernel

On Wed, Aug 22, 2012 at 10:57:45PM +0200, Marek Vasut wrote:
> Signed-off-by: Marek Vasut <marex@denx.de>

Applied, thanks.

^ permalink raw reply	[flat|nested] 8+ messages in thread
end of thread, other threads:[~2012-09-05 23:46 UTC | newest]

Thread overview: 8+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-08-22 20:57 [PATCH] mxs/spi: Fix misuse of init_completion Marek Vasut
2012-08-22 20:57 ` Marek Vasut
     [not found] ` <1345669065-17750-1-git-send-email-marex-ynQEQJNshbs@public.gmane.org>
2012-08-22 21:07   ` Chris Ball
2012-08-22 21:07     ` Chris Ball
     [not found]     ` <87ehmyzlds.fsf-DGHOrqG7t0YzNDMTQreKSUB+6BGkLq7r@public.gmane.org>
2012-08-22 21:30       ` Marek Vasut
2012-08-22 21:30         ` Marek Vasut
2012-09-05 23:46   ` Mark Brown
2012-09-05 23:46     ` Mark Brown

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.