All of lore.kernel.org
 help / color / mirror / Atom feed
From: Shaohua Li <shli@kernel.org>
To: linux-mm@kvack.org
Cc: akpm@linux-foundation.org, mgorman@suse.de, aarcange@redhat.com
Subject: [patch 1/2]compaction: check migrated page number
Date: Thu, 6 Sep 2012 18:44:04 +0800	[thread overview]
Message-ID: <20120906104404.GA12718@kernel.org> (raw)


isolate_migratepages_range() might isolate none pages, for example, when
zone->lru_lock is contended and compaction is async. In this case, we should
abort compaction, otherwise, compact_zone will run a useless loop and make
zone->lru_lock is even contended.

Signed-off-by: Shaohua Li <shli@fusionio.com>
---
 mm/compaction.c |    2 ++
 1 file changed, 2 insertions(+)

Index: linux/mm/compaction.c
===================================================================
--- linux.orig/mm/compaction.c	2012-08-22 09:51:39.295322268 +0800
+++ linux/mm/compaction.c	2012-09-06 14:46:13.923144263 +0800
@@ -402,6 +402,8 @@ isolate_migratepages_range(struct zone *
 
 	trace_mm_compaction_isolate_migratepages(nr_scanned, nr_isolated);
 
+	if (!nr_isolated)
+		return 0;
 	return low_pfn;
 }
 

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>

             reply	other threads:[~2012-09-06 10:44 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-09-06 10:44 Shaohua Li [this message]
2012-09-06 12:17 ` [patch 1/2]compaction: check migrated page number Mel Gorman
2012-09-06 12:55   ` Shaohua Li
2012-09-06 13:25     ` Mel Gorman
2012-09-07  4:12       ` Shaohua Li
2012-09-07 15:52         ` Andrea Arcangeli
2012-09-10  1:05           ` Shaohua Li

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20120906104404.GA12718@kernel.org \
    --to=shli@kernel.org \
    --cc=aarcange@redhat.com \
    --cc=akpm@linux-foundation.org \
    --cc=linux-mm@kvack.org \
    --cc=mgorman@suse.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.