From: Mel Gorman <mgorman@suse.de>
To: Shaohua Li <shli@kernel.org>
Cc: linux-mm@kvack.org, akpm@linux-foundation.org, aarcange@redhat.com
Subject: Re: [patch 1/2]compaction: check migrated page number
Date: Thu, 6 Sep 2012 13:17:25 +0100 [thread overview]
Message-ID: <20120906121725.GQ11266@suse.de> (raw)
In-Reply-To: <20120906104404.GA12718@kernel.org>
On Thu, Sep 06, 2012 at 06:44:04PM +0800, Shaohua Li wrote:
>
> isolate_migratepages_range() might isolate none pages, for example, when
> zone->lru_lock is contended and compaction is async. In this case, we should
> abort compaction, otherwise, compact_zone will run a useless loop and make
> zone->lru_lock is even contended.
>
It might also isolate no pages because the range was 100% allocated and
there were no free pages to isolate. This is perfectly normal and I suspect
this patch effectively disables compaction. What problem did you observe
that this patch is aimed at?
--
Mel Gorman
SUSE Labs
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2012-09-06 12:17 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-09-06 10:44 [patch 1/2]compaction: check migrated page number Shaohua Li
2012-09-06 12:17 ` Mel Gorman [this message]
2012-09-06 12:55 ` Shaohua Li
2012-09-06 13:25 ` Mel Gorman
2012-09-07 4:12 ` Shaohua Li
2012-09-07 15:52 ` Andrea Arcangeli
2012-09-10 1:05 ` Shaohua Li
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120906121725.GQ11266@suse.de \
--to=mgorman@suse.de \
--cc=aarcange@redhat.com \
--cc=akpm@linux-foundation.org \
--cc=linux-mm@kvack.org \
--cc=shli@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.