All of lore.kernel.org
 help / color / mirror / Atom feed
From: Vivek Goyal <vgoyal-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
To: Harald Hoyer <harald-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
Cc: initramfs-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	Dave Young <dyoung-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
Subject: Re: [PATCH] dracut: Override rd.md settings if rd.md.uuid is provided
Date: Thu, 6 Sep 2012 09:57:22 -0400	[thread overview]
Message-ID: <20120906135722.GB27209@redhat.com> (raw)
In-Reply-To: <50487777.1050502-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>

On Thu, Sep 06, 2012 at 12:14:15PM +0200, Harald Hoyer wrote:

[..]
> 
> 
> Similar patch comitted upstream

Hi Harald,

I think we need to use && instead of || in upstream committed patch.

+if ! [ -n "$MD_UUID" ] || ! getargbool 1 rd.md -d -n rd_NO_MD; then

Otherwise even if MD_UUID is defined, we check for rd_NO_MD and disable
raid activation. It is not different from behavior without patch.

Thanks
Vivek



      parent reply	other threads:[~2012-09-06 13:57 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-09-05 21:20 [PATCH] dracut: Override rd.md settings if rd.md.uuid is provided Vivek Goyal
     [not found] ` <20120905212047.GE19749-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2012-09-05 21:24   ` Vivek Goyal
     [not found]     ` <20120905212434.GA27154-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2012-09-06 10:14       ` Harald Hoyer
     [not found]         ` <50487777.1050502-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2012-09-06 13:57           ` Vivek Goyal [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20120906135722.GB27209@redhat.com \
    --to=vgoyal-h+wxahxf7alqt0dzr+alfa@public.gmane.org \
    --cc=dyoung-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org \
    --cc=harald-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org \
    --cc=initramfs-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.