All of lore.kernel.org
 help / color / mirror / Atom feed
From: Harald Hoyer <harald-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
To: Vivek Goyal <vgoyal-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
Cc: initramfs-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	Dave Young <dyoung-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
Subject: Re: [PATCH] dracut: Override rd.md settings if rd.md.uuid is provided
Date: Thu, 06 Sep 2012 12:14:15 +0200	[thread overview]
Message-ID: <50487777.1050502@redhat.com> (raw)
In-Reply-To: <20120905212434.GA27154-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>

Am 05.09.2012 23:24, schrieb Vivek Goyal:
> On Wed, Sep 05, 2012 at 05:20:47PM -0400, Vivek Goyal wrote:
>>
>> Currently anaconda provides rd.md=0 on kernel's command line as a boot
>> time optimization if root is not on md device. But this leads to kdump
>> failure. We copy the command line from first kernel and if dump target
>> is on md device, it fails as we never try to assemble md devices as
>> rd.md=0.
> 
> Oops, forgot to refresh the patch before sending. Please ignore the
> previous version. Take this version of patch.
> 
> Thanks
> Vivek
> 
> Currently anaconda provides rd.md=0 on kernel's command line as a boot
> time optimization if root is not on md device. But this leads to kdump
> failure. We copy the command line from first kernel and if dump target
> is on md device, it fails as we never try to assemble md devices as
> rd.md=0.
> 
> We have already set rd.md.uuid though in /etc/cmdlind.d/ dir providing
> dracut the info about what md devices to assemble. So this patch overrides
> rd.md settings if rd.md.uuid is provided.
> 
> This is a stop gap measure to get kdump working on software raid
> devices. Harald seems to have bigger cleanup plans for rd.md. Once
> that happens, this patch will not be needed and things should
> automatically be fixed.
> 
> Signed-off-by: Vivek Goyal <vgoyal-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
> ---
>  lib/dracut/modules.d/90mdraid/parse-md.sh |    7 ++++++-
>  1 file changed, 6 insertions(+), 1 deletion(-)
> 
> Index: /lib/dracut/modules.d/90mdraid/parse-md.sh
> ===================================================================
> --- .orig/lib/dracut/modules.d/90mdraid/parse-md.sh	2012-04-05 07:54:38.000000000 -0400
> +++ /lib/dracut/modules.d/90mdraid/parse-md.sh	2012-09-05 11:12:10.219001187 -0400
> @@ -1,7 +1,12 @@
>  #!/bin/sh
>  # -*- mode: shell-script; indent-tabs-mode: nil; sh-basic-offset: 4; -*-
>  # ex: ts=8 sw=4 sts=4 et filetype=sh
> -if ! getargbool 1 rd.md -n rd_NO_MD; then
> +MD_UUID=$(getargs rd.md.uuid rd_MD_UUID=)
> +
> +# If rd.md.uuid or rd_MD_UUID is specified, override rd.md settings.
> +[ -n "$MD_UUID" ] && override_rd_md=1
> +
> +if [ -z "$override_rd_md" ] && [ ! $(getargbool 1 rd.md -n rd_NO_MD) ]; then
>      info "rd.md=0: removing MD RAID activation"
>      udevproperty rd_NO_MD=1
>  else
> --
> To unsubscribe from this list: send the line "unsubscribe initramfs" in
> the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> 


Similar patch comitted upstream

  parent reply	other threads:[~2012-09-06 10:14 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-09-05 21:20 [PATCH] dracut: Override rd.md settings if rd.md.uuid is provided Vivek Goyal
     [not found] ` <20120905212047.GE19749-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2012-09-05 21:24   ` Vivek Goyal
     [not found]     ` <20120905212434.GA27154-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2012-09-06 10:14       ` Harald Hoyer [this message]
     [not found]         ` <50487777.1050502-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2012-09-06 13:57           ` Vivek Goyal

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=50487777.1050502@redhat.com \
    --to=harald-h+wxahxf7alqt0dzr+alfa@public.gmane.org \
    --cc=dyoung-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org \
    --cc=initramfs-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=vgoyal-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.