From: Tejun Heo <tj@kernel.org>
To: "Bruno Prémont" <bonbons@linux-vserver.org>
Cc: Emil Goode <emilgoode@gmail.com>,
jkosina@suse.cz, linux-input@vger.kernel.org,
linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org
Subject: Re: [PATCH] HID: picoLCD: Remove use of deprecated function
Date: Thu, 06 Sep 2012 20:15:38 +0000 [thread overview]
Message-ID: <20120906201538.GK29092@google.com> (raw)
In-Reply-To: <20120906221252.1402ba50@neptune.home>
On Thu, Sep 06, 2012 at 10:12:52PM +0200, Bruno Prémont wrote:
> On Thu, 06 September 2012 Emil Goode <emilgoode@gmail.com> wrote:
> > The flush_delayed_work_sync function is deprecated,
> > we can instead call flush_delayed_work directly.
> >
> > Sparse is giving a warning:
> > drivers/hid/hid-picolcd_fb.c:611:2: warning:
> > ‘flush_delayed_work_sync’ is deprecated
> > (declared at include/linux/workqueue.h:454)
> > [-Wdeprecated-declarations]
> >
> > Signed-off-by: Emil Goode <emilgoode@gmail.com>
>
> Acked-by: Bruno Prémont <bonbons@linux-vserver.org>
>
> This matches a patch by Tejun a few weeks ago which was partially
> skipped in -next due to merge conflict with code split in picoLCD.
>
> See http://comments.gmane.org/gmane.linux.kernel.next/23740
>
> For the sake of proper bisectability, this should go in after
> Tejun's workqueue changes (if needed at all depending on how merge
> happens during pull by Linus).
Yeah, we either can ask Linus to fix it up during merge or send a
separate patch afterwards. In this case, I don't think it matters too
much either way. I tend to send out pull request fairly early in the
merge window, I'll try to remember to poke Linus about the merge
conflict.
Thanks.
--
tejun
WARNING: multiple messages have this Message-ID (diff)
From: Tejun Heo <tj@kernel.org>
To: "Bruno Prémont" <bonbons@linux-vserver.org>
Cc: Emil Goode <emilgoode@gmail.com>,
jkosina@suse.cz, linux-input@vger.kernel.org,
linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org
Subject: Re: [PATCH] HID: picoLCD: Remove use of deprecated function
Date: Thu, 6 Sep 2012 13:15:38 -0700 [thread overview]
Message-ID: <20120906201538.GK29092@google.com> (raw)
In-Reply-To: <20120906221252.1402ba50@neptune.home>
On Thu, Sep 06, 2012 at 10:12:52PM +0200, Bruno Prémont wrote:
> On Thu, 06 September 2012 Emil Goode <emilgoode@gmail.com> wrote:
> > The flush_delayed_work_sync function is deprecated,
> > we can instead call flush_delayed_work directly.
> >
> > Sparse is giving a warning:
> > drivers/hid/hid-picolcd_fb.c:611:2: warning:
> > ‘flush_delayed_work_sync’ is deprecated
> > (declared at include/linux/workqueue.h:454)
> > [-Wdeprecated-declarations]
> >
> > Signed-off-by: Emil Goode <emilgoode@gmail.com>
>
> Acked-by: Bruno Prémont <bonbons@linux-vserver.org>
>
> This matches a patch by Tejun a few weeks ago which was partially
> skipped in -next due to merge conflict with code split in picoLCD.
>
> See http://comments.gmane.org/gmane.linux.kernel.next/23740
>
> For the sake of proper bisectability, this should go in after
> Tejun's workqueue changes (if needed at all depending on how merge
> happens during pull by Linus).
Yeah, we either can ask Linus to fix it up during merge or send a
separate patch afterwards. In this case, I don't think it matters too
much either way. I tend to send out pull request fairly early in the
merge window, I'll try to remember to poke Linus about the merge
conflict.
Thanks.
--
tejun
--
To unsubscribe from this list: send the line "unsubscribe linux-input" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
WARNING: multiple messages have this Message-ID (diff)
From: Tejun Heo <tj@kernel.org>
To: "Bruno Prémont" <bonbons@linux-vserver.org>
Cc: Emil Goode <emilgoode@gmail.com>,
jkosina@suse.cz, linux-input@vger.kernel.org,
linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org
Subject: Re: [PATCH] HID: picoLCD: Remove use of deprecated function
Date: Thu, 6 Sep 2012 13:15:38 -0700 [thread overview]
Message-ID: <20120906201538.GK29092@google.com> (raw)
In-Reply-To: <20120906221252.1402ba50@neptune.home>
On Thu, Sep 06, 2012 at 10:12:52PM +0200, Bruno Prémont wrote:
> On Thu, 06 September 2012 Emil Goode <emilgoode@gmail.com> wrote:
> > The flush_delayed_work_sync function is deprecated,
> > we can instead call flush_delayed_work directly.
> >
> > Sparse is giving a warning:
> > drivers/hid/hid-picolcd_fb.c:611:2: warning:
> > ‘flush_delayed_work_sync’ is deprecated
> > (declared at include/linux/workqueue.h:454)
> > [-Wdeprecated-declarations]
> >
> > Signed-off-by: Emil Goode <emilgoode@gmail.com>
>
> Acked-by: Bruno Prémont <bonbons@linux-vserver.org>
>
> This matches a patch by Tejun a few weeks ago which was partially
> skipped in -next due to merge conflict with code split in picoLCD.
>
> See http://comments.gmane.org/gmane.linux.kernel.next/23740
>
> For the sake of proper bisectability, this should go in after
> Tejun's workqueue changes (if needed at all depending on how merge
> happens during pull by Linus).
Yeah, we either can ask Linus to fix it up during merge or send a
separate patch afterwards. In this case, I don't think it matters too
much either way. I tend to send out pull request fairly early in the
merge window, I'll try to remember to poke Linus about the merge
conflict.
Thanks.
--
tejun
next prev parent reply other threads:[~2012-09-06 20:15 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-09-06 14:46 [PATCH] HID: picoLCD: Remove use of deprecated function Emil Goode
2012-09-06 14:46 ` Emil Goode
2012-09-06 14:46 ` Emil Goode
2012-09-06 20:12 ` Bruno Prémont
2012-09-06 20:12 ` Bruno Prémont
2012-09-06 20:12 ` Bruno Prémont
2012-09-06 20:15 ` Tejun Heo [this message]
2012-09-06 20:15 ` Tejun Heo
2012-09-06 20:15 ` Tejun Heo
2012-09-07 13:11 ` Jiri Kosina
2012-09-07 13:11 ` Jiri Kosina
2012-09-07 13:11 ` Jiri Kosina
2012-10-01 22:18 ` Jiri Kosina
2012-10-01 22:18 ` Jiri Kosina
2012-10-01 22:18 ` Jiri Kosina
2012-10-02 5:51 ` Tejun Heo
2012-10-02 5:51 ` Tejun Heo
-- strict thread matches above, loose matches on Subject: below --
2012-10-02 7:00 [GIT PULL] workqueue changes for v3.7-rc1 Tejun Heo
2012-10-02 8:06 ` [PATCH] HID: picoLCD: Remove use of deprecated function Tejun Heo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120906201538.GK29092@google.com \
--to=tj@kernel.org \
--cc=bonbons@linux-vserver.org \
--cc=emilgoode@gmail.com \
--cc=jkosina@suse.cz \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.