From: Kent Overstreet <koverstreet-hpIqsD4AKlfQT0dZR+AlfA@public.gmane.org>
To: Jun'ichi Nomura <j-nomura-JhyGz2TFV9J8UrSeD/g0lQ@public.gmane.org>
Cc: device-mapper development
<dm-devel-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>,
linux-bcache-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
tj-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org,
Alasdair Kergon <agk-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>,
vgoyal-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org
Subject: Re: [dm-devel] [PATCH v8 3/8] dm: Use bioset's front_pad for dm_rq_clone_bio_info
Date: Thu, 6 Sep 2012 15:28:49 -0700 [thread overview]
Message-ID: <20120906222849.GI25236@google.com> (raw)
In-Reply-To: <504816AB.8080105-JhyGz2TFV9J8UrSeD/g0lQ@public.gmane.org>
On Thu, Sep 06, 2012 at 12:21:15PM +0900, Jun'ichi Nomura wrote:
> On 09/06/12 05:27, Kent Overstreet wrote:
> > @@ -2718,7 +2705,8 @@ struct dm_md_mempools *dm_alloc_md_mempools(unsigned type, unsigned integrity)
> > if (!pools->tio_pool)
> > goto free_io_pool_and_out;
> >
> > - pools->bs = bioset_create(pool_size, 0);
> > + pools->bs = bioset_create(pool_size,
> > + offsetof(struct dm_rq_clone_bio_info, clone));
> > if (!pools->bs)
> > goto free_tio_pool_and_out;
>
> frontpad is not necessary if type is DM_TYPE_BIO_BASED.
>
> Other pool creation in that function do something like:
> pools->bs = (type == DM_TYPE_BIO_BASED) ?
> bioset_create(pool_size, 0) :
> bioset_create(pool_size, offsetof(struct dm_rq_clone_bio_info, clone));
>
Eh, it doesn't really matter considering it's two pointers of padding
and struct bio + the inline vecs are something like 200 bytes, but I can
do it if it makes you happy. Can I get someone's acked-by?
WARNING: multiple messages have this Message-ID (diff)
From: Kent Overstreet <koverstreet@google.com>
To: "Jun'ichi Nomura" <j-nomura@ce.jp.nec.com>
Cc: device-mapper development <dm-devel@redhat.com>,
linux-bcache@vger.kernel.org, linux-kernel@vger.kernel.org,
tj@kernel.org, Alasdair Kergon <agk@redhat.com>,
vgoyal@redhat.com
Subject: Re: [dm-devel] [PATCH v8 3/8] dm: Use bioset's front_pad for dm_rq_clone_bio_info
Date: Thu, 6 Sep 2012 15:28:49 -0700 [thread overview]
Message-ID: <20120906222849.GI25236@google.com> (raw)
In-Reply-To: <504816AB.8080105@ce.jp.nec.com>
On Thu, Sep 06, 2012 at 12:21:15PM +0900, Jun'ichi Nomura wrote:
> On 09/06/12 05:27, Kent Overstreet wrote:
> > @@ -2718,7 +2705,8 @@ struct dm_md_mempools *dm_alloc_md_mempools(unsigned type, unsigned integrity)
> > if (!pools->tio_pool)
> > goto free_io_pool_and_out;
> >
> > - pools->bs = bioset_create(pool_size, 0);
> > + pools->bs = bioset_create(pool_size,
> > + offsetof(struct dm_rq_clone_bio_info, clone));
> > if (!pools->bs)
> > goto free_tio_pool_and_out;
>
> frontpad is not necessary if type is DM_TYPE_BIO_BASED.
>
> Other pool creation in that function do something like:
> pools->bs = (type == DM_TYPE_BIO_BASED) ?
> bioset_create(pool_size, 0) :
> bioset_create(pool_size, offsetof(struct dm_rq_clone_bio_info, clone));
>
Eh, it doesn't really matter considering it's two pointers of padding
and struct bio + the inline vecs are something like 200 bytes, but I can
do it if it makes you happy. Can I get someone's acked-by?
next prev parent reply other threads:[~2012-09-06 22:28 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-09-05 20:27 [PATCH v8 0/8] Block cleanups Kent Overstreet
2012-09-05 20:27 ` Kent Overstreet
2012-09-05 20:27 ` [PATCH v8 1/8] block: Generalized bio pool freeing Kent Overstreet
2012-09-05 20:27 ` Kent Overstreet
[not found] ` <1346876849-15820-1-git-send-email-koverstreet-hpIqsD4AKlfQT0dZR+AlfA@public.gmane.org>
2012-09-05 20:27 ` [PATCH v8 2/8] block: Ues bi_pool for bio_integrity_alloc() Kent Overstreet
2012-09-05 20:27 ` Kent Overstreet
[not found] ` <1346876849-15820-3-git-send-email-koverstreet-hpIqsD4AKlfQT0dZR+AlfA@public.gmane.org>
2012-09-06 21:01 ` Tejun Heo
2012-09-06 21:01 ` Tejun Heo
2012-09-05 20:27 ` [PATCH v8 3/8] dm: Use bioset's front_pad for dm_rq_clone_bio_info Kent Overstreet
2012-09-05 20:27 ` Kent Overstreet
[not found] ` <1346876849-15820-4-git-send-email-koverstreet-hpIqsD4AKlfQT0dZR+AlfA@public.gmane.org>
2012-09-06 3:21 ` [dm-devel] " Jun'ichi Nomura
2012-09-06 3:21 ` Jun'ichi Nomura
[not found] ` <504816AB.8080105-JhyGz2TFV9J8UrSeD/g0lQ@public.gmane.org>
2012-09-06 22:28 ` Kent Overstreet [this message]
2012-09-06 22:28 ` Kent Overstreet
2012-09-05 20:27 ` [PATCH v8 4/8] block: Add bio_reset() Kent Overstreet
2012-09-05 20:27 ` Kent Overstreet
2012-09-05 20:27 ` [PATCH v8 5/8] pktcdvd: Switch to bio_kmalloc() Kent Overstreet
2012-09-05 20:27 ` [PATCH v8 6/8] block: Kill bi_destructor Kent Overstreet
2012-09-05 20:27 ` [PATCH v8 7/8] block: Consolidate bio_alloc_bioset(), bio_kmalloc() Kent Overstreet
2012-09-05 20:27 ` [PATCH v8 8/8] block: Add bio_clone_bioset(), bio_clone_kmalloc() Kent Overstreet
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120906222849.GI25236@google.com \
--to=koverstreet-hpiqsd4aklfqt0dzr+alfa@public.gmane.org \
--cc=agk-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org \
--cc=dm-devel-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org \
--cc=j-nomura-JhyGz2TFV9J8UrSeD/g0lQ@public.gmane.org \
--cc=linux-bcache-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=tj-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org \
--cc=vgoyal-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.