From: "Paul E. McKenney" <paulmck@linux.vnet.ibm.com>
To: Michael Wang <wangyun@linux.vnet.ibm.com>
Cc: Christoph Lameter <cl@linux.com>,
LKML <linux-kernel@vger.kernel.org>,
linux-mm@kvack.org, Matt Mackall <mpm@selenic.com>,
Pekka Enberg <penberg@kernel.org>
Subject: Re: [PATCH] slab: fix the DEADLOCK issue on l3 alien lock
Date: Thu, 6 Sep 2012 15:29:33 -0700 [thread overview]
Message-ID: <20120906222933.GR2448@linux.vnet.ibm.com> (raw)
In-Reply-To: <504812E7.3000700@linux.vnet.ibm.com>
On Thu, Sep 06, 2012 at 11:05:11AM +0800, Michael Wang wrote:
> On 09/05/2012 09:55 PM, Christoph Lameter wrote:
> > On Wed, 5 Sep 2012, Michael Wang wrote:
> >
> >> Since the cachep and cachep->slabp_cache's l3 alien are in the same lock class,
> >> fake report generated.
> >
> > Ahh... That is a key insight into why this occurs.
> >
> >> This should not happen since we already have init_lock_keys() which will
> >> reassign the lock class for both l3 list and l3 alien.
> >
> > Right. I was wondering why we still get intermitted reports on this.
> >
> >> This patch will invoke init_lock_keys() after we done enable_cpucache()
> >> instead of before to avoid the fake DEADLOCK report.
> >
> > Acked-by: Christoph Lameter <cl@linux.com>
>
> Thanks for your review.
>
> And add Paul to the cc list(my skills on mailing is really poor...).
Tested-by: Paul E. McKenney <paulmck@linux.vnet.ibm.com>
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
WARNING: multiple messages have this Message-ID (diff)
From: "Paul E. McKenney" <paulmck@linux.vnet.ibm.com>
To: Michael Wang <wangyun@linux.vnet.ibm.com>
Cc: Christoph Lameter <cl@linux.com>,
LKML <linux-kernel@vger.kernel.org>,
linux-mm@kvack.org, Matt Mackall <mpm@selenic.com>,
Pekka Enberg <penberg@kernel.org>
Subject: Re: [PATCH] slab: fix the DEADLOCK issue on l3 alien lock
Date: Thu, 6 Sep 2012 15:29:33 -0700 [thread overview]
Message-ID: <20120906222933.GR2448@linux.vnet.ibm.com> (raw)
In-Reply-To: <504812E7.3000700@linux.vnet.ibm.com>
On Thu, Sep 06, 2012 at 11:05:11AM +0800, Michael Wang wrote:
> On 09/05/2012 09:55 PM, Christoph Lameter wrote:
> > On Wed, 5 Sep 2012, Michael Wang wrote:
> >
> >> Since the cachep and cachep->slabp_cache's l3 alien are in the same lock class,
> >> fake report generated.
> >
> > Ahh... That is a key insight into why this occurs.
> >
> >> This should not happen since we already have init_lock_keys() which will
> >> reassign the lock class for both l3 list and l3 alien.
> >
> > Right. I was wondering why we still get intermitted reports on this.
> >
> >> This patch will invoke init_lock_keys() after we done enable_cpucache()
> >> instead of before to avoid the fake DEADLOCK report.
> >
> > Acked-by: Christoph Lameter <cl@linux.com>
>
> Thanks for your review.
>
> And add Paul to the cc list(my skills on mailing is really poor...).
Tested-by: Paul E. McKenney <paulmck@linux.vnet.ibm.com>
next prev parent reply other threads:[~2012-09-06 22:29 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <5044692D.7080608@linux.vnet.ibm.com>
2012-09-05 2:33 ` [PATCH] slab: fix the DEADLOCK issue on l3 alien lock Michael Wang
2012-09-05 2:33 ` Michael Wang
2012-09-05 13:55 ` Christoph Lameter
2012-09-05 13:55 ` Christoph Lameter
2012-09-06 3:05 ` Michael Wang
2012-09-06 3:05 ` Michael Wang
2012-09-06 22:29 ` Paul E. McKenney [this message]
2012-09-06 22:29 ` Paul E. McKenney
2012-09-08 8:39 ` Pekka Enberg
2012-09-08 8:39 ` Pekka Enberg
2012-09-11 2:50 ` Michael Wang
2012-09-11 2:50 ` Michael Wang
2012-09-11 16:29 ` Pekka Enberg
2012-09-11 16:29 ` Pekka Enberg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120906222933.GR2448@linux.vnet.ibm.com \
--to=paulmck@linux.vnet.ibm.com \
--cc=cl@linux.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mpm@selenic.com \
--cc=penberg@kernel.org \
--cc=wangyun@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.