From: Minchan Kim <minchan@kernel.org>
To: Kamezawa Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com>
Cc: Andrew Morton <akpm@linux-foundation.org>,
linux-mm@kvack.org, linux-kernel@vger.kernel.org,
Mel Gorman <mgorman@suse.de>,
Yasuaki Ishimatsu <isimatu.yasuaki@jp.fujitsu.com>,
Xishi Qiu <qiuxishi@huawei.com>,
Wen Congyang <wency@cn.fujitsu.com>
Subject: Re: [PATCH v2 2/3] mm: remain migratetype in freed page
Date: Fri, 7 Sep 2012 09:08:27 +0900 [thread overview]
Message-ID: <20120907000827.GF16231@bbox> (raw)
In-Reply-To: <50483EF4.6010909@jp.fujitsu.com>
On Thu, Sep 06, 2012 at 03:13:08PM +0900, Kamezawa Hiroyuki wrote:
> (2012/09/06 14:16), Minchan Kim wrote:
> > The page allocator caches the pageblock information in page->private while
> > it is in the PCP freelists but this is overwritten with the order of the
> > page when freed to the buddy allocator. This patch stores the migratetype
> > of the page in the page->index field so that it is available at all times
> > when the page remain in free_list.
> >
> sounds reasonable.
>
> > This patch adds a new call site in __free_pages_ok so it might be
> > overhead a bit but it's for high order allocation.
> > So I believe damage isn't hurt.
> >
> > * from v1
> > * Fix move_freepages's migratetype - Mel
> > * Add more kind explanation in description - Mel
> >
> > Signed-off-by: Minchan Kim <minchan@kernel.org>
>
> Hmm, page->index is valid only when the page is the head of buddy chunk ?
Yes.
>
> Anyway,
>
> Acked-by: KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com>
Thanks, Kame!
--
Kind regards,
Minchan Kim
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
WARNING: multiple messages have this Message-ID (diff)
From: Minchan Kim <minchan@kernel.org>
To: Kamezawa Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com>
Cc: Andrew Morton <akpm@linux-foundation.org>,
linux-mm@kvack.org, linux-kernel@vger.kernel.org,
Mel Gorman <mgorman@suse.de>,
Yasuaki Ishimatsu <isimatu.yasuaki@jp.fujitsu.com>,
Xishi Qiu <qiuxishi@huawei.com>,
Wen Congyang <wency@cn.fujitsu.com>
Subject: Re: [PATCH v2 2/3] mm: remain migratetype in freed page
Date: Fri, 7 Sep 2012 09:08:27 +0900 [thread overview]
Message-ID: <20120907000827.GF16231@bbox> (raw)
In-Reply-To: <50483EF4.6010909@jp.fujitsu.com>
On Thu, Sep 06, 2012 at 03:13:08PM +0900, Kamezawa Hiroyuki wrote:
> (2012/09/06 14:16), Minchan Kim wrote:
> > The page allocator caches the pageblock information in page->private while
> > it is in the PCP freelists but this is overwritten with the order of the
> > page when freed to the buddy allocator. This patch stores the migratetype
> > of the page in the page->index field so that it is available at all times
> > when the page remain in free_list.
> >
> sounds reasonable.
>
> > This patch adds a new call site in __free_pages_ok so it might be
> > overhead a bit but it's for high order allocation.
> > So I believe damage isn't hurt.
> >
> > * from v1
> > * Fix move_freepages's migratetype - Mel
> > * Add more kind explanation in description - Mel
> >
> > Signed-off-by: Minchan Kim <minchan@kernel.org>
>
> Hmm, page->index is valid only when the page is the head of buddy chunk ?
Yes.
>
> Anyway,
>
> Acked-by: KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com>
Thanks, Kame!
--
Kind regards,
Minchan Kim
next prev parent reply other threads:[~2012-09-07 0:06 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-09-06 5:16 [PATCH v2 0/3] memory-hotplug: handle page race between allocation and isolation Minchan Kim
2012-09-06 5:16 ` Minchan Kim
2012-09-06 5:16 ` [PATCH v2 1/3] use get_page_migratetype instead of page_private Minchan Kim
2012-09-06 5:16 ` Minchan Kim
2012-09-06 6:06 ` Kamezawa Hiroyuki
2012-09-06 6:06 ` Kamezawa Hiroyuki
2012-09-06 5:16 ` [PATCH v2 2/3] mm: remain migratetype in freed page Minchan Kim
2012-09-06 5:16 ` Minchan Kim
2012-09-06 6:13 ` Kamezawa Hiroyuki
2012-09-06 6:13 ` Kamezawa Hiroyuki
2012-09-07 0:08 ` Minchan Kim [this message]
2012-09-07 0:08 ` Minchan Kim
2012-09-06 5:16 ` [PATCH v2 3/3] memory-hotplug: bug fix race between isolation and allocation Minchan Kim
2012-09-06 5:16 ` Minchan Kim
2012-09-06 6:18 ` Kamezawa Hiroyuki
2012-09-06 6:18 ` Kamezawa Hiroyuki
2012-09-06 7:17 ` Yasuaki Ishimatsu
2012-09-06 7:17 ` Yasuaki Ishimatsu
2012-09-06 7:30 ` Minchan Kim
2012-09-06 7:30 ` Minchan Kim
2012-09-06 9:14 ` Yasuaki Ishimatsu
2012-09-06 9:14 ` Yasuaki Ishimatsu
2012-09-06 23:37 ` Minchan Kim
2012-09-06 23:37 ` Minchan Kim
2012-09-07 3:47 ` Yasuaki Ishimatsu
2012-09-07 3:47 ` Yasuaki Ishimatsu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120907000827.GF16231@bbox \
--to=minchan@kernel.org \
--cc=akpm@linux-foundation.org \
--cc=isimatu.yasuaki@jp.fujitsu.com \
--cc=kamezawa.hiroyu@jp.fujitsu.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mgorman@suse.de \
--cc=qiuxishi@huawei.com \
--cc=wency@cn.fujitsu.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.