All of lore.kernel.org
 help / color / mirror / Atom feed
From: Fengguang Wu <fengguang.wu@intel.com>
To: kernel-janitors@vger.kernel.org
Subject: Re: [mac80211-next:wip 56/57] net/mac80211/mlme.c:903:43: warning: 'chan_pwr' may be used uninitiali
Date: Fri, 07 Sep 2012 01:41:25 +0000	[thread overview]
Message-ID: <20120907014125.GA9047@localhost> (raw)
In-Reply-To: <1DC40B07CD6EC041A66726C271A73AE6195AD1CC@IRSMSX102.ger.corp.intel.com>

On Thu, Sep 06, 2012 at 11:00:01PM +0800, Berg, Johannes wrote:
> Hi,
> 
> Thanks.
> 
> > net/mac80211/mlme.c: In function 'ieee80211_rx_mgmt_beacon':
> > net/mac80211/mlme.c:903:43: warning: 'chan_pwr' may be used uninitialized
> > in this function [-Wmaybe-uninitialized]
> > net/mac80211/mlme.c:871:6: note: 'chan_pwr' was declared here
> 
> I think this is a false positive? It's only used if have_chan_pwr is true, and that's set only if chan_pwr is set.

Yes..many of the compiler warnings are false ones. They are sent out
anyway because I believe it's good practice to just quiet *all* gcc
warnings.

Would you apply the followed fix?

Thanks,
Fengguang

  reply	other threads:[~2012-09-07  1:41 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-09-06 15:00 [mac80211-next:wip 56/57] net/mac80211/mlme.c:903:43: warning: 'chan_pwr' may be used uninitiali Berg, Johannes
2012-09-07  1:41 ` Fengguang Wu [this message]
2012-09-07  7:40 ` Berg, Johannes
2012-09-07  7:49 ` Fengguang Wu
2012-09-07  7:51 ` Berg, Johannes

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20120907014125.GA9047@localhost \
    --to=fengguang.wu@intel.com \
    --cc=kernel-janitors@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.