Re: [mac80211-next:wip 56/57] net/mac80211/mlme.c:903:43: warning: 'chan_pwr' may be used uninitiali

[Fengguang Wu <fengguang.wu@intel.com>]

On Fri, Sep 07, 2012 at 03:40:41PM +0800, Berg, Johannes wrote:
> > > > net/mac80211/mlme.c: In function 'ieee80211_rx_mgmt_beacon':
> > > > net/mac80211/mlme.c:903:43: warning: 'chan_pwr' may be used
> > > > uninitialized in this function [-Wmaybe-uninitialized]
> > > > net/mac80211/mlme.c:871:6: note: 'chan_pwr' was declared here
> > >
> > > I think this is a false positive? It's only used if have_chan_pwr is true, and
> > that's set only if chan_pwr is set.
> > 
> > Yes..many of the compiler warnings are false ones. They are sent out anyway
> > because I believe it's good practice to just quiet *all* gcc warnings.
> > 
> > Would you apply the followed fix?
> 
> No. I don't believe that we should arbitrarily shut up gcc warnings
> by doing things like this as it may very well shut up legitimate
> warnings in the future.

Yes, it's now all good and there are ups and downs..

> Also, newer gccs (like my 4.7.1) don't warn
> here.

I'm also running gcc 4.7.1 and it's behavior is a bit interesting:
make allmodconfig is fine while this particular config will trigger
the false warning ;)

Thanks,
Fengguang