Re: [PATCH 5/5] omap-serial: Request pins using pinctrl framework

All of lore.kernel.org
 help / color / mirror / Atom feed

From: Tony Lindgren <tony@atomide.com>
To: "AnilKumar, Chimata" <anilkumar@ti.com>
Cc: "linux-arm-kernel@lists.infradead.org"
	<linux-arm-kernel@lists.infradead.org>,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	"linux-omap@vger.kernel.org" <linux-omap@vger.kernel.org>,
	"linux-serial@vger.kernel.org" <linux-serial@vger.kernel.org>
Subject: Re: [PATCH 5/5] omap-serial: Request pins using pinctrl framework
Date: Fri, 7 Sep 2012 11:03:36 -0700	[thread overview]
Message-ID: <20120907180335.GF1303@atomide.com> (raw)
In-Reply-To: <20120907172809.GB1303@atomide.com>

* Tony Lindgren <tony@atomide.com> [120907 10:29]:
> * AnilKumar, Chimata <anilkumar@ti.com> [120906 20:27]:
> > > @@ -1570,6 +1578,8 @@ static int serial_omap_remove(struct platform_device *dev)
> > >  		pm_runtime_disable(&up->pdev->dev);
> > >  		uart_remove_one_port(&serial_omap_reg, &up->port);
> > >  		pm_qos_remove_request(&up->pm_qos_request);
> > > +		if (up->pins)
> > > +			pinctrl_put(up->pins);
> > 
> > I think this can be removed if we use devm_pinctrl_get_select_default()
> > above.
> 
> Yeah will do, I was initially thinking that would cause issues remuxing
> pins back to safe mode on unload, but we can still do that in
> serial_omap_remove().

Sent now as a separate patch with subject "[PATCH] serial: omap: Request
pins using pinctrl framework".

Regards,

Tony

WARNING: multiple messages have this Message-ID (diff)

From: tony@atomide.com (Tony Lindgren)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 5/5] omap-serial: Request pins using pinctrl framework
Date: Fri, 7 Sep 2012 11:03:36 -0700	[thread overview]
Message-ID: <20120907180335.GF1303@atomide.com> (raw)
In-Reply-To: <20120907172809.GB1303@atomide.com>

* Tony Lindgren <tony@atomide.com> [120907 10:29]:
> * AnilKumar, Chimata <anilkumar@ti.com> [120906 20:27]:
> > > @@ -1570,6 +1578,8 @@ static int serial_omap_remove(struct platform_device *dev)
> > >  		pm_runtime_disable(&up->pdev->dev);
> > >  		uart_remove_one_port(&serial_omap_reg, &up->port);
> > >  		pm_qos_remove_request(&up->pm_qos_request);
> > > +		if (up->pins)
> > > +			pinctrl_put(up->pins);
> > 
> > I think this can be removed if we use devm_pinctrl_get_select_default()
> > above.
> 
> Yeah will do, I was initially thinking that would cause issues remuxing
> pins back to safe mode on unload, but we can still do that in
> serial_omap_remove().

Sent now as a separate patch with subject "[PATCH] serial: omap: Request
pins using pinctrl framework".

Regards,

Tony

next prev parent reply	other threads:[~2012-09-07 18:03 UTC|newest]

Thread overview: 30+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-09-06 18:58 [PATCH 0/5] Enable pinctrl-single for omap2/3/4 Tony Lindgren
2012-09-06 18:58 ` Tony Lindgren
2012-09-06 18:58 ` [PATCH 1/5] arm/dts: Add omap36xx.dtsi file and rename omap3-beagle to omap3-beagle-xm Tony Lindgren
2012-09-06 18:58   ` Tony Lindgren
2012-09-07 15:49   ` Benoit Cousson
2012-09-07 15:49     ` Benoit Cousson
2012-09-06 18:58 ` [PATCH 2/5] arm/dts: Add pinctrl driver entries for omap2/3/4 Tony Lindgren
2012-09-06 18:58   ` Tony Lindgren
2012-09-07  8:10   ` Linus Walleij
2012-09-07  8:10     ` Linus Walleij
2012-09-06 18:58 ` [PATCH 3/5] ARM: OMAP2+: select PINCTRL in Kconfig Tony Lindgren
2012-09-06 18:58   ` Tony Lindgren
2012-09-06 18:58 ` [PATCH 4/5] arm/dts: Mux uart pins for omap4-sdp Tony Lindgren
2012-09-06 18:58   ` Tony Lindgren
2012-09-06 18:58 ` [PATCH 5/5] omap-serial: Request pins using pinctrl framework Tony Lindgren
2012-09-06 18:58   ` Tony Lindgren
2012-09-06 19:12   ` Tony Lindgren
2012-09-06 19:12     ` Tony Lindgren
2012-09-06 19:56   ` Felipe Balbi
2012-09-06 19:56     ` Felipe Balbi
2012-09-06 21:17     ` Tony Lindgren
2012-09-06 21:17       ` Tony Lindgren
2012-09-07  5:26       ` Felipe Balbi
2012-09-07  5:26         ` Felipe Balbi
2012-09-07  3:27   ` AnilKumar, Chimata
2012-09-07  3:27     ` AnilKumar, Chimata
2012-09-07 17:28     ` Tony Lindgren
2012-09-07 17:28       ` Tony Lindgren
2012-09-07 18:03       ` Tony Lindgren [this message]
2012-09-07 18:03         ` Tony Lindgren

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20120907180335.GF1303@atomide.com \
    --to=tony@atomide.com \
    --cc=anilkumar@ti.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-omap@vger.kernel.org \
    --cc=linux-serial@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Be sure your reply has a Subject: header at the top and a blank line before the message body.

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.