From: andrew@lunn.ch (Andrew Lunn)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 2/2] ARM: kirkwood: Use devicetree to define DNS-32[05] fan
Date: Fri, 7 Sep 2012 23:23:31 +0200 [thread overview]
Message-ID: <20120907212331.GF21036@lunn.ch> (raw)
In-Reply-To: <1347035675-23907-3-git-send-email-jm@lentin.co.uk>
> diff --git a/arch/arm/mach-kirkwood/board-dnskw.c b/arch/arm/mach-kirkwood/board-dnskw.c
> index 4ab3506..e202a07 100644
> --- a/arch/arm/mach-kirkwood/board-dnskw.c
> +++ b/arch/arm/mach-kirkwood/board-dnskw.c
> @@ -67,29 +67,6 @@ static unsigned int dnskw_mpp_config[] __initdata = {
> 0
> };
>
> -/* Fan: ADDA AD045HB-G73 40mm 6000rpm at 5v */
> -static struct gpio_fan_speed dnskw_fan_speed[] = {
> - { 0, 0 },
> - { 3000, 1 },
> - { 6000, 2 },
> -};
> -static unsigned dnskw_fan_pins[] = {46, 45};
> -
> -static struct gpio_fan_platform_data dnskw_fan_data = {
> - .num_ctrl = ARRAY_SIZE(dnskw_fan_pins),
> - .ctrl = dnskw_fan_pins,
> - .num_speed = ARRAY_SIZE(dnskw_fan_speed),
> - .speed = dnskw_fan_speed,
> -};
> -
> -static struct platform_device dnskw_fan_device = {
> - .name = "gpio-fan",
> - .id = -1,
> - .dev = {
> - .platform_data = &dnskw_fan_data,
> - },
> -};
> -
> static void dnskw_power_off(void)
> {
> gpio_set_value(36, 1);
> @@ -114,8 +91,6 @@ void __init dnskw_init(void)
> kirkwood_ehci_init();
> kirkwood_ge00_init(&dnskw_ge00_data);
>
> - platform_device_register(&dnskw_fan_device);
> -
> /* Register power-off GPIO. */
> if (gpio_request(36, "dnskw:power:off") == 0
> && gpio_direction_output(36, 0) == 0)
> --
> 1.7.10.4
>
Hi Jamie
Minor point. I expect you can remove the header file gpio-fan.h.
There are also a few other headers files which can be removed, but i
suggest you do this in a separate cleanup patch. I think
ata_platform.h, input.h, leds.h, map.h, bridge-regs.h and maybe also
kirkwood.h are no longer needed.
Andrew
WARNING: multiple messages have this Message-ID (diff)
From: Andrew Lunn <andrew-g2DYL2Zd6BY@public.gmane.org>
To: Jamie Lentin <jm-Pj/HzkgeCk7QXOPxS62xeg@public.gmane.org>
Cc: Andrew Lunn <andrew-g2DYL2Zd6BY@public.gmane.org>,
Jason Cooper <jason-NLaQJdtUoK4Be96aLqz0jA@public.gmane.org>,
devicetree-discuss-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org,
Rob Herring <rob.herring-bsGFqQB8/DxBDgjK7y7TUQ@public.gmane.org>,
linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org,
Jean Delvare <khali-PUYAD+kWke1g9hUCZPvPmw@public.gmane.org>,
Guenter Roeck <linux-0h96xk9xTtrk1uMJSBkQmQ@public.gmane.org>
Subject: Re: [PATCH 2/2] ARM: kirkwood: Use devicetree to define DNS-32[05] fan
Date: Fri, 7 Sep 2012 23:23:31 +0200 [thread overview]
Message-ID: <20120907212331.GF21036@lunn.ch> (raw)
In-Reply-To: <1347035675-23907-3-git-send-email-jm-Pj/HzkgeCk7QXOPxS62xeg@public.gmane.org>
> diff --git a/arch/arm/mach-kirkwood/board-dnskw.c b/arch/arm/mach-kirkwood/board-dnskw.c
> index 4ab3506..e202a07 100644
> --- a/arch/arm/mach-kirkwood/board-dnskw.c
> +++ b/arch/arm/mach-kirkwood/board-dnskw.c
> @@ -67,29 +67,6 @@ static unsigned int dnskw_mpp_config[] __initdata = {
> 0
> };
>
> -/* Fan: ADDA AD045HB-G73 40mm 6000rpm@5v */
> -static struct gpio_fan_speed dnskw_fan_speed[] = {
> - { 0, 0 },
> - { 3000, 1 },
> - { 6000, 2 },
> -};
> -static unsigned dnskw_fan_pins[] = {46, 45};
> -
> -static struct gpio_fan_platform_data dnskw_fan_data = {
> - .num_ctrl = ARRAY_SIZE(dnskw_fan_pins),
> - .ctrl = dnskw_fan_pins,
> - .num_speed = ARRAY_SIZE(dnskw_fan_speed),
> - .speed = dnskw_fan_speed,
> -};
> -
> -static struct platform_device dnskw_fan_device = {
> - .name = "gpio-fan",
> - .id = -1,
> - .dev = {
> - .platform_data = &dnskw_fan_data,
> - },
> -};
> -
> static void dnskw_power_off(void)
> {
> gpio_set_value(36, 1);
> @@ -114,8 +91,6 @@ void __init dnskw_init(void)
> kirkwood_ehci_init();
> kirkwood_ge00_init(&dnskw_ge00_data);
>
> - platform_device_register(&dnskw_fan_device);
> -
> /* Register power-off GPIO. */
> if (gpio_request(36, "dnskw:power:off") == 0
> && gpio_direction_output(36, 0) == 0)
> --
> 1.7.10.4
>
Hi Jamie
Minor point. I expect you can remove the header file gpio-fan.h.
There are also a few other headers files which can be removed, but i
suggest you do this in a separate cleanup patch. I think
ata_platform.h, input.h, leds.h, map.h, bridge-regs.h and maybe also
kirkwood.h are no longer needed.
Andrew
next prev parent reply other threads:[~2012-09-07 21:23 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-09-07 16:34 [PATCH 0/2] hwmon: kirkwood: Add DT bindings to gpio-fan for DNS-32[05] Jamie Lentin
2012-09-07 16:34 ` Jamie Lentin
2012-09-07 16:34 ` [PATCH 1/2] hwmon: Add devicetree bindings to gpio-fan Jamie Lentin
2012-09-07 16:34 ` Jamie Lentin
2012-09-07 18:36 ` Guenter Roeck
2012-09-07 18:36 ` Guenter Roeck
2012-09-08 7:32 ` Andrew Lunn
2012-09-08 7:32 ` Andrew Lunn
2012-09-07 16:34 ` [PATCH 2/2] ARM: kirkwood: Use devicetree to define DNS-32[05] fan Jamie Lentin
2012-09-07 16:34 ` Jamie Lentin
2012-09-07 21:23 ` Andrew Lunn [this message]
2012-09-07 21:23 ` Andrew Lunn
2012-09-10 13:51 ` [PATCH V2 0/2] hwmon: kirkwood: Add DT bindings to gpio-fan for DNS-32[05] Jamie Lentin
2012-09-10 13:51 ` Jamie Lentin
2012-09-10 13:51 ` [PATCH V2 1/2] hwmon: Add devicetree bindings to gpio-fan Jamie Lentin
2012-09-10 13:51 ` Jamie Lentin
2012-09-10 15:28 ` Andrew Lunn
2012-09-10 15:28 ` Andrew Lunn
2012-09-10 16:04 ` Jamie Lentin
2012-09-10 16:04 ` Jamie Lentin
2012-09-10 18:15 ` Jason Cooper
2012-09-10 18:15 ` Jason Cooper
2012-09-10 18:49 ` Guenter Roeck
2012-09-10 18:49 ` Guenter Roeck
2012-09-14 16:07 ` [PATCH V3 " Jamie Lentin
2012-09-14 16:07 ` Jamie Lentin
2012-09-15 2:28 ` Guenter Roeck
2012-09-15 2:28 ` Guenter Roeck
2012-09-15 3:16 ` Jason Cooper
2012-09-15 3:16 ` Jason Cooper
2012-09-10 13:51 ` [PATCH V2 2/2] ARM: kirkwood: Use devicetree to define DNS-32[05] fan Jamie Lentin
2012-09-10 13:51 ` Jamie Lentin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120907212331.GF21036@lunn.ch \
--to=andrew@lunn.ch \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.