All of lore.kernel.org
 help / color / mirror / Atom feed
From: Tony Lindgren <tony@atomide.com>
To: Peter Ujfalusi <peter.ujfalusi@ti.com>
Cc: Benoit Cousson <b-cousson@ti.com>,
	linux-omap@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
	devicetree-discuss@lists.ozlabs.org
Subject: Re: [PATCH v3 1/8] ARM/dts: omap2: Add McBSP entries for OMAP2420 and OMAP2430 SoC
Date: Fri, 7 Sep 2012 15:29:54 -0700	[thread overview]
Message-ID: <20120907222953.GS1303@atomide.com> (raw)
In-Reply-To: <1346846336-27321-2-git-send-email-peter.ujfalusi@ti.com>

* Peter Ujfalusi <peter.ujfalusi@ti.com> [120905 04:59]:
> +
> +	ocp {
> +		mcbsp1: mcbsp@48074000 {
> +			compatible = "ti,omap2420-mcbsp";
> +			reg = <0x48074000 0xff>;
> +			reg-names = "mpu";
> +			interrupts = <59>, /* TX interrupt */
> +				     <60>; /* RX interrupt */
> +			interrupt-names = "tx", "rx";
> +			interrupt-parent = <&intc>;
> +			ti,hwmods = "mcbsp1";
> +		};
> +
> +		mcbsp2: mcbsp@48076000 {
> +			compatible = "ti,omap2420-mcbsp";
> +			reg = <0x48076000 0xff>;
> +			reg-names = "mpu";
> +			interrupts = <62>, /* TX interrupt */
> +				     <63>; /* RX interrupt */
> +			interrupt-names = "tx", "rx";
> +			interrupt-parent = <&intc>;
> +			ti,hwmods = "mcbsp2";
> +		};
> +	};

Hmm don't you need to specify the interrupt chip and offset for
the interrupts here?

Regards,

Tony

WARNING: multiple messages have this Message-ID (diff)
From: tony@atomide.com (Tony Lindgren)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v3 1/8] ARM/dts: omap2: Add McBSP entries for OMAP2420 and OMAP2430 SoC
Date: Fri, 7 Sep 2012 15:29:54 -0700	[thread overview]
Message-ID: <20120907222953.GS1303@atomide.com> (raw)
In-Reply-To: <1346846336-27321-2-git-send-email-peter.ujfalusi@ti.com>

* Peter Ujfalusi <peter.ujfalusi@ti.com> [120905 04:59]:
> +
> +	ocp {
> +		mcbsp1: mcbsp at 48074000 {
> +			compatible = "ti,omap2420-mcbsp";
> +			reg = <0x48074000 0xff>;
> +			reg-names = "mpu";
> +			interrupts = <59>, /* TX interrupt */
> +				     <60>; /* RX interrupt */
> +			interrupt-names = "tx", "rx";
> +			interrupt-parent = <&intc>;
> +			ti,hwmods = "mcbsp1";
> +		};
> +
> +		mcbsp2: mcbsp at 48076000 {
> +			compatible = "ti,omap2420-mcbsp";
> +			reg = <0x48076000 0xff>;
> +			reg-names = "mpu";
> +			interrupts = <62>, /* TX interrupt */
> +				     <63>; /* RX interrupt */
> +			interrupt-names = "tx", "rx";
> +			interrupt-parent = <&intc>;
> +			ti,hwmods = "mcbsp2";
> +		};
> +	};

Hmm don't you need to specify the interrupt chip and offset for
the interrupts here?

Regards,

Tony

  reply	other threads:[~2012-09-07 22:29 UTC|newest]

Thread overview: 26+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-09-05 11:58 [PATCH v3 0/8] ARM/dts: OMAP audio related updates for OMAP2/3/4/5 Peter Ujfalusi
2012-09-05 11:58 ` Peter Ujfalusi
2012-09-05 11:58 ` [PATCH v3 1/8] ARM/dts: omap2: Add McBSP entries for OMAP2420 and OMAP2430 SoC Peter Ujfalusi
2012-09-05 11:58   ` Peter Ujfalusi
2012-09-07 22:29   ` Tony Lindgren [this message]
2012-09-07 22:29     ` Tony Lindgren
2012-09-10  8:07     ` Benoit Cousson
2012-09-10  8:07       ` Benoit Cousson
2012-09-10 11:05       ` Peter Ujfalusi
2012-09-10 11:05         ` Peter Ujfalusi
2012-09-10 16:01         ` Tony Lindgren
2012-09-10 16:01           ` Tony Lindgren
2012-09-05 11:58 ` [PATCH v3 2/8] ARM/dts: omap2420-h4: Include omap2420.dtsi file instead the common omap2 Peter Ujfalusi
2012-09-05 11:58   ` Peter Ujfalusi
2012-09-05 11:58 ` [PATCH v3 3/8] ARM/dts: omap3: Add McBSP entries Peter Ujfalusi
2012-09-05 11:58   ` Peter Ujfalusi
2012-09-05 11:58 ` [PATCH v3 4/8] ARM/dts: omap4: " Peter Ujfalusi
2012-09-05 11:58   ` Peter Ujfalusi
2012-09-05 11:58 ` [PATCH v3 5/8] ARM/dts: omap4: Add reg-names for McPDM and DMIC Peter Ujfalusi
2012-09-05 11:58   ` Peter Ujfalusi
2012-09-05 11:58 ` [PATCH v3 6/8] ARM/dts: omap5: Add McBSP entries Peter Ujfalusi
2012-09-05 11:58   ` Peter Ujfalusi
2012-09-05 11:58 ` [PATCH v3 7/8] ARM/dts: omap5: Add McPDM and DMIC section to the dtsi file Peter Ujfalusi
2012-09-05 11:58   ` Peter Ujfalusi
2012-09-05 11:58 ` [PATCH v3 8/8] ARM/dts: omap3-beagle: Enable audio support Peter Ujfalusi
2012-09-05 11:58   ` Peter Ujfalusi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20120907222953.GS1303@atomide.com \
    --to=tony@atomide.com \
    --cc=b-cousson@ti.com \
    --cc=devicetree-discuss@lists.ozlabs.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-omap@vger.kernel.org \
    --cc=peter.ujfalusi@ti.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.