From: Minchan Kim <minchan@kernel.org>
To: Mel Gorman <mgorman@suse.de>
Cc: Andrew Morton <akpm@linux-foundation.org>,
linux-mm@kvack.org, linux-kernel@vger.kernel.org,
Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>,
Marek Szyprowski <m.szyprowski@samsung.com>,
Michal Nazarewicz <mina86@mina86.com>,
Rik van Riel <riel@redhat.com>
Subject: Re: [PATCH 2/2] mm: support MIGRATE_DISCARD
Date: Sat, 8 Sep 2012 09:16:43 +0900 [thread overview]
Message-ID: <20120908001643.GA2538@barrios> (raw)
In-Reply-To: <20120907093203.GX11266@suse.de>
On Fri, Sep 07, 2012 at 10:32:03AM +0100, Mel Gorman wrote:
> On Fri, Sep 07, 2012 at 09:21:45AM +0100, Mel Gorman wrote:
> >
> > So other than the mix up of order parameters I think this should work.
> >
>
> But I'd be wrong, isolated page accounting is not fixed up so it will
> eventually hang on too_many_isolated. It turns out it is necessary
Good spot.
> to pass in zone after all. The following patch passed a high order
> allocation stress test. To actually exercise the path I had compaction
> call reclaim_clean_pages_from_list() in a separate debugging patch.
>
> Minchan, can you test your CMA allocation latency test with this patch?
> If the figures are satisfactory could you add them to the changelog and
> consider replacing the MIGRATE_DISCARD pair of patches with this version
> please?
Of course, I will do next week.
Thanks!
--
Kind Regards,
Minchan Kim
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
WARNING: multiple messages have this Message-ID (diff)
From: Minchan Kim <minchan@kernel.org>
To: Mel Gorman <mgorman@suse.de>
Cc: Andrew Morton <akpm@linux-foundation.org>,
linux-mm@kvack.org, linux-kernel@vger.kernel.org,
Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>,
Marek Szyprowski <m.szyprowski@samsung.com>,
Michal Nazarewicz <mina86@mina86.com>,
Rik van Riel <riel@redhat.com>
Subject: Re: [PATCH 2/2] mm: support MIGRATE_DISCARD
Date: Sat, 8 Sep 2012 09:16:43 +0900 [thread overview]
Message-ID: <20120908001643.GA2538@barrios> (raw)
In-Reply-To: <20120907093203.GX11266@suse.de>
On Fri, Sep 07, 2012 at 10:32:03AM +0100, Mel Gorman wrote:
> On Fri, Sep 07, 2012 at 09:21:45AM +0100, Mel Gorman wrote:
> >
> > So other than the mix up of order parameters I think this should work.
> >
>
> But I'd be wrong, isolated page accounting is not fixed up so it will
> eventually hang on too_many_isolated. It turns out it is necessary
Good spot.
> to pass in zone after all. The following patch passed a high order
> allocation stress test. To actually exercise the path I had compaction
> call reclaim_clean_pages_from_list() in a separate debugging patch.
>
> Minchan, can you test your CMA allocation latency test with this patch?
> If the figures are satisfactory could you add them to the changelog and
> consider replacing the MIGRATE_DISCARD pair of patches with this version
> please?
Of course, I will do next week.
Thanks!
--
Kind Regards,
Minchan Kim
next prev parent reply other threads:[~2012-09-08 0:16 UTC|newest]
Thread overview: 40+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-09-05 8:11 [PATCH 1/2] mm: change enum migrate_mode with bitwise type Minchan Kim
2012-09-05 8:11 ` Minchan Kim
2012-09-05 8:11 ` [PATCH 2/2] mm: support MIGRATE_DISCARD Minchan Kim
2012-09-05 8:11 ` Minchan Kim
2012-09-05 10:56 ` Mel Gorman
2012-09-05 10:56 ` Mel Gorman
2012-09-06 5:31 ` Minchan Kim
2012-09-06 5:31 ` Minchan Kim
2012-09-06 8:29 ` Mel Gorman
2012-09-06 8:29 ` Mel Gorman
2012-09-06 9:03 ` Mel Gorman
2012-09-06 9:03 ` Mel Gorman
2012-09-07 0:57 ` Kyungmin Park
2012-09-07 0:57 ` Kyungmin Park
2012-09-07 2:26 ` Minchan Kim
2012-09-07 2:26 ` Minchan Kim
2012-09-07 8:10 ` Mel Gorman
2012-09-07 8:10 ` Mel Gorman
2012-09-07 2:24 ` Minchan Kim
2012-09-07 2:24 ` Minchan Kim
2012-09-07 5:57 ` Kyungmin Park
2012-09-07 5:57 ` Kyungmin Park
2012-09-07 7:31 ` Kyungmin Park
2012-09-07 7:31 ` Kyungmin Park
2012-09-07 8:17 ` Minchan Kim
2012-09-07 8:17 ` Minchan Kim
2012-09-07 8:57 ` Kyungmin Park
2012-09-07 8:57 ` Kyungmin Park
2012-09-07 8:21 ` Mel Gorman
2012-09-07 8:21 ` Mel Gorman
2012-09-07 9:32 ` Mel Gorman
2012-09-07 9:32 ` Mel Gorman
2012-09-08 0:16 ` Minchan Kim [this message]
2012-09-08 0:16 ` Minchan Kim
2012-09-05 12:43 ` Michal Nazarewicz
2012-09-05 12:43 ` Michal Nazarewicz
2012-12-21 13:04 ` lihanhui
2012-12-21 13:04 ` lihanhui
2012-09-05 12:41 ` [PATCH 1/2] mm: change enum migrate_mode with bitwise type Michal Nazarewicz
2012-09-05 12:41 ` Michal Nazarewicz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120908001643.GA2538@barrios \
--to=minchan@kernel.org \
--cc=akpm@linux-foundation.org \
--cc=b.zolnierkie@samsung.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=m.szyprowski@samsung.com \
--cc=mgorman@suse.de \
--cc=mina86@mina86.com \
--cc=riel@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.