All of lore.kernel.org
 help / color / mirror / Atom feed
From: David Teigland <teigland@redhat.com>
To: cluster-devel.redhat.com
Subject: [Cluster-devel] [PATCH] dlm: check the maximum size of a request from user
Date: Mon, 10 Sep 2012 11:43:37 -0400	[thread overview]
Message-ID: <20120910154337.GA1474@redhat.com> (raw)
In-Reply-To: <1347200218-3697-1-git-send-email-levinsasha928@gmail.com>

On Sun, Sep 09, 2012 at 04:16:58PM +0200, Sasha Levin wrote:
> device_write only checks whether the request size is big enough, but it doesn't
> check if the size is too big.
> 
> At that point, it also tries to allocate as much memory as the user has requested
> even if it's too much. This can lead to OOM killer kicking in, or memory corruption
> if (count + 1) overflows.

thanks, pushed to next



WARNING: multiple messages have this Message-ID (diff)
From: David Teigland <teigland@redhat.com>
To: Sasha Levin <levinsasha928@gmail.com>
Cc: ccaulfie@redhat.com, cluster-devel@redhat.com,
	linux-kernel@vger.kernel.org, davej@redhat.com
Subject: Re: [PATCH] dlm: check the maximum size of a request from user
Date: Mon, 10 Sep 2012 11:43:37 -0400	[thread overview]
Message-ID: <20120910154337.GA1474@redhat.com> (raw)
In-Reply-To: <1347200218-3697-1-git-send-email-levinsasha928@gmail.com>

On Sun, Sep 09, 2012 at 04:16:58PM +0200, Sasha Levin wrote:
> device_write only checks whether the request size is big enough, but it doesn't
> check if the size is too big.
> 
> At that point, it also tries to allocate as much memory as the user has requested
> even if it's too much. This can lead to OOM killer kicking in, or memory corruption
> if (count + 1) overflows.

thanks, pushed to next


  reply	other threads:[~2012-09-10 15:43 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-09-09 14:16 [PATCH] dlm: check the maximum size of a request from user Sasha Levin
2012-09-10 15:43 ` David Teigland [this message]
2012-09-10 15:43   ` David Teigland

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20120910154337.GA1474@redhat.com \
    --to=teigland@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.