From: Matt Porter <mporter-l0cyMroinI0@public.gmane.org>
To: Benoit Cousson <b-cousson-l0cyMroinI0@public.gmane.org>
Cc: Devicetree Discuss
<devicetree-discuss-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org>,
Linux Kernel Mailing List
<linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
Linux OMAP List
<linux-omap-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
Linux ARM Kernel List
<linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org>
Subject: Re: [PATCH] ARM: dts: AM33XX: fix gpio node numbering to match hardware
Date: Mon, 10 Sep 2012 12:52:10 -0400 [thread overview]
Message-ID: <20120910165210.GJ27758@beef> (raw)
In-Reply-To: <504E168C.6060603-l0cyMroinI0@public.gmane.org>
On Mon, Sep 10, 2012 at 06:34:20PM +0200, Benoit Cousson wrote:
> + Tony
>
> Hi Matt,
>
> 30 minutes too late for my pull request :-(
>
> There are a couple of am33xx patches under discussion, so I'll take them
> and send a for_3.7/dts-part2 pull request if this is not too late for Tony.
Yeah, believe me, I did a faceplant when I saw your pull request come by
at the same time I discovered this issue. ;) In particular, AnilKumar's
user leds patch would need to be adjusted for this change. I can
resubmit with the user leds dts changes adjusted as well if that
discussion comes to a conclusion and his patches accepted.
> On 09/10/2012 06:20 PM, Matt Porter wrote:
> > On AM33xx, the datasheet and TRM refer to four GPIO instances that
> > are 0-based, GPIO0-3.
>
> Or maybe you should just update the spec to use a 1-based GPIO number
> like OMAP :-)
I am powerless here. :)
-Matt
> > Signed-off-by: Matt Porter <mporter-l0cyMroinI0@public.gmane.org>
> > ---
> > arch/arm/boot/dts/am33xx.dtsi | 8 ++++----
> > 1 file changed, 4 insertions(+), 4 deletions(-)
> >
> > diff --git a/arch/arm/boot/dts/am33xx.dtsi b/arch/arm/boot/dts/am33xx.dtsi
> > index bb31bff..1369bfc 100644
> > --- a/arch/arm/boot/dts/am33xx.dtsi
> > +++ b/arch/arm/boot/dts/am33xx.dtsi
> > @@ -62,7 +62,7 @@
> > reg = <0x48200000 0x1000>;
> > };
> >
> > - gpio1: gpio@44e07000 {
> > + gpio0: gpio@44e07000 {
> > compatible = "ti,omap4-gpio";
> > ti,hwmods = "gpio1";
> > gpio-controller;
> > @@ -74,7 +74,7 @@
> > interrupts = <96>;
> > };
> >
> > - gpio2: gpio@4804c000 {
> > + gpio1: gpio@4804c000 {
> > compatible = "ti,omap4-gpio";
> > ti,hwmods = "gpio2";
> > gpio-controller;
> > @@ -86,7 +86,7 @@
> > interrupts = <98>;
> > };
> >
> > - gpio3: gpio@481ac000 {
> > + gpio2: gpio@481ac000 {
> > compatible = "ti,omap4-gpio";
> > ti,hwmods = "gpio3";
> > gpio-controller;
> > @@ -98,7 +98,7 @@
> > interrupts = <32>;
> > };
> >
> > - gpio4: gpio@481ae000 {
> > + gpio3: gpio@481ae000 {
> > compatible = "ti,omap4-gpio";
> > ti,hwmods = "gpio4";
> > gpio-controller;
> >
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-omap" in
> the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
WARNING: multiple messages have this Message-ID (diff)
From: mporter@ti.com (Matt Porter)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] ARM: dts: AM33XX: fix gpio node numbering to match hardware
Date: Mon, 10 Sep 2012 12:52:10 -0400 [thread overview]
Message-ID: <20120910165210.GJ27758@beef> (raw)
In-Reply-To: <504E168C.6060603@ti.com>
On Mon, Sep 10, 2012 at 06:34:20PM +0200, Benoit Cousson wrote:
> + Tony
>
> Hi Matt,
>
> 30 minutes too late for my pull request :-(
>
> There are a couple of am33xx patches under discussion, so I'll take them
> and send a for_3.7/dts-part2 pull request if this is not too late for Tony.
Yeah, believe me, I did a faceplant when I saw your pull request come by
at the same time I discovered this issue. ;) In particular, AnilKumar's
user leds patch would need to be adjusted for this change. I can
resubmit with the user leds dts changes adjusted as well if that
discussion comes to a conclusion and his patches accepted.
> On 09/10/2012 06:20 PM, Matt Porter wrote:
> > On AM33xx, the datasheet and TRM refer to four GPIO instances that
> > are 0-based, GPIO0-3.
>
> Or maybe you should just update the spec to use a 1-based GPIO number
> like OMAP :-)
I am powerless here. :)
-Matt
> > Signed-off-by: Matt Porter <mporter@ti.com>
> > ---
> > arch/arm/boot/dts/am33xx.dtsi | 8 ++++----
> > 1 file changed, 4 insertions(+), 4 deletions(-)
> >
> > diff --git a/arch/arm/boot/dts/am33xx.dtsi b/arch/arm/boot/dts/am33xx.dtsi
> > index bb31bff..1369bfc 100644
> > --- a/arch/arm/boot/dts/am33xx.dtsi
> > +++ b/arch/arm/boot/dts/am33xx.dtsi
> > @@ -62,7 +62,7 @@
> > reg = <0x48200000 0x1000>;
> > };
> >
> > - gpio1: gpio at 44e07000 {
> > + gpio0: gpio at 44e07000 {
> > compatible = "ti,omap4-gpio";
> > ti,hwmods = "gpio1";
> > gpio-controller;
> > @@ -74,7 +74,7 @@
> > interrupts = <96>;
> > };
> >
> > - gpio2: gpio at 4804c000 {
> > + gpio1: gpio at 4804c000 {
> > compatible = "ti,omap4-gpio";
> > ti,hwmods = "gpio2";
> > gpio-controller;
> > @@ -86,7 +86,7 @@
> > interrupts = <98>;
> > };
> >
> > - gpio3: gpio at 481ac000 {
> > + gpio2: gpio at 481ac000 {
> > compatible = "ti,omap4-gpio";
> > ti,hwmods = "gpio3";
> > gpio-controller;
> > @@ -98,7 +98,7 @@
> > interrupts = <32>;
> > };
> >
> > - gpio4: gpio at 481ae000 {
> > + gpio3: gpio at 481ae000 {
> > compatible = "ti,omap4-gpio";
> > ti,hwmods = "gpio4";
> > gpio-controller;
> >
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-omap" in
> the body of a message to majordomo at vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
WARNING: multiple messages have this Message-ID (diff)
From: Matt Porter <mporter@ti.com>
To: Benoit Cousson <b-cousson@ti.com>
Cc: Linux OMAP List <linux-omap@vger.kernel.org>,
Linux ARM Kernel List <linux-arm-kernel@lists.infradead.org>,
Devicetree Discuss <devicetree-discuss@lists.ozlabs.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Vaibhav Hiremath <hvaibhav@ti.com>,
"tony@atomide.com" <tony@atomide.com>
Subject: Re: [PATCH] ARM: dts: AM33XX: fix gpio node numbering to match hardware
Date: Mon, 10 Sep 2012 12:52:10 -0400 [thread overview]
Message-ID: <20120910165210.GJ27758@beef> (raw)
In-Reply-To: <504E168C.6060603@ti.com>
On Mon, Sep 10, 2012 at 06:34:20PM +0200, Benoit Cousson wrote:
> + Tony
>
> Hi Matt,
>
> 30 minutes too late for my pull request :-(
>
> There are a couple of am33xx patches under discussion, so I'll take them
> and send a for_3.7/dts-part2 pull request if this is not too late for Tony.
Yeah, believe me, I did a faceplant when I saw your pull request come by
at the same time I discovered this issue. ;) In particular, AnilKumar's
user leds patch would need to be adjusted for this change. I can
resubmit with the user leds dts changes adjusted as well if that
discussion comes to a conclusion and his patches accepted.
> On 09/10/2012 06:20 PM, Matt Porter wrote:
> > On AM33xx, the datasheet and TRM refer to four GPIO instances that
> > are 0-based, GPIO0-3.
>
> Or maybe you should just update the spec to use a 1-based GPIO number
> like OMAP :-)
I am powerless here. :)
-Matt
> > Signed-off-by: Matt Porter <mporter@ti.com>
> > ---
> > arch/arm/boot/dts/am33xx.dtsi | 8 ++++----
> > 1 file changed, 4 insertions(+), 4 deletions(-)
> >
> > diff --git a/arch/arm/boot/dts/am33xx.dtsi b/arch/arm/boot/dts/am33xx.dtsi
> > index bb31bff..1369bfc 100644
> > --- a/arch/arm/boot/dts/am33xx.dtsi
> > +++ b/arch/arm/boot/dts/am33xx.dtsi
> > @@ -62,7 +62,7 @@
> > reg = <0x48200000 0x1000>;
> > };
> >
> > - gpio1: gpio@44e07000 {
> > + gpio0: gpio@44e07000 {
> > compatible = "ti,omap4-gpio";
> > ti,hwmods = "gpio1";
> > gpio-controller;
> > @@ -74,7 +74,7 @@
> > interrupts = <96>;
> > };
> >
> > - gpio2: gpio@4804c000 {
> > + gpio1: gpio@4804c000 {
> > compatible = "ti,omap4-gpio";
> > ti,hwmods = "gpio2";
> > gpio-controller;
> > @@ -86,7 +86,7 @@
> > interrupts = <98>;
> > };
> >
> > - gpio3: gpio@481ac000 {
> > + gpio2: gpio@481ac000 {
> > compatible = "ti,omap4-gpio";
> > ti,hwmods = "gpio3";
> > gpio-controller;
> > @@ -98,7 +98,7 @@
> > interrupts = <32>;
> > };
> >
> > - gpio4: gpio@481ae000 {
> > + gpio3: gpio@481ae000 {
> > compatible = "ti,omap4-gpio";
> > ti,hwmods = "gpio4";
> > gpio-controller;
> >
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-omap" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2012-09-10 16:52 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-09-10 16:20 [PATCH] ARM: dts: AM33XX: fix gpio node numbering to match hardware Matt Porter
2012-09-10 16:20 ` Matt Porter
[not found] ` <1347294020-22661-1-git-send-email-mporter-l0cyMroinI0@public.gmane.org>
2012-09-10 16:34 ` Benoit Cousson
2012-09-10 16:34 ` Benoit Cousson
2012-09-10 16:34 ` Benoit Cousson
[not found] ` <504E168C.6060603-l0cyMroinI0@public.gmane.org>
2012-09-10 16:52 ` Matt Porter [this message]
2012-09-10 16:52 ` Matt Porter
2012-09-10 16:52 ` Matt Porter
2012-09-10 16:59 ` Benoit Cousson
2012-09-10 16:59 ` Benoit Cousson
2012-09-10 16:59 ` Benoit Cousson
2012-09-10 19:51 ` Matt Porter
2012-09-10 19:51 ` Matt Porter
[not found] ` <504E1C69.30602-l0cyMroinI0@public.gmane.org>
2012-09-11 5:00 ` Hiremath, Vaibhav
2012-09-11 5:00 ` Hiremath, Vaibhav
2012-09-11 5:00 ` Hiremath, Vaibhav
2012-09-10 17:03 ` Tony Lindgren
2012-09-10 17:03 ` Tony Lindgren
2012-09-11 4:57 ` Hiremath, Vaibhav
2012-09-11 4:57 ` Hiremath, Vaibhav
2012-09-11 4:57 ` Hiremath, Vaibhav
2012-09-11 11:29 ` Matt Porter
2012-09-11 11:29 ` Matt Porter
2012-09-11 11:30 ` Hiremath, Vaibhav
2012-09-11 11:30 ` Hiremath, Vaibhav
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120910165210.GJ27758@beef \
--to=mporter-l0cymroini0@public.gmane.org \
--cc=b-cousson-l0cyMroinI0@public.gmane.org \
--cc=devicetree-discuss-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org \
--cc=linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org \
--cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-omap-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.