From: Greg KH <gregkh@linuxfoundation.org>
To: Huang Shijie <b32955@freescale.com>
Cc: alan@linux.intel.com, linux-serial@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, shawn.guo@linaro.org
Subject: Re: [PATCH] serial: mxs-auart: put the device when exit or error
Date: Mon, 10 Sep 2012 16:00:05 -0700 [thread overview]
Message-ID: <20120910230005.GA15782@kroah.com> (raw)
In-Reply-To: <1346985187-30459-1-git-send-email-b32955@freescale.com>
On Fri, Sep 07, 2012 at 10:33:07AM +0800, Huang Shijie wrote:
> We call the get_device() in the mxs_auart_probe().
> For the balance of the reference count, we should put the
> device in the mxs_auart_remove() or in the error path of
> probe.
>
> Signed-off-by: Huang Shijie <b32955@freescale.com>
> ---
> drivers/tty/serial/mxs-auart.c | 2 ++
> 1 files changed, 2 insertions(+), 0 deletions(-)
I already applied the previous version, so can you make up a patch
against the tty-next tree that fixes it up properly based on this patch?
thanks,
greg k-h
WARNING: multiple messages have this Message-ID (diff)
From: gregkh@linuxfoundation.org (Greg KH)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] serial: mxs-auart: put the device when exit or error
Date: Mon, 10 Sep 2012 16:00:05 -0700 [thread overview]
Message-ID: <20120910230005.GA15782@kroah.com> (raw)
In-Reply-To: <1346985187-30459-1-git-send-email-b32955@freescale.com>
On Fri, Sep 07, 2012 at 10:33:07AM +0800, Huang Shijie wrote:
> We call the get_device() in the mxs_auart_probe().
> For the balance of the reference count, we should put the
> device in the mxs_auart_remove() or in the error path of
> probe.
>
> Signed-off-by: Huang Shijie <b32955@freescale.com>
> ---
> drivers/tty/serial/mxs-auart.c | 2 ++
> 1 files changed, 2 insertions(+), 0 deletions(-)
I already applied the previous version, so can you make up a patch
against the tty-next tree that fixes it up properly based on this patch?
thanks,
greg k-h
next prev parent reply other threads:[~2012-09-10 23:00 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-09-07 2:38 [PATCH 1/2] serial: mxs-auart: fix the wrong setting order Huang Shijie
2012-09-07 2:38 ` Huang Shijie
2012-09-07 2:38 ` [PATCH 2/2] serial: mxs-auart: put the device in mxs_auart_probe() Huang Shijie
2012-09-07 2:38 ` Huang Shijie
2012-09-07 2:43 ` Shawn Guo
2012-09-07 2:43 ` Shawn Guo
2012-09-07 2:33 ` [PATCH] serial: mxs-auart: put the device when exit or error Huang Shijie
2012-09-07 2:33 ` Huang Shijie
2012-09-07 2:33 ` Huang Shijie
2012-09-07 3:14 ` Shawn Guo
2012-09-07 3:14 ` Shawn Guo
2012-09-10 23:00 ` Greg KH [this message]
2012-09-10 23:00 ` Greg KH
2012-09-11 7:30 ` [PATCH] serial: mxs-auart: put the device in the error path Huang Shijie
2012-09-07 2:48 ` [PATCH 2/2] serial: mxs-auart: put the device in mxs_auart_probe() Huang Shijie
2012-09-07 2:48 ` Huang Shijie
2012-09-07 2:48 ` Huang Shijie
2012-09-07 2:38 ` [PATCH 1/2] serial: mxs-auart: fix the wrong setting order Shawn Guo
2012-09-07 2:38 ` Shawn Guo
2012-09-07 2:43 ` Huang Shijie
2012-09-07 2:43 ` Huang Shijie
2012-09-07 2:43 ` Huang Shijie
2012-09-13 5:28 ` Lauri Hintsala
2012-09-13 5:28 ` Lauri Hintsala
2012-09-13 5:45 ` Huang Shijie
2012-09-13 5:45 ` Huang Shijie
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120910230005.GA15782@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=alan@linux.intel.com \
--cc=b32955@freescale.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
--cc=shawn.guo@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.