From: Fengguang Wu <fengguang.wu@intel.com>
To: Sebastian Andrzej Siewior
<bigeasy-hfZtesqFncYOwBW4kG4KsQ@public.gmane.org>
Cc: kernel-janitors-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
Felipe Balbi <balbi-l0cyMroinI0@public.gmane.org>,
linux-omap-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-usb-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
Dan Carpenter
<dan.carpenter-QHcLZuEGTsvQT0dZR+AlfA@public.gmane.org>
Subject: Re: [balbi-usb:master 33/36] drivers/usb/gadget/serial.c:89:22: sparse: cast truncates bits from con
Date: Tue, 11 Sep 2012 10:55:00 +0000 [thread overview]
Message-ID: <20120911105500.GA1244@localhost> (raw)
In-Reply-To: <504E1DCB.3000003-hfZtesqFncYOwBW4kG4KsQ@public.gmane.org>
On Mon, Sep 10, 2012 at 07:05:15PM +0200, Sebastian Andrzej Siewior wrote:
> On 09/10/2012 06:40 PM, Fengguang Wu wrote:
> >tree: git://git.kernel.org/pub/scm/linux/kernel/git/balbi/usb.git master
> >head: d9c88901337158c9f253a7de58a10b5125d61d26
> >commit: 7a7322b0a5d984025dd4faea9098b8fef07f8d8f [33/36] usb: gadget: remove usb_gadget_controller_number()
> >
> >All sparse warnings:
>
> Once again, thank you.
You are welcome!
> > drivers/usb/gadget/f_acm.c:287:9: sparse: advancing past deep designator
> > drivers/usb/gadget/f_obex.c:60:9: sparse: advancing past deep designator
> > drivers/usb/gadget/f_serial.c:134:9: sparse: advancing past deep designator
> > drivers/usb/gadget/serial.c:66:9: sparse: advancing past deep designator
>
> I don't get these. The purpose is an all NULL terminating entry. Could
> this be a sparse bug or is the [] / {} switch not really good C code?
http://marc.info/?l=linux-sparse&m\x130673652023059&w=4
According to Dan's explanations, I'll filter out these warnings in future.
> >+ drivers/usb/gadget/serial.c:89:22: sparse: cast truncates bits from constant value (24000000 becomes 0)
>
> I've sent a patch for this.
Thank you!
Fengguang
WARNING: multiple messages have this Message-ID (diff)
From: Fengguang Wu <fengguang.wu-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
To: Sebastian Andrzej Siewior
<bigeasy-hfZtesqFncYOwBW4kG4KsQ@public.gmane.org>
Cc: kernel-janitors-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
Felipe Balbi <balbi-l0cyMroinI0@public.gmane.org>,
linux-omap-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-usb-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
Dan Carpenter
<dan.carpenter-QHcLZuEGTsvQT0dZR+AlfA@public.gmane.org>
Subject: Re: [balbi-usb:master 33/36] drivers/usb/gadget/serial.c:89:22: sparse: cast truncates bits from constant value (24000000 becomes 0)
Date: Tue, 11 Sep 2012 18:55:00 +0800 [thread overview]
Message-ID: <20120911105500.GA1244@localhost> (raw)
In-Reply-To: <504E1DCB.3000003-hfZtesqFncYOwBW4kG4KsQ@public.gmane.org>
On Mon, Sep 10, 2012 at 07:05:15PM +0200, Sebastian Andrzej Siewior wrote:
> On 09/10/2012 06:40 PM, Fengguang Wu wrote:
> >tree: git://git.kernel.org/pub/scm/linux/kernel/git/balbi/usb.git master
> >head: d9c88901337158c9f253a7de58a10b5125d61d26
> >commit: 7a7322b0a5d984025dd4faea9098b8fef07f8d8f [33/36] usb: gadget: remove usb_gadget_controller_number()
> >
> >All sparse warnings:
>
> Once again, thank you.
You are welcome!
> > drivers/usb/gadget/f_acm.c:287:9: sparse: advancing past deep designator
> > drivers/usb/gadget/f_obex.c:60:9: sparse: advancing past deep designator
> > drivers/usb/gadget/f_serial.c:134:9: sparse: advancing past deep designator
> > drivers/usb/gadget/serial.c:66:9: sparse: advancing past deep designator
>
> I don't get these. The purpose is an all NULL terminating entry. Could
> this be a sparse bug or is the [] / {} switch not really good C code?
http://marc.info/?l=linux-sparse&m=130673652023059&w=4
According to Dan's explanations, I'll filter out these warnings in future.
> >+ drivers/usb/gadget/serial.c:89:22: sparse: cast truncates bits from constant value (24000000 becomes 0)
>
> I've sent a patch for this.
Thank you!
Fengguang
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2012-09-11 10:55 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-09-10 16:40 [balbi-usb:master 33/36] drivers/usb/gadget/serial.c:89:22: sparse: cast truncates bits from constan Fengguang Wu
2012-09-10 16:40 ` [balbi-usb:master 33/36] drivers/usb/gadget/serial.c:89:22: sparse: cast truncates bits from constant value (24000000 becomes 0) Fengguang Wu
2012-09-10 17:05 ` [balbi-usb:master 33/36] drivers/usb/gadget/serial.c:89:22: sparse: cast truncates bits from con Sebastian Andrzej Siewior
2012-09-10 17:05 ` [balbi-usb:master 33/36] drivers/usb/gadget/serial.c:89:22: sparse: cast truncates bits from constant value (24000000 becomes 0) Sebastian Andrzej Siewior
[not found] ` <504E1DCB.3000003-hfZtesqFncYOwBW4kG4KsQ@public.gmane.org>
2012-09-11 10:55 ` Fengguang Wu [this message]
2012-09-11 10:55 ` Fengguang Wu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120911105500.GA1244@localhost \
--to=fengguang.wu@intel.com \
--cc=balbi-l0cyMroinI0@public.gmane.org \
--cc=bigeasy-hfZtesqFncYOwBW4kG4KsQ@public.gmane.org \
--cc=dan.carpenter-QHcLZuEGTsvQT0dZR+AlfA@public.gmane.org \
--cc=kernel-janitors-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-omap-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-usb-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.