From: "Kirill A. Shutemov" <kirill@shutemov.name>
To: Will Deacon <will.deacon@arm.com>
Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org,
linux-arch@vger.kernel.org, akpm@linux-foundation.org,
mhocko@suse.cz, Catalin Marinas <catalin.marinas@arm.com>,
Arnd Bergmann <arnd@arndb.de>,
Steve Capper <steve.capper@arm.com>
Subject: Re: [PATCH 1/3] mm: thp: Fix the pmd_clear() arguments in pmdp_get_and_clear()
Date: Tue, 11 Sep 2012 20:12:15 +0300 [thread overview]
Message-ID: <20120911171215.GA29664@shutemov.name> (raw)
In-Reply-To: <1347382036-18455-2-git-send-email-will.deacon@arm.com>
On Tue, Sep 11, 2012 at 05:47:14PM +0100, Will Deacon wrote:
> From: Catalin Marinas <catalin.marinas@arm.com>
>
> The CONFIG_TRANSPARENT_HUGEPAGE implementation of pmdp_get_and_clear()
> calls pmd_clear() with 3 arguments instead of 1.
>
> Cc: Arnd Bergmann <arnd@arndb.de>
> Signed-off-by: Catalin Marinas <catalin.marinas@arm.com>
> Signed-off-by: Steve Capper <steve.capper@arm.com>
> Signed-off-by: Will Deacon <will.deacon@arm.com>
Reviewed-by: Kirill A. Shutemov <kirill@shutemov.name>
> ---
> include/asm-generic/pgtable.h | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/include/asm-generic/pgtable.h b/include/asm-generic/pgtable.h
> index ff4947b..f7e0206 100644
> --- a/include/asm-generic/pgtable.h
> +++ b/include/asm-generic/pgtable.h
> @@ -87,7 +87,7 @@ static inline pmd_t pmdp_get_and_clear(struct mm_struct *mm,
> pmd_t *pmdp)
> {
> pmd_t pmd = *pmdp;
> - pmd_clear(mm, address, pmdp);
> + pmd_clear(pmdp);
> return pmd;
> }
> #endif /* CONFIG_TRANSPARENT_HUGEPAGE */
> --
> 1.7.4.1
>
> --
> To unsubscribe, send a message with 'unsubscribe linux-mm' in
> the body to majordomo@kvack.org. For more info on Linux MM,
> see: http://www.linux-mm.org/ .
> Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
--
Kirill A. Shutemov
WARNING: multiple messages have this Message-ID (diff)
From: "Kirill A. Shutemov" <kirill@shutemov.name>
To: Will Deacon <will.deacon@arm.com>
Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org,
linux-arch@vger.kernel.org, akpm@linux-foundation.org,
mhocko@suse.cz, Catalin Marinas <catalin.marinas@arm.com>,
Arnd Bergmann <arnd@arndb.de>,
Steve Capper <steve.capper@arm.com>
Subject: Re: [PATCH 1/3] mm: thp: Fix the pmd_clear() arguments in pmdp_get_and_clear()
Date: Tue, 11 Sep 2012 20:12:15 +0300 [thread overview]
Message-ID: <20120911171215.GA29664@shutemov.name> (raw)
In-Reply-To: <1347382036-18455-2-git-send-email-will.deacon@arm.com>
On Tue, Sep 11, 2012 at 05:47:14PM +0100, Will Deacon wrote:
> From: Catalin Marinas <catalin.marinas@arm.com>
>
> The CONFIG_TRANSPARENT_HUGEPAGE implementation of pmdp_get_and_clear()
> calls pmd_clear() with 3 arguments instead of 1.
>
> Cc: Arnd Bergmann <arnd@arndb.de>
> Signed-off-by: Catalin Marinas <catalin.marinas@arm.com>
> Signed-off-by: Steve Capper <steve.capper@arm.com>
> Signed-off-by: Will Deacon <will.deacon@arm.com>
Reviewed-by: Kirill A. Shutemov <kirill@shutemov.name>
> ---
> include/asm-generic/pgtable.h | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/include/asm-generic/pgtable.h b/include/asm-generic/pgtable.h
> index ff4947b..f7e0206 100644
> --- a/include/asm-generic/pgtable.h
> +++ b/include/asm-generic/pgtable.h
> @@ -87,7 +87,7 @@ static inline pmd_t pmdp_get_and_clear(struct mm_struct *mm,
> pmd_t *pmdp)
> {
> pmd_t pmd = *pmdp;
> - pmd_clear(mm, address, pmdp);
> + pmd_clear(pmdp);
> return pmd;
> }
> #endif /* CONFIG_TRANSPARENT_HUGEPAGE */
> --
> 1.7.4.1
>
> --
> To unsubscribe, send a message with 'unsubscribe linux-mm' in
> the body to majordomo@kvack.org. For more info on Linux MM,
> see: http://www.linux-mm.org/ .
> Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
--
Kirill A. Shutemov
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2012-09-11 17:12 UTC|newest]
Thread overview: 54+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-09-11 16:47 [PATCH 0/3] Minor changes to common hugetlb code for ARM Will Deacon
2012-09-11 16:47 ` Will Deacon
2012-09-11 16:47 ` [PATCH 1/3] mm: thp: Fix the pmd_clear() arguments in pmdp_get_and_clear() Will Deacon
2012-09-11 16:47 ` Will Deacon
2012-09-11 17:12 ` Kirill A. Shutemov [this message]
2012-09-11 17:12 ` Kirill A. Shutemov
2012-09-12 15:30 ` Michal Hocko
2012-09-12 15:30 ` Michal Hocko
2012-09-11 16:47 ` [PATCH 2/3] mm: thp: Fix the update_mmu_cache() last argument passing in mm/huge_memory.c Will Deacon
2012-09-11 16:47 ` Will Deacon
2012-09-11 17:38 ` Kirill A. Shutemov
2012-09-11 17:38 ` Kirill A. Shutemov
2012-09-12 15:40 ` Michal Hocko
2012-09-12 15:40 ` Michal Hocko
2012-09-12 15:51 ` Catalin Marinas
2012-09-12 15:51 ` Catalin Marinas
2012-09-15 13:38 ` Ralf Baechle
2012-09-15 13:38 ` Ralf Baechle
2012-09-18 19:33 ` Andrew Morton
2012-09-18 19:33 ` Andrew Morton
2012-09-19 9:12 ` Catalin Marinas
2012-09-19 9:12 ` Catalin Marinas
2012-09-19 15:53 ` Ralf Baechle
2012-09-19 15:53 ` Ralf Baechle
2012-09-20 12:44 ` Will Deacon
2012-09-20 12:44 ` Will Deacon
2012-09-20 19:32 ` David Miller
2012-09-20 19:32 ` David Miller
2012-09-11 16:47 ` [PATCH 3/3] mm: Introduce HAVE_ARCH_TRANSPARENT_HUGEPAGE Will Deacon
2012-09-11 16:47 ` Will Deacon
2012-09-11 17:41 ` Kirill A. Shutemov
2012-09-11 17:41 ` Kirill A. Shutemov
2012-09-12 15:32 ` Michal Hocko
2012-09-12 15:32 ` Michal Hocko
2012-09-12 18:06 ` Chris Metcalf
2012-09-12 18:06 ` Chris Metcalf
2012-09-12 18:06 ` Chris Metcalf
2012-09-12 18:10 ` Will Deacon
2012-09-12 18:10 ` Will Deacon
2012-09-13 19:05 ` Andrew Morton
2012-09-13 19:05 ` Andrew Morton
2012-09-13 21:26 ` Will Deacon
2012-09-13 21:26 ` Will Deacon
2012-09-13 21:27 ` Stephen Rothwell
2012-09-13 21:40 ` Andrew Morton
2012-09-13 21:40 ` Andrew Morton
2012-09-12 15:27 ` [PATCH 0/3] Minor changes to common hugetlb code for ARM Michal Hocko
2012-09-12 15:27 ` Michal Hocko
2012-09-12 15:55 ` Will Deacon
2012-09-12 15:55 ` Will Deacon
2012-09-13 12:22 ` Michal Hocko
2012-09-13 12:22 ` Michal Hocko
2012-09-13 0:12 ` Andrea Arcangeli
2012-09-13 0:12 ` Andrea Arcangeli
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120911171215.GA29664@shutemov.name \
--to=kirill@shutemov.name \
--cc=akpm@linux-foundation.org \
--cc=arnd@arndb.de \
--cc=catalin.marinas@arm.com \
--cc=linux-arch@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mhocko@suse.cz \
--cc=steve.capper@arm.com \
--cc=will.deacon@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.