From: Anton Vorontsov <anton.vorontsov@linaro.org>
To: Alan Cox <alan@lxorguk.ukuu.org.uk>
Cc: "Andrew Morton" <akpm@linux-foundation.org>,
"Russell King" <linux@arm.linux.org.uk>,
"Jason Wessel" <jason.wessel@windriver.com>,
"Greg Kroah-Hartman" <gregkh@linuxfoundation.org>,
"Alan Cox" <alan@linux.intel.com>,
"Arve Hjønnevåg" <arve@android.com>,
"Colin Cross" <ccross@android.com>,
"Brian Swetland" <swetland@google.com>,
"John Stultz" <john.stultz@linaro.org>,
linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linaro-kernel@lists.linaro.org, patches@linaro.org,
kernel-team@android.com, kgdb-bugreport@lists.sourceforge.net,
linux-serial@vger.kernel.org
Subject: Re: [PATCH 08/12] tty/serial: Add kgdb_nmi driver
Date: Tue, 11 Sep 2012 17:41:25 -0700 [thread overview]
Message-ID: <20120912004125.GA19637@lizard> (raw)
In-Reply-To: <20120911151420.14a29485@pyramind.ukuu.org.uk>
On Tue, Sep 11, 2012 at 03:14:20PM +0100, Alan Cox wrote:
> > +struct kgdb_nmi_tty_priv {
> > + struct tty_port port;
> > + int opened;
> > + struct tasklet_struct tlet;
> > + STRUCT_KFIFO(char, KGDB_NMI_FIFO_SIZE) fifo;
>
> I don't see where "opened" is used.
Yup, a leftover, with tty_port no longer needed. Thanks for noticing.
> > +static const struct tty_operations kgdb_nmi_tty_ops = {
> > + .open = kgdb_nmi_tty_open,
> > + .close = kgdb_nmi_tty_close,
> > + .install = kgdb_nmi_tty_install,
> > + .cleanup = kgdb_nmi_tty_cleanup,
> > + .write_room = kgdb_nmi_tty_write_room,
> > + .write = kgdb_nmi_tty_write,
>
> And a hangup method (just using tty_port helpers will do the job - it's
> needed so vhangup() works as expected on a port)
Will add. Thanks a lot!
WARNING: multiple messages have this Message-ID (diff)
From: anton.vorontsov@linaro.org (Anton Vorontsov)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 08/12] tty/serial: Add kgdb_nmi driver
Date: Tue, 11 Sep 2012 17:41:25 -0700 [thread overview]
Message-ID: <20120912004125.GA19637@lizard> (raw)
In-Reply-To: <20120911151420.14a29485@pyramind.ukuu.org.uk>
On Tue, Sep 11, 2012 at 03:14:20PM +0100, Alan Cox wrote:
> > +struct kgdb_nmi_tty_priv {
> > + struct tty_port port;
> > + int opened;
> > + struct tasklet_struct tlet;
> > + STRUCT_KFIFO(char, KGDB_NMI_FIFO_SIZE) fifo;
>
> I don't see where "opened" is used.
Yup, a leftover, with tty_port no longer needed. Thanks for noticing.
> > +static const struct tty_operations kgdb_nmi_tty_ops = {
> > + .open = kgdb_nmi_tty_open,
> > + .close = kgdb_nmi_tty_close,
> > + .install = kgdb_nmi_tty_install,
> > + .cleanup = kgdb_nmi_tty_cleanup,
> > + .write_room = kgdb_nmi_tty_write_room,
> > + .write = kgdb_nmi_tty_write,
>
> And a hangup method (just using tty_port helpers will do the job - it's
> needed so vhangup() works as expected on a port)
Will add. Thanks a lot!
next prev parent reply other threads:[~2012-09-12 0:44 UTC|newest]
Thread overview: 51+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-09-11 9:30 [PATCH v6 0/12] KGDB/KDB FIQ (NMI) debugger Anton Vorontsov
2012-09-11 9:30 ` Anton Vorontsov
2012-09-11 9:34 ` [PATCH 01/12] kernel/debug: Mask KGDB NMI upon entry Anton Vorontsov
2012-09-11 9:34 ` Anton Vorontsov
2012-09-11 9:34 ` [PATCH 02/12] kdb: Implement disable_nmi command Anton Vorontsov
2012-09-11 9:34 ` Anton Vorontsov
2012-09-11 9:34 ` Anton Vorontsov
2012-09-11 9:34 ` [PATCH 03/12] kdb: Turn KGDB_KDB=n stubs into static inlines Anton Vorontsov
2012-09-11 9:34 ` Anton Vorontsov
2012-09-11 9:34 ` Anton Vorontsov
2012-09-11 9:34 ` [PATCH 04/12] tty/serial/core: Introduce poll_init callback Anton Vorontsov
2012-09-11 9:34 ` Anton Vorontsov
2012-09-11 9:34 ` [PATCH 05/12] tty/serial/amba-pl011: Implement " Anton Vorontsov
2012-09-11 9:34 ` Anton Vorontsov
2012-09-11 9:34 ` Anton Vorontsov
2012-09-11 9:35 ` [PATCH 06/12] tty/serial/kgdboc: Add and wire up clear_irqs callback Anton Vorontsov
2012-09-11 9:35 ` Anton Vorontsov
2012-09-11 14:15 ` Alan Cox
2012-09-11 14:15 ` Alan Cox
2012-09-12 3:32 ` [RFC] " Anton Vorontsov
2012-09-12 3:32 ` Anton Vorontsov
2012-09-12 3:42 ` Colin Cross
2012-09-12 3:42 ` Colin Cross
2012-09-12 4:06 ` Anton Vorontsov
2012-09-12 4:06 ` Anton Vorontsov
2012-09-12 4:40 ` Colin Cross
2012-09-12 4:40 ` Colin Cross
2012-09-12 7:01 ` Anton Vorontsov
2012-09-12 7:01 ` Anton Vorontsov
2012-09-12 9:44 ` Alan Cox
2012-09-12 9:44 ` Alan Cox
2012-09-12 10:32 ` Anton Vorontsov
2012-09-12 10:32 ` Anton Vorontsov
2012-09-11 9:35 ` [PATCH 07/12] tty/serial/amba-pl011: Implement " Anton Vorontsov
2012-09-11 9:35 ` Anton Vorontsov
2012-09-11 9:35 ` [PATCH 08/12] tty/serial: Add kgdb_nmi driver Anton Vorontsov
2012-09-11 9:35 ` Anton Vorontsov
2012-09-11 14:14 ` Alan Cox
2012-09-11 14:14 ` Alan Cox
2012-09-12 0:41 ` Anton Vorontsov [this message]
2012-09-12 0:41 ` Anton Vorontsov
2012-09-11 9:35 ` [PATCH 09/12] ARM: Move some macros from entry-armv to entry-header Anton Vorontsov
2012-09-11 9:35 ` Anton Vorontsov
2012-09-11 9:35 ` [PATCH 10/12] ARM: Add KGDB/KDB FIQ debugger generic code Anton Vorontsov
2012-09-11 9:35 ` Anton Vorontsov
2012-09-11 9:35 ` [PATCH 11/12] ARM: VIC: Add a couple of low-level FIQ management helpers Anton Vorontsov
2012-09-11 9:35 ` Anton Vorontsov
2012-09-11 9:35 ` [PATCH 12/12] ARM: versatile: Make able to use UART ports for KGDB FIQ debugger Anton Vorontsov
2012-09-11 9:35 ` Anton Vorontsov
-- strict thread matches above, loose matches on Subject: below --
2012-08-20 14:44 [PATCH v4 0/12] KGDB/KDB FIQ (NMI) debugger Anton Vorontsov
2012-08-20 14:47 ` [PATCH 08/12] tty/serial: Add kgdb_nmi driver Anton Vorontsov
2012-08-20 14:47 ` Anton Vorontsov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120912004125.GA19637@lizard \
--to=anton.vorontsov@linaro.org \
--cc=akpm@linux-foundation.org \
--cc=alan@linux.intel.com \
--cc=alan@lxorguk.ukuu.org.uk \
--cc=arve@android.com \
--cc=ccross@android.com \
--cc=gregkh@linuxfoundation.org \
--cc=jason.wessel@windriver.com \
--cc=john.stultz@linaro.org \
--cc=kernel-team@android.com \
--cc=kgdb-bugreport@lists.sourceforge.net \
--cc=linaro-kernel@lists.linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
--cc=linux@arm.linux.org.uk \
--cc=patches@linaro.org \
--cc=swetland@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.