From: Tony Lindgren <tony@atomide.com>
To: Vaibhav Hiremath <hvaibhav@ti.com>
Cc: linux-omap@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, paul@pwsan.com
Subject: Re: [PATCH 2/2] ARM: AM33XX: hwmod: Add OMAP_INTC_START offset to all module int nos
Date: Wed, 12 Sep 2012 14:52:32 -0700 [thread overview]
Message-ID: <20120912215232.GE5997@atomide.com> (raw)
In-Reply-To: <1347484551-11775-3-git-send-email-hvaibhav@ti.com>
* Vaibhav Hiremath <hvaibhav@ti.com> [120912 14:17]:
> With recent migration of omap architectures to SPARSE_IRQ framework,
> it is important to add OMAP_INTC_START to all interrupt numbers
> which will be eventually requested by drivers.
>
> This is required in order to get AM33XX boot functionality.
>
> Signed-off-by: Vaibhav Hiremath <hvaibhav@ti.com>
> Cc: Paul Walmsley <paul@pwsan.com>
> ---
> arch/arm/mach-omap2/omap_hwmod_33xx_data.c | 168 ++++++++++++++--------------
> 1 files changed, 84 insertions(+), 84 deletions(-)
>
> diff --git a/arch/arm/mach-omap2/omap_hwmod_33xx_data.c b/arch/arm/mach-omap2/omap_hwmod_33xx_data.c
> index 7b7ed08..3c320f4 100644
> --- a/arch/arm/mach-omap2/omap_hwmod_33xx_data.c
> +++ b/arch/arm/mach-omap2/omap_hwmod_33xx_data.c
You should just have on top of this file:
#define OMAP_INTC_START 0
Then Paul can apply this, and while merging with the sparseirq
changes, the above can be removed.
> @@ -72,7 +72,7 @@ static struct omap_hwmod_class am33xx_emif_hwmod_class = {
> };
>
> static struct omap_hwmod_irq_info am33xx_emif_irqs[] = {
> - { .name = "ddrerr0", .irq = 101 },
> + { .name = "ddrerr0", .irq = 101 + OMAP_INTC_START },
> { .irq = -1 }
> };
>
Then these should be fixed up to have trailing commas
as requested by Russell earlier on several occasions.
Regards,
Tony
WARNING: multiple messages have this Message-ID (diff)
From: tony@atomide.com (Tony Lindgren)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 2/2] ARM: AM33XX: hwmod: Add OMAP_INTC_START offset to all module int nos
Date: Wed, 12 Sep 2012 14:52:32 -0700 [thread overview]
Message-ID: <20120912215232.GE5997@atomide.com> (raw)
In-Reply-To: <1347484551-11775-3-git-send-email-hvaibhav@ti.com>
* Vaibhav Hiremath <hvaibhav@ti.com> [120912 14:17]:
> With recent migration of omap architectures to SPARSE_IRQ framework,
> it is important to add OMAP_INTC_START to all interrupt numbers
> which will be eventually requested by drivers.
>
> This is required in order to get AM33XX boot functionality.
>
> Signed-off-by: Vaibhav Hiremath <hvaibhav@ti.com>
> Cc: Paul Walmsley <paul@pwsan.com>
> ---
> arch/arm/mach-omap2/omap_hwmod_33xx_data.c | 168 ++++++++++++++--------------
> 1 files changed, 84 insertions(+), 84 deletions(-)
>
> diff --git a/arch/arm/mach-omap2/omap_hwmod_33xx_data.c b/arch/arm/mach-omap2/omap_hwmod_33xx_data.c
> index 7b7ed08..3c320f4 100644
> --- a/arch/arm/mach-omap2/omap_hwmod_33xx_data.c
> +++ b/arch/arm/mach-omap2/omap_hwmod_33xx_data.c
You should just have on top of this file:
#define OMAP_INTC_START 0
Then Paul can apply this, and while merging with the sparseirq
changes, the above can be removed.
> @@ -72,7 +72,7 @@ static struct omap_hwmod_class am33xx_emif_hwmod_class = {
> };
>
> static struct omap_hwmod_irq_info am33xx_emif_irqs[] = {
> - { .name = "ddrerr0", .irq = 101 },
> + { .name = "ddrerr0", .irq = 101 + OMAP_INTC_START },
> { .irq = -1 }
> };
>
Then these should be fixed up to have trailing commas
as requested by Russell earlier on several occasions.
Regards,
Tony
next prev parent reply other threads:[~2012-09-12 21:52 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-09-12 21:15 [PATCH 0/2] ARM: AM33XX: hwmod: Minor fixes for v3.7 Vaibhav Hiremath
2012-09-12 21:15 ` Vaibhav Hiremath
2012-09-12 21:15 ` Vaibhav Hiremath
2012-09-12 21:15 ` [PATCH 1/2] ARM: AM33XX: hwmod: Remove platform specific header files Vaibhav Hiremath
2012-09-12 21:15 ` Vaibhav Hiremath
2012-09-12 21:15 ` Vaibhav Hiremath
2012-09-12 21:54 ` Tony Lindgren
2012-09-12 21:54 ` Tony Lindgren
2012-09-12 21:15 ` [PATCH 2/2] ARM: AM33XX: hwmod: Add OMAP_INTC_START offset to all module int nos Vaibhav Hiremath
2012-09-12 21:15 ` Vaibhav Hiremath
2012-09-12 21:15 ` Vaibhav Hiremath
2012-09-12 21:52 ` Tony Lindgren [this message]
2012-09-12 21:52 ` Tony Lindgren
2012-09-12 22:02 ` Hiremath, Vaibhav
2012-09-12 22:02 ` Hiremath, Vaibhav
2012-09-12 23:38 ` Paul Walmsley
2012-09-12 23:38 ` Paul Walmsley
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120912215232.GE5997@atomide.com \
--to=tony@atomide.com \
--cc=hvaibhav@ti.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=paul@pwsan.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.