All of lore.kernel.org
 help / color / mirror / Atom feed
From: Dan Carpenter <dan.carpenter@oracle.com>
To: Vinod Koul <vinod.koul@linux.intel.com>
Cc: alsa-devel@alsa-project.org, Takashi Iwai <tiwai@suse.de>,
	kernel-janitors@vger.kernel.org,
	Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>,
	Jesper Juhl <jj@chaosbits.net>,
	Namarta Kohli <namartax.kohli@intel.com>
Subject: Re: [patch] ALSA: compress_core: integer overflow in snd_compr_allocate_buffer()
Date: Fri, 14 Sep 2012 12:35:27 +0300	[thread overview]
Message-ID: <20120914093527.GD4587@mwanda> (raw)
In-Reply-To: <1347614682.1943.35.camel@vkoul-udesk3>

On Fri, Sep 14, 2012 at 02:54:42PM +0530, Vinod Koul wrote:
> On Fri, 2012-09-14 at 11:06 +0200, Takashi Iwai wrote:
> > > So, we actually should have two distinct fixes.
> > 
> > I took Dan's patch now for next branch.  But it's still better to
> > filter weird parameters in the caller side, too.
> > 
> > Vinod, care to write such a patch and submit? 
> Yes am already on it :)
> 

Thanks.  I've had my text editor open to the file all week, but it
felt like there was probably a better limit to use than just what
would overflow...  I just don't know the code very well.  I'm glad
that Vinod is handling this.

regards,
dan carpenter

WARNING: multiple messages have this Message-ID (diff)
From: Dan Carpenter <dan.carpenter@oracle.com>
To: Vinod Koul <vinod.koul@linux.intel.com>
Cc: alsa-devel@alsa-project.org, Takashi Iwai <tiwai@suse.de>,
	kernel-janitors@vger.kernel.org,
	Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>,
	Jesper Juhl <jj@chaosbits.net>,
	Namarta Kohli <namartax.kohli@intel.com>
Subject: Re: [patch] ALSA: compress_core: integer overflow in snd_compr_allocate_buffer()
Date: Fri, 14 Sep 2012 09:35:27 +0000	[thread overview]
Message-ID: <20120914093527.GD4587@mwanda> (raw)
In-Reply-To: <1347614682.1943.35.camel@vkoul-udesk3>

On Fri, Sep 14, 2012 at 02:54:42PM +0530, Vinod Koul wrote:
> On Fri, 2012-09-14 at 11:06 +0200, Takashi Iwai wrote:
> > > So, we actually should have two distinct fixes.
> > 
> > I took Dan's patch now for next branch.  But it's still better to
> > filter weird parameters in the caller side, too.
> > 
> > Vinod, care to write such a patch and submit? 
> Yes am already on it :)
> 

Thanks.  I've had my text editor open to the file all week, but it
felt like there was probably a better limit to use than just what
would overflow...  I just don't know the code very well.  I'm glad
that Vinod is handling this.

regards,
dan carpenter


  parent reply	other threads:[~2012-09-14  9:35 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-09-05 12:32 [patch] ALSA: compress_core: integer overflow in snd_compr_allocate_buffer() Dan Carpenter
2012-09-05 12:32 ` Dan Carpenter
2012-09-05 13:40 ` Takashi Iwai
2012-09-05 13:40   ` Takashi Iwai
2012-09-06 14:59   ` Dan Carpenter
2012-09-06 14:59     ` Dan Carpenter
2012-09-06 15:19     ` Takashi Iwai
2012-09-06 15:19       ` Takashi Iwai
2012-09-14  9:06       ` Takashi Iwai
2012-09-14  9:06         ` Takashi Iwai
2012-09-14  9:24         ` Vinod Koul
2012-09-14  9:36           ` Vinod Koul
2012-09-14  9:28           ` Vinod Koul
2012-09-14  9:40             ` Vinod Koul
2012-09-14  9:45             ` Takashi Iwai
2012-09-14  9:45               ` Takashi Iwai
2012-09-14  9:49               ` Vinod Koul
2012-09-14  9:52                 ` Vinod Koul
2012-09-14 10:00                 ` Takashi Iwai
2012-09-14 10:00                   ` Takashi Iwai
2012-09-14  9:35           ` Dan Carpenter [this message]
2012-09-14  9:35             ` Dan Carpenter

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20120914093527.GD4587@mwanda \
    --to=dan.carpenter@oracle.com \
    --cc=alsa-devel@alsa-project.org \
    --cc=jj@chaosbits.net \
    --cc=kernel-janitors@vger.kernel.org \
    --cc=namartax.kohli@intel.com \
    --cc=pierre-louis.bossart@linux.intel.com \
    --cc=tiwai@suse.de \
    --cc=vinod.koul@linux.intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.