Re: [Qemu-devel] [PATCH] configure: fix "--target-list=<target>, <target>, ..." option

["Daniel P. Berrange" <berrange@redhat.com>]

On Fri, Sep 14, 2012 at 01:53:11PM +0100, Peter Maydell wrote:
> On 12 September 2012 14:20, Laurent Desnogues
> <laurent.desnogues@gmail.com> wrote:
> > Sorry, I had missed this patch...
> >
> > On Tue, Sep 11, 2012 at 9:02 PM, Eduardo Habkost <ehabkost@redhat.com> wrote:
> >> commit 66d5499b3754b83c09487259c08fe2ce73188a59 broke the support for
> >> comma-separated target lists on the --target-list option. e.g.:
> >>
> >>   $ ./configure --target-list=x86_64-linux-user,x86_64-softmmu
> >>   [...]
> >>   ERROR: Target 'x86_64-linux-user,x86_64-softmmu' not recognised
> >>   $
> >>
> >> This patch restores that ability.
> >>
> >> Signed-off-by: Eduardo Habkost <ehabkost@redhat.com>
> >> Cc: Daniel P. Berrange <berrange@redhat.com>
> >> Cc: Anthony Liguori <anthony@codemonkey.ws>
> >> ---
> >>  configure | 4 +++-
> >>  1 file changed, 3 insertions(+), 1 deletion(-)
> >>
> >> diff --git a/configure b/configure
> >> index 7656c32..9ee7038 100755
> >> --- a/configure
> >> +++ b/configure
> >> @@ -1323,7 +1323,9 @@ if ! "$python" -c 'import sys; sys.exit(sys.version_info < (2,4) or sys.version_
> >>  fi
> >>
> >>  if test "$target_list" = "DEFAULT" ; then
> >> -    target_list=`echo "$default_target_list" | sed -e 's/,/ /g'`
> >> +    target_list="$default_target_list"
> >> +else
> >> +    target_list=`echo "$target_list" | sed -e 's/,/ /g'`
> >>  fi
> >
> > This works for me too.
> >
> > But I still can't get what the original patch posted by
> > Daniel Berrange intended to do:
> >
> > $ ./configure --target-list=
> > $ make V=1
> > cat  | grep =y | sort -u > config-all-devices.mak
> >
> > And it of course hangs there.

Urgh, I see what went wrong. When I tested it, I still had a previously
generated 'config-all-devices.mak' so this broken rule never hit me.

When I 'git clean -f -x -d', then I see the same problem as you
descibe.

> Hmm. Perhaps we should just revert 66d5499b3 and then recommit
> a working implementation later?

Agreed, sorry for the screw up with this patch.

Daniel
-- 
|: http://berrange.com      -o-    http://www.flickr.com/photos/dberrange/ :|
|: http://libvirt.org              -o-             http://virt-manager.org :|
|: http://autobuild.org       -o-         http://search.cpan.org/~danberr/ :|
|: http://entangle-photo.org       -o-       http://live.gnome.org/gtk-vnc :|