[Qemu-devel] [PATCH v2] Add ability to disable build of all targets

[Qemu-devel] [PATCH v2] Add ability to disable build of all targets

[Daniel P. Berrange]

From: "Daniel P. Berrange" <berrange@redhat.com>

Allow passing of '--target-list=' to configure to request that
all targets are to be disabled. This allows for doing a very
fast tools-only build of things like qemu-img, qemu-io, qemu-nbd.

Signed-off-by: Daniel P. Berrange <berrange@redhat.com>
---
 configure | 13 ++++---------
 1 file changed, 4 insertions(+), 9 deletions(-)

diff --git a/configure b/configure
index 75dc9da..472374e 100755
--- a/configure
+++ b/configure
@@ -127,7 +127,7 @@ cc_i386=i386-pc-linux-gnu-gcc
 libs_qga=""
 debug_info="yes"
 
-target_list=""
+target_list="DEFAULT"
 
 # Default value for a variable defining feature "foo".
 #  * foo="no"  feature will only be used if --enable-foo arg is given
@@ -1319,15 +1319,10 @@ if ! "$python" -c 'import sys; sys.exit(sys.version_info < (2,4) or sys.version_
   exit 1
 fi
 
-if test -z "$target_list" ; then
-    target_list="$default_target_list"
-else
-    target_list=`echo "$target_list" | sed -e 's/,/ /g'`
-fi
-if test -z "$target_list" ; then
-    echo "No targets enabled"
-    exit 1
+if test "$target_list" = "DEFAULT" ; then
+    target_list=`echo "$default_target_list" | sed -e 's/,/ /g'`
 fi
+
 # see if system emulation was really requested
 case " $target_list " in
   *"-softmmu "*) softmmu=yes
-- 
1.7.11.2

Re: [Qemu-devel] [PATCH v2] Add ability to disable build of all targets

[Anthony Liguori]

"Daniel P. Berrange" <berrange@redhat.com> writes:

> From: "Daniel P. Berrange" <berrange@redhat.com>
>
> Allow passing of '--target-list=' to configure to request that
> all targets are to be disabled. This allows for doing a very
> fast tools-only build of things like qemu-img, qemu-io, qemu-nbd.
>
> Signed-off-by: Daniel P. Berrange <berrange@redhat.com>

Applied. Thanks.

Regards,

Anthony Liguori

> ---
>  configure | 13 ++++---------
>  1 file changed, 4 insertions(+), 9 deletions(-)
>
> diff --git a/configure b/configure
> index 75dc9da..472374e 100755
> --- a/configure
> +++ b/configure
> @@ -127,7 +127,7 @@ cc_i386=i386-pc-linux-gnu-gcc
>  libs_qga=""
>  debug_info="yes"
>  
> -target_list=""
> +target_list="DEFAULT"
>  
>  # Default value for a variable defining feature "foo".
>  #  * foo="no"  feature will only be used if --enable-foo arg is given
> @@ -1319,15 +1319,10 @@ if ! "$python" -c 'import sys; sys.exit(sys.version_info < (2,4) or sys.version_
>    exit 1
>  fi
>  
> -if test -z "$target_list" ; then
> -    target_list="$default_target_list"
> -else
> -    target_list=`echo "$target_list" | sed -e 's/,/ /g'`
> -fi
> -if test -z "$target_list" ; then
> -    echo "No targets enabled"
> -    exit 1
> +if test "$target_list" = "DEFAULT" ; then
> +    target_list=`echo "$default_target_list" | sed -e 's/,/ /g'`
>  fi
> +
>  # see if system emulation was really requested
>  case " $target_list " in
>    *"-softmmu "*) softmmu=yes
> -- 
> 1.7.11.2

Re: [Qemu-devel] [PATCH v2] Add ability to disable build of all targets

[Eduardo Habkost]

On Mon, Sep 10, 2012 at 06:00:54PM -0500, Anthony Liguori wrote:
> "Daniel P. Berrange" <berrange@redhat.com> writes:
> 
> > From: "Daniel P. Berrange" <berrange@redhat.com>
> >
> > Allow passing of '--target-list=' to configure to request that
> > all targets are to be disabled. This allows for doing a very
> > fast tools-only build of things like qemu-img, qemu-io, qemu-nbd.
> >
> > Signed-off-by: Daniel P. Berrange <berrange@redhat.com>
> 
> Applied. Thanks.

This patch broke the --target-list option:

  $ ./configure --target-list=x86_64-linux-user,x86_64-softmmu
  [...]
  ERROR: Target 'x86_64-linux-user,x86_64-softmmu' not recognised
  $ 

> 
> Regards,
> 
> Anthony Liguori
> 
> > ---
> >  configure | 13 ++++---------
> >  1 file changed, 4 insertions(+), 9 deletions(-)
> >
> > diff --git a/configure b/configure
> > index 75dc9da..472374e 100755
> > --- a/configure
> > +++ b/configure
> > @@ -127,7 +127,7 @@ cc_i386=i386-pc-linux-gnu-gcc
> >  libs_qga=""
> >  debug_info="yes"
> >  
> > -target_list=""
> > +target_list="DEFAULT"
> >  
> >  # Default value for a variable defining feature "foo".
> >  #  * foo="no"  feature will only be used if --enable-foo arg is given
> > @@ -1319,15 +1319,10 @@ if ! "$python" -c 'import sys; sys.exit(sys.version_info < (2,4) or sys.version_
> >    exit 1
> >  fi
> >  
> > -if test -z "$target_list" ; then
> > -    target_list="$default_target_list"
> > -else
> > -    target_list=`echo "$target_list" | sed -e 's/,/ /g'`
> > -fi
> > -if test -z "$target_list" ; then
> > -    echo "No targets enabled"
> > -    exit 1
> > +if test "$target_list" = "DEFAULT" ; then
> > +    target_list=`echo "$default_target_list" | sed -e 's/,/ /g'`
> >  fi
> > +
> >  # see if system emulation was really requested
> >  case " $target_list " in
> >    *"-softmmu "*) softmmu=yes
> > -- 
> > 1.7.11.2
> 

-- 
Eduardo

[Qemu-devel] [PATCH] configure: fix "--target-list=<target>, <target>, ..." option

[Eduardo Habkost]

commit 66d5499b3754b83c09487259c08fe2ce73188a59 broke the support for
comma-separated target lists on the --target-list option. e.g.:

  $ ./configure --target-list=x86_64-linux-user,x86_64-softmmu
  [...]
  ERROR: Target 'x86_64-linux-user,x86_64-softmmu' not recognised
  $

This patch restores that ability.

Signed-off-by: Eduardo Habkost <ehabkost@redhat.com>
Cc: Daniel P. Berrange <berrange@redhat.com>
Cc: Anthony Liguori <anthony@codemonkey.ws>
---
 configure | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/configure b/configure
index 7656c32..9ee7038 100755
--- a/configure
+++ b/configure
@@ -1323,7 +1323,9 @@ if ! "$python" -c 'import sys; sys.exit(sys.version_info < (2,4) or sys.version_
 fi
 
 if test "$target_list" = "DEFAULT" ; then
-    target_list=`echo "$default_target_list" | sed -e 's/,/ /g'`
+    target_list="$default_target_list"
+else
+    target_list=`echo "$target_list" | sed -e 's/,/ /g'`
 fi
 
 # see if system emulation was really requested
-- 
1.7.11.4

Re: [Qemu-devel] [PATCH] configure: fix "--target-list=<target>, <target>, ..." option

[Peter Crosthwaite]

On Wed, Sep 12, 2012 at 5:02 AM, Eduardo Habkost <ehabkost@redhat.com> wrote:
> commit 66d5499b3754b83c09487259c08fe2ce73188a59 broke the support for
> comma-separated target lists on the --target-list option. e.g.:
>
>   $ ./configure --target-list=x86_64-linux-user,x86_64-softmmu
>   [...]
>   ERROR: Target 'x86_64-linux-user,x86_64-softmmu' not recognised
>   $
>

Broke for me too. This patch fixes it.

> This patch restores that ability.
>
> Signed-off-by: Eduardo Habkost <ehabkost@redhat.com>

Tested-by: Peter Crosthwaite <peter.crosthwaite@petalogix.com>

> Cc: Daniel P. Berrange <berrange@redhat.com>
> Cc: Anthony Liguori <anthony@codemonkey.ws>
> ---
>  configure | 4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/configure b/configure
> index 7656c32..9ee7038 100755
> --- a/configure
> +++ b/configure
> @@ -1323,7 +1323,9 @@ if ! "$python" -c 'import sys; sys.exit(sys.version_info < (2,4) or sys.version_
>  fi
>
>  if test "$target_list" = "DEFAULT" ; then
> -    target_list=`echo "$default_target_list" | sed -e 's/,/ /g'`
> +    target_list="$default_target_list"
> +else
> +    target_list=`echo "$target_list" | sed -e 's/,/ /g'`
>  fi
>
>  # see if system emulation was really requested
> --
> 1.7.11.4
>
>

Re: [Qemu-devel] [PATCH] configure: fix "--target-list=<target>, <target>, ..." option

[Laurent Desnogues]

Sorry, I had missed this patch...

On Tue, Sep 11, 2012 at 9:02 PM, Eduardo Habkost <ehabkost@redhat.com> wrote:
> commit 66d5499b3754b83c09487259c08fe2ce73188a59 broke the support for
> comma-separated target lists on the --target-list option. e.g.:
>
>   $ ./configure --target-list=x86_64-linux-user,x86_64-softmmu
>   [...]
>   ERROR: Target 'x86_64-linux-user,x86_64-softmmu' not recognised
>   $
>
> This patch restores that ability.
>
> Signed-off-by: Eduardo Habkost <ehabkost@redhat.com>
> Cc: Daniel P. Berrange <berrange@redhat.com>
> Cc: Anthony Liguori <anthony@codemonkey.ws>
> ---
>  configure | 4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/configure b/configure
> index 7656c32..9ee7038 100755
> --- a/configure
> +++ b/configure
> @@ -1323,7 +1323,9 @@ if ! "$python" -c 'import sys; sys.exit(sys.version_info < (2,4) or sys.version_
>  fi
>
>  if test "$target_list" = "DEFAULT" ; then
> -    target_list=`echo "$default_target_list" | sed -e 's/,/ /g'`
> +    target_list="$default_target_list"
> +else
> +    target_list=`echo "$target_list" | sed -e 's/,/ /g'`
>  fi

This works for me too.

But I still can't get what the original patch posted by
Daniel Berrange intended to do:

$ ./configure --target-list=
$ make V=1
cat  | grep =y | sort -u > config-all-devices.mak

And it of course hangs there.

Creating an empty config-all-devices.mak before running
make solves the issue.


Laurent

>  # see if system emulation was really requested
> --
> 1.7.11.4
>
>

Re: [Qemu-devel] [PATCH] configure: fix "--target-list=<target>, <target>, ..." option

[Peter Maydell]

On 12 September 2012 14:20, Laurent Desnogues
<laurent.desnogues@gmail.com> wrote:
> Sorry, I had missed this patch...
>
> On Tue, Sep 11, 2012 at 9:02 PM, Eduardo Habkost <ehabkost@redhat.com> wrote:
>> commit 66d5499b3754b83c09487259c08fe2ce73188a59 broke the support for
>> comma-separated target lists on the --target-list option. e.g.:
>>
>>   $ ./configure --target-list=x86_64-linux-user,x86_64-softmmu
>>   [...]
>>   ERROR: Target 'x86_64-linux-user,x86_64-softmmu' not recognised
>>   $
>>
>> This patch restores that ability.
>>
>> Signed-off-by: Eduardo Habkost <ehabkost@redhat.com>
>> Cc: Daniel P. Berrange <berrange@redhat.com>
>> Cc: Anthony Liguori <anthony@codemonkey.ws>
>> ---
>>  configure | 4 +++-
>>  1 file changed, 3 insertions(+), 1 deletion(-)
>>
>> diff --git a/configure b/configure
>> index 7656c32..9ee7038 100755
>> --- a/configure
>> +++ b/configure
>> @@ -1323,7 +1323,9 @@ if ! "$python" -c 'import sys; sys.exit(sys.version_info < (2,4) or sys.version_
>>  fi
>>
>>  if test "$target_list" = "DEFAULT" ; then
>> -    target_list=`echo "$default_target_list" | sed -e 's/,/ /g'`
>> +    target_list="$default_target_list"
>> +else
>> +    target_list=`echo "$target_list" | sed -e 's/,/ /g'`
>>  fi
>
> This works for me too.
>
> But I still can't get what the original patch posted by
> Daniel Berrange intended to do:
>
> $ ./configure --target-list=
> $ make V=1
> cat  | grep =y | sort -u > config-all-devices.mak
>
> And it of course hangs there.

Hmm. Perhaps we should just revert 66d5499b3 and then recommit
a working implementation later?

-- PMM

Re: [Qemu-devel] [PATCH] configure: fix "--target-list=<target>, <target>, ..." option

[Anthony Liguori]

Peter Maydell <peter.maydell@linaro.org> writes:

> On 12 September 2012 14:20, Laurent Desnogues
> <laurent.desnogues@gmail.com> wrote:
>> Sorry, I had missed this patch...
>>
>> On Tue, Sep 11, 2012 at 9:02 PM, Eduardo Habkost <ehabkost@redhat.com> wrote:
>>> commit 66d5499b3754b83c09487259c08fe2ce73188a59 broke the support for
>>> comma-separated target lists on the --target-list option. e.g.:
>>>
>>>   $ ./configure --target-list=x86_64-linux-user,x86_64-softmmu
>>>   [...]
>>>   ERROR: Target 'x86_64-linux-user,x86_64-softmmu' not recognised
>>>   $
>>>
>>> This patch restores that ability.
>>>
>>> Signed-off-by: Eduardo Habkost <ehabkost@redhat.com>
>>> Cc: Daniel P. Berrange <berrange@redhat.com>
>>> Cc: Anthony Liguori <anthony@codemonkey.ws>
>>> ---
>>>  configure | 4 +++-
>>>  1 file changed, 3 insertions(+), 1 deletion(-)
>>>
>>> diff --git a/configure b/configure
>>> index 7656c32..9ee7038 100755
>>> --- a/configure
>>> +++ b/configure
>>> @@ -1323,7 +1323,9 @@ if ! "$python" -c 'import sys; sys.exit(sys.version_info < (2,4) or sys.version_
>>>  fi
>>>
>>>  if test "$target_list" = "DEFAULT" ; then
>>> -    target_list=`echo "$default_target_list" | sed -e 's/,/ /g'`
>>> +    target_list="$default_target_list"
>>> +else
>>> +    target_list=`echo "$target_list" | sed -e 's/,/ /g'`
>>>  fi
>>
>> This works for me too.
>>
>> But I still can't get what the original patch posted by
>> Daniel Berrange intended to do:
>>
>> $ ./configure --target-list=
>> $ make V=1
>> cat  | grep =y | sort -u > config-all-devices.mak
>>
>> And it of course hangs there.
>
> Hmm. Perhaps we should just revert 66d5499b3 and then recommit
> a working implementation later?

I think this is a good idea.

Regards,

Anthony Liguori

>
> -- PMM

Re: [Qemu-devel] [PATCH] configure: fix "--target-list=<target>, <target>, ..." option

[Daniel P. Berrange]

On Fri, Sep 14, 2012 at 01:53:11PM +0100, Peter Maydell wrote:
> On 12 September 2012 14:20, Laurent Desnogues
> <laurent.desnogues@gmail.com> wrote:
> > Sorry, I had missed this patch...
> >
> > On Tue, Sep 11, 2012 at 9:02 PM, Eduardo Habkost <ehabkost@redhat.com> wrote:
> >> commit 66d5499b3754b83c09487259c08fe2ce73188a59 broke the support for
> >> comma-separated target lists on the --target-list option. e.g.:
> >>
> >>   $ ./configure --target-list=x86_64-linux-user,x86_64-softmmu
> >>   [...]
> >>   ERROR: Target 'x86_64-linux-user,x86_64-softmmu' not recognised
> >>   $
> >>
> >> This patch restores that ability.
> >>
> >> Signed-off-by: Eduardo Habkost <ehabkost@redhat.com>
> >> Cc: Daniel P. Berrange <berrange@redhat.com>
> >> Cc: Anthony Liguori <anthony@codemonkey.ws>
> >> ---
> >>  configure | 4 +++-
> >>  1 file changed, 3 insertions(+), 1 deletion(-)
> >>
> >> diff --git a/configure b/configure
> >> index 7656c32..9ee7038 100755
> >> --- a/configure
> >> +++ b/configure
> >> @@ -1323,7 +1323,9 @@ if ! "$python" -c 'import sys; sys.exit(sys.version_info < (2,4) or sys.version_
> >>  fi
> >>
> >>  if test "$target_list" = "DEFAULT" ; then
> >> -    target_list=`echo "$default_target_list" | sed -e 's/,/ /g'`
> >> +    target_list="$default_target_list"
> >> +else
> >> +    target_list=`echo "$target_list" | sed -e 's/,/ /g'`
> >>  fi
> >
> > This works for me too.
> >
> > But I still can't get what the original patch posted by
> > Daniel Berrange intended to do:
> >
> > $ ./configure --target-list=
> > $ make V=1
> > cat  | grep =y | sort -u > config-all-devices.mak
> >
> > And it of course hangs there.

Urgh, I see what went wrong. When I tested it, I still had a previously
generated 'config-all-devices.mak' so this broken rule never hit me.

When I 'git clean -f -x -d', then I see the same problem as you
descibe.

> Hmm. Perhaps we should just revert 66d5499b3 and then recommit
> a working implementation later?

Agreed, sorry for the screw up with this patch.

Daniel
-- 
|: http://berrange.com      -o-    http://www.flickr.com/photos/dberrange/ :|
|: http://libvirt.org              -o-             http://virt-manager.org :|
|: http://autobuild.org       -o-         http://search.cpan.org/~danberr/ :|
|: http://entangle-photo.org       -o-       http://live.gnome.org/gtk-vnc :|

Re: [Qemu-devel] [PATCH] configure: fix "--target-list=<target>, <target>, ..." option

[Stefan Weil]

Am 14.09.2012 14:53, schrieb Peter Maydell:
> On 12 September 2012 14:20, Laurent Desnogues
> <laurent.desnogues@gmail.com>  wrote:
>> Sorry, I had missed this patch...
>>
>> On Tue, Sep 11, 2012 at 9:02 PM, Eduardo Habkost<ehabkost@redhat.com>  wrote:
>>> commit 66d5499b3754b83c09487259c08fe2ce73188a59 broke the support for
>>> comma-separated target lists on the --target-list option. e.g.:
>>>
>>>    $ ./configure --target-list=x86_64-linux-user,x86_64-softmmu
>>>    [...]
>>>    ERROR: Target 'x86_64-linux-user,x86_64-softmmu' not recognised
>>>    $
>>>
>>> This patch restores that ability.
>>>
>>> Signed-off-by: Eduardo Habkost<ehabkost@redhat.com>
>>> Cc: Daniel P. Berrange<berrange@redhat.com>
>>> Cc: Anthony Liguori<anthony@codemonkey.ws>
>>> ---
>>>   configure | 4 +++-
>>>   1 file changed, 3 insertions(+), 1 deletion(-)
>>>
>>> diff --git a/configure b/configure
>>> index 7656c32..9ee7038 100755
>>> --- a/configure
>>> +++ b/configure
>>> @@ -1323,7 +1323,9 @@ if ! "$python" -c 'import sys; sys.exit(sys.version_info<  (2,4) or sys.version_
>>>   fi
>>>
>>>   if test "$target_list" = "DEFAULT" ; then
>>> -    target_list=`echo "$default_target_list" | sed -e 's/,/ /g'`
>>> +    target_list="$default_target_list"
>>> +else
>>> +    target_list=`echo "$target_list" | sed -e 's/,/ /g'`
>>>   fi
>>
>> This works for me too.
>>
>> But I still can't get what the original patch posted by
>> Daniel Berrange intended to do:
>>
>> $ ./configure --target-list=
>> $ make V=1
>> cat  | grep =y | sort -u>  config-all-devices.mak
>>
>> And it of course hangs there.
>
> Hmm. Perhaps we should just revert 66d5499b3 and then recommit
> a working implementation later?
>
> -- PMM


make hangs while waiting for input on stdin:
if there is no emulation target, 'cat' is called without arguments.

I have sent a patch which fixes this. It can be applied after
reverting 66d5499b3 (which is not needed to get builds
without emulation targets).

Regards
Stefan W.

Re: [Qemu-devel] [PATCH v2] Add ability to disable build of all targets

[Laurent Desnogues]

On Tue, Sep 11, 2012 at 8:56 PM, Eduardo Habkost <ehabkost@redhat.com> wrote:
> On Mon, Sep 10, 2012 at 06:00:54PM -0500, Anthony Liguori wrote:
>> "Daniel P. Berrange" <berrange@redhat.com> writes:
>>
>> > From: "Daniel P. Berrange" <berrange@redhat.com>
>> >
>> > Allow passing of '--target-list=' to configure to request that
>> > all targets are to be disabled. This allows for doing a very
>> > fast tools-only build of things like qemu-img, qemu-io, qemu-nbd.
>> >
>> > Signed-off-by: Daniel P. Berrange <berrange@redhat.com>
>>
>> Applied. Thanks.
>
> This patch broke the --target-list option:
>
>   $ ./configure --target-list=x86_64-linux-user,x86_64-softmmu
>   [...]
>   ERROR: Target 'x86_64-linux-user,x86_64-softmmu' not recognised
>   $

It also seems to not even allow to use --target-list=.  On my setup
(CentOS 5.6, building in the git directory) the build process just
hangs here:

$ make V=1
cat  | grep =y | sort -u > config-all-devices.mak


Laurent

>>
>> Regards,
>>
>> Anthony Liguori
>>
>> > ---
>> >  configure | 13 ++++---------
>> >  1 file changed, 4 insertions(+), 9 deletions(-)
>> >
>> > diff --git a/configure b/configure
>> > index 75dc9da..472374e 100755
>> > --- a/configure
>> > +++ b/configure
>> > @@ -127,7 +127,7 @@ cc_i386=i386-pc-linux-gnu-gcc
>> >  libs_qga=""
>> >  debug_info="yes"
>> >
>> > -target_list=""
>> > +target_list="DEFAULT"
>> >
>> >  # Default value for a variable defining feature "foo".
>> >  #  * foo="no"  feature will only be used if --enable-foo arg is given
>> > @@ -1319,15 +1319,10 @@ if ! "$python" -c 'import sys; sys.exit(sys.version_info < (2,4) or sys.version_
>> >    exit 1
>> >  fi
>> >
>> > -if test -z "$target_list" ; then
>> > -    target_list="$default_target_list"
>> > -else
>> > -    target_list=`echo "$target_list" | sed -e 's/,/ /g'`
>> > -fi
>> > -if test -z "$target_list" ; then
>> > -    echo "No targets enabled"
>> > -    exit 1
>> > +if test "$target_list" = "DEFAULT" ; then
>> > +    target_list=`echo "$default_target_list" | sed -e 's/,/ /g'`
>> >  fi
>> > +
>> >  # see if system emulation was really requested
>> >  case " $target_list " in
>> >    *"-softmmu "*) softmmu=yes
>> > --
>> > 1.7.11.2
>>
>
> --
> Eduardo
>