From: Arnd Bergmann <arnd@arndb.de>
To: "AnilKumar, Chimata" <anilkumar@ti.com>
Cc: "gregkh@linuxfoundation.org" <gregkh@linuxfoundation.org>,
"eric.piel@tremplin-utc.net" <eric.piel@tremplin-utc.net>,
"jic23@cam.ac.uk" <jic23@cam.ac.uk>,
"greg@kroah.com" <greg@kroah.com>,
"akpm@linux-foundation.org" <akpm@linux-foundation.org>,
"broonie@opensource.wolfsonmicro.com"
<broonie@opensource.wolfsonmicro.com>,
"dmitry.torokhov@gmail.com" <dmitry.torokhov@gmail.com>,
"linux-omap@vger.kernel.org" <linux-omap@vger.kernel.org>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
"devicetree-discuss@lists.ozlabs.org"
<devicetree-discuss@lists.ozlabs.org>,
"grant.likely@secretlab.ca" <grant.likely@secretlab.ca>,
Daniel Mack <zonque@gmail.com>
Subject: Re: [PATCH 2/2] ARM: dts: AM33XX: Add lis331dlh device tree data to am335x-evm
Date: Fri, 14 Sep 2012 15:29:57 +0000 [thread overview]
Message-ID: <201209141529.57295.arnd@arndb.de> (raw)
In-Reply-To: <331ABD5ECB02734CA317220B2BBEABC13EA2F2B1@DBDE01.ent.ti.com>
On Friday 14 September 2012, AnilKumar, Chimata wrote:
> Small question here, in my v2 version I have specified both
> the compatible names lis3lv02d and lis331dlh is it fine or
> only one is sufficient?
>
> +static struct of_device_id lis3lv02d_i2c_dt_ids[] = {
> + { .compatible = "st,lis3lv02d" },
> + { .compatible = "st,lis331dlh" },
> + {}
> +};
>
That's ok. In most cases, people will need the data field to point to a
data structure with the differences between two chips, but not if they are
identical from the software side.
It's also fine if you just list one entry here and put both values as
"compatible" in the device tree, to signify that the device is backwards
compatible with the older variant.
Arnd
WARNING: multiple messages have this Message-ID (diff)
From: arnd@arndb.de (Arnd Bergmann)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 2/2] ARM: dts: AM33XX: Add lis331dlh device tree data to am335x-evm
Date: Fri, 14 Sep 2012 15:29:57 +0000 [thread overview]
Message-ID: <201209141529.57295.arnd@arndb.de> (raw)
In-Reply-To: <331ABD5ECB02734CA317220B2BBEABC13EA2F2B1@DBDE01.ent.ti.com>
On Friday 14 September 2012, AnilKumar, Chimata wrote:
> Small question here, in my v2 version I have specified both
> the compatible names lis3lv02d and lis331dlh is it fine or
> only one is sufficient?
>
> +static struct of_device_id lis3lv02d_i2c_dt_ids[] = {
> + { .compatible = "st,lis3lv02d" },
> + { .compatible = "st,lis331dlh" },
> + {}
> +};
>
That's ok. In most cases, people will need the data field to point to a
data structure with the differences between two chips, but not if they are
identical from the software side.
It's also fine if you just list one entry here and put both values as
"compatible" in the device tree, to signify that the device is backwards
compatible with the older variant.
Arnd
next prev parent reply other threads:[~2012-09-14 15:30 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-09-13 15:54 [PATCH 0/2] lis3: lis3lv02d_i2c: Add device tree support AnilKumar Ch
2012-09-13 15:54 ` AnilKumar Ch
2012-09-13 15:54 ` [PATCH 1/2] " AnilKumar Ch
2012-09-13 15:54 ` AnilKumar Ch
2012-09-13 15:54 ` [PATCH 2/2] ARM: dts: AM33XX: Add lis331dlh device tree data to am335x-evm AnilKumar Ch
2012-09-13 15:54 ` AnilKumar Ch
2012-09-14 8:26 ` Arnd Bergmann
2012-09-14 8:26 ` Arnd Bergmann
2012-09-14 9:18 ` AnilKumar, Chimata
2012-09-14 9:18 ` AnilKumar, Chimata
2012-09-14 10:28 ` Arnd Bergmann
2012-09-14 10:28 ` Arnd Bergmann
[not found] ` <201209141028.38185.arnd-r2nGTMty4D4@public.gmane.org>
2012-09-14 11:16 ` AnilKumar, Chimata
2012-09-14 11:16 ` AnilKumar, Chimata
2012-09-14 15:29 ` Arnd Bergmann [this message]
2012-09-14 15:29 ` Arnd Bergmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201209141529.57295.arnd@arndb.de \
--to=arnd@arndb.de \
--cc=akpm@linux-foundation.org \
--cc=anilkumar@ti.com \
--cc=broonie@opensource.wolfsonmicro.com \
--cc=devicetree-discuss@lists.ozlabs.org \
--cc=dmitry.torokhov@gmail.com \
--cc=eric.piel@tremplin-utc.net \
--cc=grant.likely@secretlab.ca \
--cc=greg@kroah.com \
--cc=gregkh@linuxfoundation.org \
--cc=jic23@cam.ac.uk \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-omap@vger.kernel.org \
--cc=zonque@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.