From: Samuel Ortiz <sameo@linux.intel.com>
To: Julia Lawall <julia.lawall@lip6.fr>
Cc: Dan Carpenter <dan.carpenter@oracle.com>,
kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/6] drivers/mfd: drop frees of devm allocated data
Date: Sun, 16 Sep 2012 23:24:48 +0000 [thread overview]
Message-ID: <20120916232448.GO3647@sortiz-mobl> (raw)
In-Reply-To: <alpine.DEB.2.02.1208132135380.2355@localhost6.localdomain6>
Hi Julia,
On Mon, Aug 13, 2012 at 09:36:06PM +0200, Julia Lawall wrote:
> From: Julia Lawall <Julia.Lawall@lip6.fr>
>
> devm_kfree should not have to be explicitly used.
> devm_regmap_init_i2c also does not require an explicit free.
>
> The semantic patch that fixes the first problem is as follows:
> (http://coccinelle.lip6.fr/)
>
> // <smpl>
> @@
> expression x,d;
> @@
>
> x = devm_kzalloc(...)
> ...
> ?-devm_kfree(d,x);
> // </smpl>
>
> Signed-off-by: Julia Lawall <Julia.Lawall@lip6.fr>
>
> ---
> v2: Removed over-eager optimization of some error-handling code.
>
> drivers/mfd/88pm800.c | 5 +----
> drivers/mfd/88pm80x.c | 19 +++----------------
> 2 files changed, 4 insertions(+), 20 deletions(-)
This one does not apply to my for-next branch, would you please mind rebasing
it against that branch ?
Cheers,
Samuel.
--
Intel Open Source Technology Centre
http://oss.intel.com/
WARNING: multiple messages have this Message-ID (diff)
From: Samuel Ortiz <sameo@linux.intel.com>
To: Julia Lawall <julia.lawall@lip6.fr>
Cc: Dan Carpenter <dan.carpenter@oracle.com>,
kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/6] drivers/mfd: drop frees of devm allocated data
Date: Mon, 17 Sep 2012 01:24:48 +0200 [thread overview]
Message-ID: <20120916232448.GO3647@sortiz-mobl> (raw)
In-Reply-To: <alpine.DEB.2.02.1208132135380.2355@localhost6.localdomain6>
Hi Julia,
On Mon, Aug 13, 2012 at 09:36:06PM +0200, Julia Lawall wrote:
> From: Julia Lawall <Julia.Lawall@lip6.fr>
>
> devm_kfree should not have to be explicitly used.
> devm_regmap_init_i2c also does not require an explicit free.
>
> The semantic patch that fixes the first problem is as follows:
> (http://coccinelle.lip6.fr/)
>
> // <smpl>
> @@
> expression x,d;
> @@
>
> x = devm_kzalloc(...)
> ...
> ?-devm_kfree(d,x);
> // </smpl>
>
> Signed-off-by: Julia Lawall <Julia.Lawall@lip6.fr>
>
> ---
> v2: Removed over-eager optimization of some error-handling code.
>
> drivers/mfd/88pm800.c | 5 +----
> drivers/mfd/88pm80x.c | 19 +++----------------
> 2 files changed, 4 insertions(+), 20 deletions(-)
This one does not apply to my for-next branch, would you please mind rebasing
it against that branch ?
Cheers,
Samuel.
--
Intel Open Source Technology Centre
http://oss.intel.com/
next prev parent reply other threads:[~2012-09-16 23:24 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-08-04 16:50 [PATCH 2/6] drivers/mfd: drop frees of devm allocated data Julia Lawall
2012-08-04 16:50 ` Julia Lawall
2012-08-06 14:05 ` Dan Carpenter
2012-08-06 14:05 ` Dan Carpenter
2012-08-06 19:57 ` Julia.Lawall
2012-08-06 19:57 ` Julia.Lawall
2012-08-13 19:36 ` Julia Lawall
2012-08-13 19:36 ` Julia Lawall
2012-09-16 23:24 ` Samuel Ortiz [this message]
2012-09-16 23:24 ` Samuel Ortiz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120916232448.GO3647@sortiz-mobl \
--to=sameo@linux.intel.com \
--cc=dan.carpenter@oracle.com \
--cc=julia.lawall@lip6.fr \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.