All of lore.kernel.org
 help / color / mirror / Atom feed
From: Roman Mamedov <rm@romanrm.ru>
To: miaox@cn.fujitsu.com
Cc: Hidetoshi Seto <seto.hidetoshi@jp.fujitsu.com>,
	linux-btrfs@vger.kernel.org
Subject: Re: [PATCH 2/2] Btrfs-progs: add mount-option command
Date: Tue, 18 Sep 2012 10:19:30 +0600	[thread overview]
Message-ID: <20120918101930.6f3edb3c@natsu> (raw)
In-Reply-To: <5057DD0D.1070201@cn.fujitsu.com>

[-- Attachment #1: Type: text/plain, Size: 1047 bytes --]

On Tue, 18 Sep 2012 10:31:41 +0800
Miao Xie <miaox@cn.fujitsu.com> wrote:

> On tue, 18 Sep 2012 10:30:17 +0900, Hidetoshi Seto wrote:
> > This patch adds mount-option command.
> > The command can set/get default mount options.
> > Now, the command can set/get 24 options.
> > These options are equal to mount options which store
> > in fs_info/mount-opt.
> 
> I don't think we need implement a separate command to do this,
> we can add it into btrfstune just like ext3/4. If so, the users
> who used ext3/4 before can be familiar with btrfs command as soon
> as possible.

btrfstune currently only does one thing:

$ sudo btrfstune
usage: btrfstune [options] device
	-S value	enable/disable seeding

To me it'd seem more logical the other way, why not move this operation to the
base "btrfs" utility under some command, and remove "btrfstune" completely.

-- 
With respect,
Roman

~~~~~~~~~~~~~~~~~~~~~~~~~~~
"Stallman had a printer,
with code he could not see.
So he began to tinker,
and set the software free."

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 198 bytes --]

  reply	other threads:[~2012-09-18  4:19 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-09-18  1:25 [PATCH 0/2] Btrfs: set mount options permanently Hidetoshi Seto
2012-09-18  1:28 ` [PATCH 1/2] Btrfs: make space to keep default mount options Hidetoshi Seto
2012-09-18 12:10   ` David Sterba
2012-09-19  8:31     ` Hidetoshi Seto
2012-09-20 11:05       ` David Sterba
2012-09-18  1:30 ` [PATCH 2/2] Btrfs-progs: add mount-option command Hidetoshi Seto
2012-09-18  2:31   ` Miao Xie
2012-09-18  4:19     ` Roman Mamedov [this message]
2012-09-18  8:19       ` Hugo Mills
2012-09-18 12:06         ` David Sterba
2012-09-19  8:32     ` Hidetoshi Seto
2012-09-20 11:14       ` David Sterba
2012-09-18 12:30   ` David Sterba
2012-09-19  8:32     ` Hidetoshi Seto
2012-09-18 10:03 ` R: " Goffredo Baroncelli <kreijack@libero.it>
2012-09-19  8:31   ` Hidetoshi Seto
2012-09-20 11:28   ` David Sterba
2012-09-18 11:37 ` R: " Goffredo Baroncelli <kreijack@libero.it>

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20120918101930.6f3edb3c@natsu \
    --to=rm@romanrm.ru \
    --cc=linux-btrfs@vger.kernel.org \
    --cc=miaox@cn.fujitsu.com \
    --cc=seto.hidetoshi@jp.fujitsu.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.