From: David Sterba <dave@jikos.cz>
To: "Goffredo Baroncelli <kreijack@libero.it>" <kreijack@libero.it>
Cc: seto.hidetoshi@jp.fujitsu.com, linux-btrfs@vger.kernel.org
Subject: Re: R: [PATCH 2/2] Btrfs-progs: add mount-option command
Date: Thu, 20 Sep 2012 13:28:55 +0200 [thread overview]
Message-ID: <20120920112855.GI17430@twin.jikos.cz> (raw)
In-Reply-To: <26356142.2062531347962627486.JavaMail.root@wmail62>
On Tue, Sep 18, 2012 at 12:03:47PM +0200, Goffredo Baroncelli <kreijack@libero.it> wrote:
> Why it was not provided a way to clear a *single* flag ? To me it seems a bit
> too long to clear all the flag (btrfs mount-option clear) and then set the
> right one.
>
> As user interface I suggest something like chmod:
>
> btrfs mount-option set +ssd,skip_balance -nodatacow /dev/sdX
>
> or
>
> btrfs mount-option set =ssd,skip_balance,nodatacow /dev/sdX
I agree with the +/-/= syntax, it's quite intuitive and already seen
(chattr).
I'd drop the 'set' command here, with some options specified it's
implied.
Without any it's 'get'
btrfs mount-option /dev/...
And the 'clear' subcommand could be also dropped with this syntax
btrfs mount-option = /dev/...
:)
BTW, this modifies the defaults only for the unmounted filesystem, but
the same should be possible for a mounted one in the future.
david
next prev parent reply other threads:[~2012-09-20 11:29 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-09-18 1:25 [PATCH 0/2] Btrfs: set mount options permanently Hidetoshi Seto
2012-09-18 1:28 ` [PATCH 1/2] Btrfs: make space to keep default mount options Hidetoshi Seto
2012-09-18 12:10 ` David Sterba
2012-09-19 8:31 ` Hidetoshi Seto
2012-09-20 11:05 ` David Sterba
2012-09-18 1:30 ` [PATCH 2/2] Btrfs-progs: add mount-option command Hidetoshi Seto
2012-09-18 2:31 ` Miao Xie
2012-09-18 4:19 ` Roman Mamedov
2012-09-18 8:19 ` Hugo Mills
2012-09-18 12:06 ` David Sterba
2012-09-19 8:32 ` Hidetoshi Seto
2012-09-20 11:14 ` David Sterba
2012-09-18 12:30 ` David Sterba
2012-09-19 8:32 ` Hidetoshi Seto
2012-09-18 10:03 ` R: " Goffredo Baroncelli <kreijack@libero.it>
2012-09-19 8:31 ` Hidetoshi Seto
2012-09-20 11:28 ` David Sterba [this message]
2012-09-18 11:37 ` R: " Goffredo Baroncelli <kreijack@libero.it>
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120920112855.GI17430@twin.jikos.cz \
--to=dave@jikos.cz \
--cc=kreijack@libero.it \
--cc=linux-btrfs@vger.kernel.org \
--cc=seto.hidetoshi@jp.fujitsu.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.