From: arnd@arndb.de (Arnd Bergmann)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] spi/pl022: Devicetree support w/o platform data
Date: Tue, 18 Sep 2012 13:13:30 +0000 [thread overview]
Message-ID: <201209181313.30880.arnd@arndb.de> (raw)
In-Reply-To: <1347972540-29667-1-git-send-email-stigge@antcom.de>
On Tuesday 18 September 2012, Roland Stigge wrote:
> --- linux-2.6.orig/Documentation/devicetree/bindings/spi/spi_pl022.txt
> +++ linux-2.6/Documentation/devicetree/bindings/spi/spi_pl022.txt
> @@ -10,6 +10,15 @@ Optional properties:
> - cs-gpios : should specify GPIOs used for chipselects.
> The gpios will be referred to as reg = <index> in the SPI child nodes.
> If unspecified, a single SPI device without a chip select can be used.
> +- pl022,bus-id : Bus ID (0, 1, ...)
I don't understand why we need the bus-id here. My understanding is that
this is a linux-specific number that should not be necessary when all
devices are described in the device tree rather than through spi_board_info.
Can't you just set master->bus_num to -1 when using the DT for probing?
> +- pl022,enable-dma : enables DMA driven transfers (boolean)
Similar thing here: Can't you just set the enable_dma flag when
a dma channel is provided in the device tree and unset it otherwise?
It also seems a bit pointless to enable DMA mode when you don't provide
a way to specify the channel at the same time.
Arnd
WARNING: multiple messages have this Message-ID (diff)
From: Arnd Bergmann <arnd-r2nGTMty4D4@public.gmane.org>
To: Roland Stigge <stigge-uj/7R2tJ6VmzQB+pC5nmwQ@public.gmane.org>
Cc: srinivas.bakki-3arQi8VN3Tc@public.gmane.org,
broonie-yzvPICuk2AATkU/dhu1WVueM+bqZidxxQQ4Iyu8u01E@public.gmane.org,
linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
kevin.wells-3arQi8VN3Tc@public.gmane.org,
aletes.xgr-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org,
STEricsson_nomadik_linux-nkJGhpqTU55BDgjK7y7TUQ@public.gmane.org,
lee.jones-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org,
devicetree-discuss-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org,
linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org
Subject: Re: [PATCH] spi/pl022: Devicetree support w/o platform data
Date: Tue, 18 Sep 2012 13:13:30 +0000 [thread overview]
Message-ID: <201209181313.30880.arnd@arndb.de> (raw)
In-Reply-To: <1347972540-29667-1-git-send-email-stigge-uj/7R2tJ6VmzQB+pC5nmwQ@public.gmane.org>
On Tuesday 18 September 2012, Roland Stigge wrote:
> --- linux-2.6.orig/Documentation/devicetree/bindings/spi/spi_pl022.txt
> +++ linux-2.6/Documentation/devicetree/bindings/spi/spi_pl022.txt
> @@ -10,6 +10,15 @@ Optional properties:
> - cs-gpios : should specify GPIOs used for chipselects.
> The gpios will be referred to as reg = <index> in the SPI child nodes.
> If unspecified, a single SPI device without a chip select can be used.
> +- pl022,bus-id : Bus ID (0, 1, ...)
I don't understand why we need the bus-id here. My understanding is that
this is a linux-specific number that should not be necessary when all
devices are described in the device tree rather than through spi_board_info.
Can't you just set master->bus_num to -1 when using the DT for probing?
> +- pl022,enable-dma : enables DMA driven transfers (boolean)
Similar thing here: Can't you just set the enable_dma flag when
a dma channel is provided in the device tree and unset it otherwise?
It also seems a bit pointless to enable DMA mode when you don't provide
a way to specify the channel at the same time.
Arnd
WARNING: multiple messages have this Message-ID (diff)
From: Arnd Bergmann <arnd@arndb.de>
To: Roland Stigge <stigge@antcom.de>
Cc: broonie@opensource.wolfsonmicro.com, grant.likely@secretlab.ca,
linus.walleij@linaro.org, lee.jones@linaro.org,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org,
STEricsson_nomadik_linux@list.st.com,
devicetree-discuss@lists.ozlabs.org, aletes.xgr@gmail.com,
kevin.wells@nxp.com, srinivas.bakki@nxp.com
Subject: Re: [PATCH] spi/pl022: Devicetree support w/o platform data
Date: Tue, 18 Sep 2012 13:13:30 +0000 [thread overview]
Message-ID: <201209181313.30880.arnd@arndb.de> (raw)
In-Reply-To: <1347972540-29667-1-git-send-email-stigge@antcom.de>
On Tuesday 18 September 2012, Roland Stigge wrote:
> --- linux-2.6.orig/Documentation/devicetree/bindings/spi/spi_pl022.txt
> +++ linux-2.6/Documentation/devicetree/bindings/spi/spi_pl022.txt
> @@ -10,6 +10,15 @@ Optional properties:
> - cs-gpios : should specify GPIOs used for chipselects.
> The gpios will be referred to as reg = <index> in the SPI child nodes.
> If unspecified, a single SPI device without a chip select can be used.
> +- pl022,bus-id : Bus ID (0, 1, ...)
I don't understand why we need the bus-id here. My understanding is that
this is a linux-specific number that should not be necessary when all
devices are described in the device tree rather than through spi_board_info.
Can't you just set master->bus_num to -1 when using the DT for probing?
> +- pl022,enable-dma : enables DMA driven transfers (boolean)
Similar thing here: Can't you just set the enable_dma flag when
a dma channel is provided in the device tree and unset it otherwise?
It also seems a bit pointless to enable DMA mode when you don't provide
a way to specify the channel at the same time.
Arnd
next prev parent reply other threads:[~2012-09-18 13:13 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-09-18 12:49 [PATCH] spi/pl022: Devicetree support w/o platform data Roland Stigge
2012-09-18 12:49 ` Roland Stigge
2012-09-18 12:49 ` Roland Stigge
2012-09-18 13:03 ` Alexandre Pereira da Silva
2012-09-18 13:03 ` Alexandre Pereira da Silva
2012-09-18 13:13 ` Arnd Bergmann [this message]
2012-09-18 13:13 ` Arnd Bergmann
2012-09-18 13:13 ` Arnd Bergmann
2012-09-18 13:52 ` Roland Stigge
2012-09-18 13:52 ` Roland Stigge
-- strict thread matches above, loose matches on Subject: below --
2012-09-17 16:59 Roland Stigge
2012-09-17 16:59 ` Roland Stigge
2012-09-18 12:03 ` Linus Walleij
2012-09-18 12:03 ` Linus Walleij
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201209181313.30880.arnd@arndb.de \
--to=arnd@arndb.de \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.