All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] gpio-pcf857x: avoid an empty kernel message in case no irq is configured
@ 2012-09-18 14:50 Christian Engelmayer
  0 siblings, 0 replies; only message in thread
From: Christian Engelmayer @ 2012-09-18 14:50 UTC (permalink / raw)
  To: linux-kernel; +Cc: christian.engelmayer, grant.likely

Avoid a needless kernel message in case there is no client irq to be ignored.

   [    2.856058] gpiochip_add: registered GPIOs 248 to 255 on device: pcf8574
   [    2.862830] pcf857x 1-0020:

Signed-off-by: Christian Engelmayer <christian.engelmayer@frequentis.com>
---
--- a/drivers/gpio/gpio-pcf857x.c	2012-07-06 09:19:07.000000000 +0200
+++ b/drivers/gpio/gpio-pcf857x.c	2012-07-06 09:21:15.000000000 +0200
@@ -290,8 +290,8 @@ static int pcf857x_probe(struct i2c_clie
 	 * methods can't be called from sleeping contexts.
 	 */
 
-	dev_info(&client->dev, "%s\n",
-			client->irq ? " (irq ignored)" : "");
+	if (client->irq)
+		dev_info(&client->dev, " (irq ignored)\n");
 
 	/* Let platform code set up the GPIOs and their users.
 	 * Now is the first time anyone could use them.

^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2012-09-18 15:00 UTC | newest]

Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-09-18 14:50 [PATCH] gpio-pcf857x: avoid an empty kernel message in case no irq is configured Christian Engelmayer

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.