From: Ben Hutchings <ben@decadent.org.uk>
To: David Miller <davem@davemloft.net>
Cc: acme@ghostprotocols.net, netdev@vger.kernel.org
Subject: Re: [PATCH 0/6] llc2: Simplify llc_station
Date: Tue, 18 Sep 2012 18:49:55 +0100 [thread overview]
Message-ID: <20120918174955.GD29217@decadent.org.uk> (raw)
In-Reply-To: <20120917.131237.518528991078697534.davem@davemloft.net>
On Mon, Sep 17, 2012 at 01:12:37PM -0400, David Miller wrote:
> From: David Miller <davem@davemloft.net>
> Date: Mon, 17 Sep 2012 13:10:17 -0400 (EDT)
>
> > From: David Miller <davem@davemloft.net>
> > Date: Mon, 17 Sep 2012 13:05:31 -0400 (EDT)
> >
> >> From: Ben Hutchings <ben@decadent.org.uk>
> >> Date: Sun, 16 Sep 2012 04:09:42 +0100
> >>
> >>> There seem to have been some grand plans for llc_station, but as they
> >>> haven't been fulfilled it's just unnecessarily complicated.
> >>
> >> I went over these a few times, they look correct, so I am going
> >> to apply them to net-next.
> >>
> >> If there are any problems let's hope that exposure in the tree
> >> helps shake those out.
> >
> > It doesn't even build properly, please fix this and resubmit:
> >
> > ERROR: "sysctl_llc_station_ack_timeout" [net/llc/llc2.ko] undefined!
>
> Actually, since I trusted you when you said you build tested this,
> I pushed it out to net-next pre-maturely.
>
> I'm going to fix this meanwhile by simply removing the sysctl that
> references this symbol.
>
> But you need to check for me whether that's ok or not.
The sysctl had no effect so I think it's fairly safe to assume nothing
depends on it. Thanks.
Ben.
--
Ben Hutchings
We get into the habit of living before acquiring the habit of thinking.
- Albert Camus
next prev parent reply other threads:[~2012-09-18 17:50 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-09-16 3:09 [PATCH 0/6] llc2: Simplify llc_station Ben Hutchings
2012-09-16 3:10 ` [PATCH net-next 1/6] llc2: Remove pointless indirection through llc_stat_state_trans_end Ben Hutchings
2012-09-16 3:11 ` [PATCH net-next 2/6] llc2: Remove dead code for state machine Ben Hutchings
2012-09-16 3:11 ` [PATCH net-next 3/6] llc2: Collapse the station event receive path Ben Hutchings
2012-09-16 3:11 ` [PATCH net-next 4/6] llc2: Remove the station send queue Ben Hutchings
2012-09-16 3:11 ` [PATCH net-next 5/6] llc2: Remove explicit indexing of state action arrays Ben Hutchings
2012-09-16 3:11 ` [PATCH net-next 6/6] llc2: Collapse remainder of state machine into simple if-else if-statement Ben Hutchings
2012-09-16 3:13 ` [PATCH 0/6] llc2: Simplify llc_station Ben Hutchings
2012-09-17 17:05 ` David Miller
2012-09-17 17:10 ` David Miller
2012-09-17 17:12 ` David Miller
2012-09-18 17:49 ` Ben Hutchings [this message]
2012-09-18 17:29 ` Ben Hutchings
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120918174955.GD29217@decadent.org.uk \
--to=ben@decadent.org.uk \
--cc=acme@ghostprotocols.net \
--cc=davem@davemloft.net \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.