All of lore.kernel.org
 help / color / mirror / Atom feed
From: Ben Myers <bpm@sgi.com>
To: Jan Kara <jack@suse.cz>
Cc: Dave Chinner <david@fromorbit.com>,
	linux-ext4@vger.kernel.org, dmonakhov@openvz.org,
	xfs@oss.sgi.com
Subject: Re: Test 272 fails for ext3
Date: Tue, 18 Sep 2012 16:26:40 -0500	[thread overview]
Message-ID: <20120918212640.GW3274@sgi.com> (raw)
In-Reply-To: <20120821080338.GA7537@quack.suse.cz>

On Tue, Aug 21, 2012 at 10:03:39AM +0200, Jan Kara wrote:
> On Tue 21-08-12 08:49:41, Dave Chinner wrote:
> > On Mon, Aug 20, 2012 at 11:06:38PM +0200, Jan Kara wrote:
> > ....
> > > --- a/272
> > > +++ b/272
> > > @@ -32,15 +32,18 @@ tmp=/tmp/$$
> > >  status=1	# failure is the default!
> > >  trap "rm -f $tmp.*; exit \$status" 0 1 2 3 15
> > >  
> > > +write_opt_list="iflag=noatime conv=notrunc conv=fsync oflag=direct"
> > > +if [ $FSTYP = "ext3" ]; then
> > > +	# ext3 doesn't support direct IO in journalling mode
> > > +	write_opt_list="iflag=noatime conv=notrunc conv=fsync"
> > > +fi
> > 
> > Seems like asking for trouble duplicating the common options.
> > 
> > # ext3 doesn't support direct IO in journalling mode
> > write_opt_list="iflag=noatime conv=notrunc conv=fsync
> > [ $FSTYP = "ext4" ] && write_opt_list="$write_opt_list oflag=direct"
> > 
> > Otherwise looks fine.
> > 
> > Reviewed-by: Dave Chinner <dchinner@redhat.com>
>   OK, I've updated the test as you suggested. Result is attached.

Committed to git://oss.sgi.com/xfs/cmds/xfstests.git, master branch.

WARNING: multiple messages have this Message-ID (diff)
From: Ben Myers <bpm@sgi.com>
To: Jan Kara <jack@suse.cz>
Cc: dmonakhov@openvz.org, linux-ext4@vger.kernel.org, xfs@oss.sgi.com
Subject: Re: Test 272 fails for ext3
Date: Tue, 18 Sep 2012 16:26:40 -0500	[thread overview]
Message-ID: <20120918212640.GW3274@sgi.com> (raw)
In-Reply-To: <20120821080338.GA7537@quack.suse.cz>

On Tue, Aug 21, 2012 at 10:03:39AM +0200, Jan Kara wrote:
> On Tue 21-08-12 08:49:41, Dave Chinner wrote:
> > On Mon, Aug 20, 2012 at 11:06:38PM +0200, Jan Kara wrote:
> > ....
> > > --- a/272
> > > +++ b/272
> > > @@ -32,15 +32,18 @@ tmp=/tmp/$$
> > >  status=1	# failure is the default!
> > >  trap "rm -f $tmp.*; exit \$status" 0 1 2 3 15
> > >  
> > > +write_opt_list="iflag=noatime conv=notrunc conv=fsync oflag=direct"
> > > +if [ $FSTYP = "ext3" ]; then
> > > +	# ext3 doesn't support direct IO in journalling mode
> > > +	write_opt_list="iflag=noatime conv=notrunc conv=fsync"
> > > +fi
> > 
> > Seems like asking for trouble duplicating the common options.
> > 
> > # ext3 doesn't support direct IO in journalling mode
> > write_opt_list="iflag=noatime conv=notrunc conv=fsync
> > [ $FSTYP = "ext4" ] && write_opt_list="$write_opt_list oflag=direct"
> > 
> > Otherwise looks fine.
> > 
> > Reviewed-by: Dave Chinner <dchinner@redhat.com>
>   OK, I've updated the test as you suggested. Result is attached.

Committed to git://oss.sgi.com/xfs/cmds/xfstests.git, master branch.

_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs

  reply	other threads:[~2012-09-18 21:26 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-08-16  9:28 Test 272 fails for ext3 Jan Kara
2012-08-16  9:37 ` Jan Kara
2012-08-16  9:37   ` Jan Kara
2012-08-16 10:07   ` Dmitry Monakhov
2012-08-16 10:07     ` Dmitry Monakhov
2012-08-16 22:48   ` Dave Chinner
2012-08-20 16:22     ` Jan Kara
2012-08-20 16:22       ` Jan Kara
2012-08-20 21:06       ` Jan Kara
2012-08-20 21:06         ` Jan Kara
2012-08-20 22:49         ` Dave Chinner
2012-08-20 22:49           ` Dave Chinner
2012-08-21  8:03           ` Jan Kara
2012-08-21  8:03             ` Jan Kara
2012-09-18 21:26             ` Ben Myers [this message]
2012-09-18 21:26               ` Ben Myers

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20120918212640.GW3274@sgi.com \
    --to=bpm@sgi.com \
    --cc=david@fromorbit.com \
    --cc=dmonakhov@openvz.org \
    --cc=jack@suse.cz \
    --cc=linux-ext4@vger.kernel.org \
    --cc=xfs@oss.sgi.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.