From: Matthew Garrett <mjg@redhat.com>
To: Yinghai Lu <yinghai@kernel.org>
Cc: Bjorn Helgaas <bhelgaas@google.com>,
linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org,
x86@kernel.org, Dave Airlie <airlied@redhat.com>,
Andrew Morton <akpm@linux-foundation.org>,
Julia Lawall <julia@diku.dk>
Subject: Re: [PATCH] PCI: fix default vga ref_count
Date: Wed, 19 Sep 2012 00:54:38 +0100 [thread overview]
Message-ID: <20120918235438.GA13373@srcf.ucam.org> (raw)
In-Reply-To: <1348011882-31452-1-git-send-email-yinghai@kernel.org>
On Tue, Sep 18, 2012 at 04:44:42PM -0700, Yinghai Lu wrote:
> void vga_set_default_device(struct pci_dev *pdev)
> {
> + if (vga_default)
> + pci_dev_put(vga_default);
> +
> + if (pdev)
> + pdev = pci_dev_get(pdev);
> +
> vga_default = pdev;
It shouldn't happen, but do we want to check for the vga_default == pdev
case?
--
Matthew Garrett | mjg59@srcf.ucam.org
prev parent reply other threads:[~2012-09-18 23:54 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-09-15 0:48 [PATCH] PCI, x86: fix default vga ref_count Yinghai Lu
2012-09-15 0:48 ` [PATCH] PCI: Use correct type when freeing bus resource list Yinghai Lu
2012-09-18 22:53 ` Bjorn Helgaas
2012-09-15 0:48 ` [PATCH] PCI, x86: clear initial value for root info resources Yinghai Lu
2012-09-18 22:46 ` Bjorn Helgaas
2012-09-18 23:49 ` Yinghai Lu
2012-09-19 13:12 ` Bjorn Helgaas
2012-09-19 17:17 ` Yinghai Lu
2012-09-19 17:49 ` Yinghai Lu
2012-09-19 17:49 ` [PATCH] PCI, ia64: " Yinghai Lu
2012-09-19 17:49 ` Yinghai Lu
2012-09-21 16:50 ` [PATCH] PCI, x86: " Konrad Rzeszutek Wilk
[not found] ` <CAE9FiQV9WK4NG5+aGwVrGO3ueFH3TmmmG5zea+JjwgtQyngNRg@mail.gmail.com>
2012-09-23 20:33 ` Konrad Rzeszutek Wilk
2012-09-19 15:34 ` Jiang Liu
2012-09-18 22:15 ` [PATCH] PCI, x86: fix default vga ref_count Bjorn Helgaas
2012-09-18 22:39 ` Yinghai Lu
2012-09-18 23:44 ` [PATCH] PCI: " Yinghai Lu
2012-09-18 23:54 ` Matthew Garrett [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120918235438.GA13373@srcf.ucam.org \
--to=mjg@redhat.com \
--cc=airlied@redhat.com \
--cc=akpm@linux-foundation.org \
--cc=bhelgaas@google.com \
--cc=julia@diku.dk \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=x86@kernel.org \
--cc=yinghai@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.