All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jiang Liu <liuj97@gmail.com>
To: Yinghai Lu <yinghai@kernel.org>
Cc: Bjorn Helgaas <bhelgaas@google.com>,
	linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org,
	x86@kernel.org, Tony Luck <tony.luck@intel.com>
Subject: Re: [PATCH] PCI, x86: clear initial value for root info resources
Date: Wed, 19 Sep 2012 23:34:11 +0800	[thread overview]
Message-ID: <5059E5F3.2040809@gmail.com> (raw)
In-Reply-To: <CAE9FiQUxt1kx_SpRWt5eMKvUXuUXwJrd9USeT+WMbCWkDDaQZQ@mail.gmail.com>

On 09/19/2012 07:49 AM, Yinghai Lu wrote:
> On Tue, Sep 18, 2012 at 3:46 PM, Bjorn Helgaas <bhelgaas@google.com> wrote:
>> On Fri, Sep 14, 2012 at 6:48 PM, Yinghai Lu <yinghai@kernel.org> wrote:
>>> Found one system one root bus hot remove get panic.
>>> Panic happens when try to release hostbridge resource.
>>>
>>> It turns out that resource get reject during put into resource tree
>>> because of conflicts.
>>> Also that resource parent pointer have random value.
>>>
>>> That invalid value cause it pass through check __release_pci_root_info
>>> and panic in release_resource.
>>>
>>> Try to use kzalloc instead.
>>
>> Don't we need the same fix for ia64 in pci_acpi_scan_root()?  Here's
>> what it does:
>>
>>         if (windows) {
>>                 controller->window =
>>                         kmalloc_node(sizeof(*controller->window) * windows,
>>                                      GFP_KERNEL, controller->node);
>>
> 
> 
> yes, but they don't support pci_set_host_bridge_release yet. so they
> should not meet this problem yet.
Hi Yinghai,
	We are trying to add pci_set_host_bridge_release() for IA64, so would
appreciate it if you could help to fix IA64 too.
	--Gerry


  parent reply	other threads:[~2012-09-19 15:34 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-09-15  0:48 [PATCH] PCI, x86: fix default vga ref_count Yinghai Lu
2012-09-15  0:48 ` [PATCH] PCI: Use correct type when freeing bus resource list Yinghai Lu
2012-09-18 22:53   ` Bjorn Helgaas
2012-09-15  0:48 ` [PATCH] PCI, x86: clear initial value for root info resources Yinghai Lu
2012-09-18 22:46   ` Bjorn Helgaas
2012-09-18 23:49     ` Yinghai Lu
2012-09-19 13:12       ` Bjorn Helgaas
2012-09-19 17:17         ` Yinghai Lu
2012-09-19 17:49           ` Yinghai Lu
2012-09-19 17:49             ` [PATCH] PCI, ia64: " Yinghai Lu
2012-09-19 17:49               ` Yinghai Lu
2012-09-21 16:50             ` [PATCH] PCI, x86: " Konrad Rzeszutek Wilk
     [not found]               ` <CAE9FiQV9WK4NG5+aGwVrGO3ueFH3TmmmG5zea+JjwgtQyngNRg@mail.gmail.com>
2012-09-23 20:33                 ` Konrad Rzeszutek Wilk
2012-09-19 15:34       ` Jiang Liu [this message]
2012-09-18 22:15 ` [PATCH] PCI, x86: fix default vga ref_count Bjorn Helgaas
2012-09-18 22:39   ` Yinghai Lu
2012-09-18 23:44   ` [PATCH] PCI: " Yinghai Lu
2012-09-18 23:54     ` Matthew Garrett

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5059E5F3.2040809@gmail.com \
    --to=liuj97@gmail.com \
    --cc=bhelgaas@google.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pci@vger.kernel.org \
    --cc=tony.luck@intel.com \
    --cc=x86@kernel.org \
    --cc=yinghai@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.